From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH v6 02/24] mm/gup: factor out duplicate code from four routines Date: Tue, 19 Nov 2019 11:19:10 +0100 Message-ID: <20191119101910.GC25605@quack2.suse.cz> References: <20191119081643.1866232-1-jhubbard@nvidia.com> <20191119081643.1866232-3-jhubbard@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20191119081643.1866232-3-jhubbard@nvidia.com> Sender: linux-kernel-owner@vger.kernel.org To: John Hubbard Cc: Andrew Morton , Al Viro , Alex Williamson , Benjamin Herrenschmidt , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Christoph Hellwig , Dan Williams , Daniel Vetter , Dave Chinner , David Airlie , "David S . Miller" , Ira Weiny , Jan Kara , Jason Gunthorpe , Jens Axboe , Jonathan Corbet , =?iso-8859-1?B?Suly9G1l?= Glisse , Magnus Karlsson , Mauro Carvalho Chehab , Micha List-Id: dri-devel@lists.freedesktop.org On Tue 19-11-19 00:16:21, John Hubbard wrote: > There are four locations in gup.c that have a fair amount of code > duplication. This means that changing one requires making the same > changes in four places, not to mention reading the same code four > times, and wondering if there are subtle differences. > > Factor out the common code into static functions, thus reducing the > overall line count and the code's complexity. > > Also, take the opportunity to slightly improve the efficiency of the > error cases, by doing a mass subtraction of the refcount, surrounded > by get_page()/put_page(). > > Also, further simplify (slightly), by waiting until the the successful > end of each routine, to increment *nr. > > Reviewed-by: Jérôme Glisse > Cc: Jan Kara > Cc: Ira Weiny > Cc: Christoph Hellwig > Cc: Aneesh Kumar K.V > Signed-off-by: John Hubbard Looks good to me now! You can add: Reviewed-by: Jan Kara Honza > --- > mm/gup.c | 91 ++++++++++++++++++++++---------------------------------- > 1 file changed, 36 insertions(+), 55 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index 85caf76b3012..f3c7d6625817 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -1969,6 +1969,25 @@ static int __gup_device_huge_pud(pud_t pud, pud_t *pudp, unsigned long addr, > } > #endif > > +static int __record_subpages(struct page *page, unsigned long addr, > + unsigned long end, struct page **pages) > +{ > + int nr; > + > + for (nr = 0; addr != end; addr += PAGE_SIZE) > + pages[nr++] = page++; > + > + return nr; > +} > + > +static void put_compound_head(struct page *page, int refs) > +{ > + /* Do a get_page() first, in case refs == page->_refcount */ > + get_page(page); > + page_ref_sub(page, refs); > + put_page(page); > +} > + > #ifdef CONFIG_ARCH_HAS_HUGEPD > static unsigned long hugepte_addr_end(unsigned long addr, unsigned long end, > unsigned long sz) > @@ -1998,32 +2017,20 @@ static int gup_hugepte(pte_t *ptep, unsigned long sz, unsigned long addr, > /* hugepages are never "special" */ > VM_BUG_ON(!pfn_valid(pte_pfn(pte))); > > - refs = 0; > head = pte_page(pte); > - > page = head + ((addr & (sz-1)) >> PAGE_SHIFT); > - do { > - VM_BUG_ON(compound_head(page) != head); > - pages[*nr] = page; > - (*nr)++; > - page++; > - refs++; > - } while (addr += PAGE_SIZE, addr != end); > + refs = __record_subpages(page, addr, end, pages + *nr); > > head = try_get_compound_head(head, refs); > - if (!head) { > - *nr -= refs; > + if (!head) > return 0; > - } > > if (unlikely(pte_val(pte) != pte_val(*ptep))) { > - /* Could be optimized better */ > - *nr -= refs; > - while (refs--) > - put_page(head); > + put_compound_head(head, refs); > return 0; > } > > + *nr += refs; > SetPageReferenced(head); > return 1; > } > @@ -2071,28 +2078,19 @@ static int gup_huge_pmd(pmd_t orig, pmd_t *pmdp, unsigned long addr, > pages, nr); > } > > - refs = 0; > page = pmd_page(orig) + ((addr & ~PMD_MASK) >> PAGE_SHIFT); > - do { > - pages[*nr] = page; > - (*nr)++; > - page++; > - refs++; > - } while (addr += PAGE_SIZE, addr != end); > + refs = __record_subpages(page, addr, end, pages + *nr); > > head = try_get_compound_head(pmd_page(orig), refs); > - if (!head) { > - *nr -= refs; > + if (!head) > return 0; > - } > > if (unlikely(pmd_val(orig) != pmd_val(*pmdp))) { > - *nr -= refs; > - while (refs--) > - put_page(head); > + put_compound_head(head, refs); > return 0; > } > > + *nr += refs; > SetPageReferenced(head); > return 1; > } > @@ -2114,28 +2112,19 @@ static int gup_huge_pud(pud_t orig, pud_t *pudp, unsigned long addr, > pages, nr); > } > > - refs = 0; > page = pud_page(orig) + ((addr & ~PUD_MASK) >> PAGE_SHIFT); > - do { > - pages[*nr] = page; > - (*nr)++; > - page++; > - refs++; > - } while (addr += PAGE_SIZE, addr != end); > + refs = __record_subpages(page, addr, end, pages + *nr); > > head = try_get_compound_head(pud_page(orig), refs); > - if (!head) { > - *nr -= refs; > + if (!head) > return 0; > - } > > if (unlikely(pud_val(orig) != pud_val(*pudp))) { > - *nr -= refs; > - while (refs--) > - put_page(head); > + put_compound_head(head, refs); > return 0; > } > > + *nr += refs; > SetPageReferenced(head); > return 1; > } > @@ -2151,28 +2140,20 @@ static int gup_huge_pgd(pgd_t orig, pgd_t *pgdp, unsigned long addr, > return 0; > > BUILD_BUG_ON(pgd_devmap(orig)); > - refs = 0; > + > page = pgd_page(orig) + ((addr & ~PGDIR_MASK) >> PAGE_SHIFT); > - do { > - pages[*nr] = page; > - (*nr)++; > - page++; > - refs++; > - } while (addr += PAGE_SIZE, addr != end); > + refs = __record_subpages(page, addr, end, pages + *nr); > > head = try_get_compound_head(pgd_page(orig), refs); > - if (!head) { > - *nr -= refs; > + if (!head) > return 0; > - } > > if (unlikely(pgd_val(orig) != pgd_val(*pgdp))) { > - *nr -= refs; > - while (refs--) > - put_page(head); > + put_compound_head(head, refs); > return 0; > } > > + *nr += refs; > SetPageReferenced(head); > return 1; > } > -- > 2.24.0 > -- Jan Kara SUSE Labs, CR From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5501EC432C3 for ; Tue, 19 Nov 2019 10:19:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 366AE2230F for ; Tue, 19 Nov 2019 10:19:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 366AE2230F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 98DF66E122; Tue, 19 Nov 2019 10:19:17 +0000 (UTC) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 377A76E122 for ; Tue, 19 Nov 2019 10:19:15 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 737CFAE87; Tue, 19 Nov 2019 10:19:13 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id D586A1E47E5; Tue, 19 Nov 2019 11:19:10 +0100 (CET) Date: Tue, 19 Nov 2019 11:19:10 +0100 From: Jan Kara To: John Hubbard Subject: Re: [PATCH v6 02/24] mm/gup: factor out duplicate code from four routines Message-ID: <20191119101910.GC25605@quack2.suse.cz> References: <20191119081643.1866232-1-jhubbard@nvidia.com> <20191119081643.1866232-3-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191119081643.1866232-3-jhubbard@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , Jan Kara , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Christoph Hellwig , Jonathan Corbet , linux-rdma@vger.kernel.org, Michael Ellerman , Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , linux-media@vger.kernel.org, Shuah Khan , linux-block@vger.kernel.org, =?iso-8859-1?B?Suly9G1l?= Glisse , Al Viro , Dan Williams , Mauro Carvalho Chehab , bpf@vger.kernel.org, Magnus Karlsson , Jens Axboe , netdev@vger.kernel.org, Alex Williamson , "Aneesh Kumar K . V" , linux-fsdevel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" , Mike Kravetz Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191119101910.VA4x2S0FilOxz7v_wzeBHaYPhEAuZfeArR4JEkUoXhY@z> T24gVHVlIDE5LTExLTE5IDAwOjE2OjIxLCBKb2huIEh1YmJhcmQgd3JvdGU6Cj4gVGhlcmUgYXJl IGZvdXIgbG9jYXRpb25zIGluIGd1cC5jIHRoYXQgaGF2ZSBhIGZhaXIgYW1vdW50IG9mIGNvZGUK PiBkdXBsaWNhdGlvbi4gVGhpcyBtZWFucyB0aGF0IGNoYW5naW5nIG9uZSByZXF1aXJlcyBtYWtp bmcgdGhlIHNhbWUKPiBjaGFuZ2VzIGluIGZvdXIgcGxhY2VzLCBub3QgdG8gbWVudGlvbiByZWFk aW5nIHRoZSBzYW1lIGNvZGUgZm91cgo+IHRpbWVzLCBhbmQgd29uZGVyaW5nIGlmIHRoZXJlIGFy ZSBzdWJ0bGUgZGlmZmVyZW5jZXMuCj4gCj4gRmFjdG9yIG91dCB0aGUgY29tbW9uIGNvZGUgaW50 byBzdGF0aWMgZnVuY3Rpb25zLCB0aHVzIHJlZHVjaW5nIHRoZQo+IG92ZXJhbGwgbGluZSBjb3Vu dCBhbmQgdGhlIGNvZGUncyBjb21wbGV4aXR5Lgo+IAo+IEFsc28sIHRha2UgdGhlIG9wcG9ydHVu aXR5IHRvIHNsaWdodGx5IGltcHJvdmUgdGhlIGVmZmljaWVuY3kgb2YgdGhlCj4gZXJyb3IgY2Fz ZXMsIGJ5IGRvaW5nIGEgbWFzcyBzdWJ0cmFjdGlvbiBvZiB0aGUgcmVmY291bnQsIHN1cnJvdW5k ZWQKPiBieSBnZXRfcGFnZSgpL3B1dF9wYWdlKCkuCj4gCj4gQWxzbywgZnVydGhlciBzaW1wbGlm eSAoc2xpZ2h0bHkpLCBieSB3YWl0aW5nIHVudGlsIHRoZSB0aGUgc3VjY2Vzc2Z1bAo+IGVuZCBv ZiBlYWNoIHJvdXRpbmUsIHRvIGluY3JlbWVudCAqbnIuCj4gCj4gUmV2aWV3ZWQtYnk6IErDqXLD tG1lIEdsaXNzZSA8amdsaXNzZUByZWRoYXQuY29tPgo+IENjOiBKYW4gS2FyYSA8amFja0BzdXNl LmN6Pgo+IENjOiBJcmEgV2VpbnkgPGlyYS53ZWlueUBpbnRlbC5jb20+Cj4gQ2M6IENocmlzdG9w aCBIZWxsd2lnIDxoY2hAbHN0LmRlPgo+IENjOiBBbmVlc2ggS3VtYXIgSy5WIDxhbmVlc2gua3Vt YXJAbGludXguaWJtLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBKb2huIEh1YmJhcmQgPGpodWJiYXJk QG52aWRpYS5jb20+CgpMb29rcyBnb29kIHRvIG1lIG5vdyEgWW91IGNhbiBhZGQ6CgpSZXZpZXdl ZC1ieTogSmFuIEthcmEgPGphY2tAc3VzZS5jej4KCgkJCQkJCQkJSG9uemEKCj4gLS0tCj4gIG1t L2d1cC5jIHwgOTEgKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDM2IGluc2VydGlvbnMoKyksIDU1IGRlbGV0 aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9tbS9ndXAuYyBiL21tL2d1cC5jCj4gaW5kZXggODVj YWY3NmIzMDEyLi5mM2M3ZDY2MjU4MTcgMTAwNjQ0Cj4gLS0tIGEvbW0vZ3VwLmMKPiArKysgYi9t bS9ndXAuYwo+IEBAIC0xOTY5LDYgKzE5NjksMjUgQEAgc3RhdGljIGludCBfX2d1cF9kZXZpY2Vf aHVnZV9wdWQocHVkX3QgcHVkLCBwdWRfdCAqcHVkcCwgdW5zaWduZWQgbG9uZyBhZGRyLAo+ICB9 Cj4gICNlbmRpZgo+ICAKPiArc3RhdGljIGludCBfX3JlY29yZF9zdWJwYWdlcyhzdHJ1Y3QgcGFn ZSAqcGFnZSwgdW5zaWduZWQgbG9uZyBhZGRyLAo+ICsJCQkgICAgIHVuc2lnbmVkIGxvbmcgZW5k LCBzdHJ1Y3QgcGFnZSAqKnBhZ2VzKQo+ICt7Cj4gKwlpbnQgbnI7Cj4gKwo+ICsJZm9yIChuciA9 IDA7IGFkZHIgIT0gZW5kOyBhZGRyICs9IFBBR0VfU0laRSkKPiArCQlwYWdlc1tucisrXSA9IHBh Z2UrKzsKPiArCj4gKwlyZXR1cm4gbnI7Cj4gK30KPiArCj4gK3N0YXRpYyB2b2lkIHB1dF9jb21w b3VuZF9oZWFkKHN0cnVjdCBwYWdlICpwYWdlLCBpbnQgcmVmcykKPiArewo+ICsJLyogRG8gYSBn ZXRfcGFnZSgpIGZpcnN0LCBpbiBjYXNlIHJlZnMgPT0gcGFnZS0+X3JlZmNvdW50ICovCj4gKwln ZXRfcGFnZShwYWdlKTsKPiArCXBhZ2VfcmVmX3N1YihwYWdlLCByZWZzKTsKPiArCXB1dF9wYWdl KHBhZ2UpOwo+ICt9Cj4gKwo+ICAjaWZkZWYgQ09ORklHX0FSQ0hfSEFTX0hVR0VQRAo+ICBzdGF0 aWMgdW5zaWduZWQgbG9uZyBodWdlcHRlX2FkZHJfZW5kKHVuc2lnbmVkIGxvbmcgYWRkciwgdW5z aWduZWQgbG9uZyBlbmQsCj4gIAkJCQkgICAgICB1bnNpZ25lZCBsb25nIHN6KQo+IEBAIC0xOTk4 LDMyICsyMDE3LDIwIEBAIHN0YXRpYyBpbnQgZ3VwX2h1Z2VwdGUocHRlX3QgKnB0ZXAsIHVuc2ln bmVkIGxvbmcgc3osIHVuc2lnbmVkIGxvbmcgYWRkciwKPiAgCS8qIGh1Z2VwYWdlcyBhcmUgbmV2 ZXIgInNwZWNpYWwiICovCj4gIAlWTV9CVUdfT04oIXBmbl92YWxpZChwdGVfcGZuKHB0ZSkpKTsK PiAgCj4gLQlyZWZzID0gMDsKPiAgCWhlYWQgPSBwdGVfcGFnZShwdGUpOwo+IC0KPiAgCXBhZ2Ug PSBoZWFkICsgKChhZGRyICYgKHN6LTEpKSA+PiBQQUdFX1NISUZUKTsKPiAtCWRvIHsKPiAtCQlW TV9CVUdfT04oY29tcG91bmRfaGVhZChwYWdlKSAhPSBoZWFkKTsKPiAtCQlwYWdlc1sqbnJdID0g cGFnZTsKPiAtCQkoKm5yKSsrOwo+IC0JCXBhZ2UrKzsKPiAtCQlyZWZzKys7Cj4gLQl9IHdoaWxl IChhZGRyICs9IFBBR0VfU0laRSwgYWRkciAhPSBlbmQpOwo+ICsJcmVmcyA9IF9fcmVjb3JkX3N1 YnBhZ2VzKHBhZ2UsIGFkZHIsIGVuZCwgcGFnZXMgKyAqbnIpOwo+ICAKPiAgCWhlYWQgPSB0cnlf Z2V0X2NvbXBvdW5kX2hlYWQoaGVhZCwgcmVmcyk7Cj4gLQlpZiAoIWhlYWQpIHsKPiAtCQkqbnIg LT0gcmVmczsKPiArCWlmICghaGVhZCkKPiAgCQlyZXR1cm4gMDsKPiAtCX0KPiAgCj4gIAlpZiAo dW5saWtlbHkocHRlX3ZhbChwdGUpICE9IHB0ZV92YWwoKnB0ZXApKSkgewo+IC0JCS8qIENvdWxk IGJlIG9wdGltaXplZCBiZXR0ZXIgKi8KPiAtCQkqbnIgLT0gcmVmczsKPiAtCQl3aGlsZSAocmVm cy0tKQo+IC0JCQlwdXRfcGFnZShoZWFkKTsKPiArCQlwdXRfY29tcG91bmRfaGVhZChoZWFkLCBy ZWZzKTsKPiAgCQlyZXR1cm4gMDsKPiAgCX0KPiAgCj4gKwkqbnIgKz0gcmVmczsKPiAgCVNldFBh Z2VSZWZlcmVuY2VkKGhlYWQpOwo+ICAJcmV0dXJuIDE7Cj4gIH0KPiBAQCAtMjA3MSwyOCArMjA3 OCwxOSBAQCBzdGF0aWMgaW50IGd1cF9odWdlX3BtZChwbWRfdCBvcmlnLCBwbWRfdCAqcG1kcCwg dW5zaWduZWQgbG9uZyBhZGRyLAo+ICAJCQkJCSAgICAgcGFnZXMsIG5yKTsKPiAgCX0KPiAgCj4g LQlyZWZzID0gMDsKPiAgCXBhZ2UgPSBwbWRfcGFnZShvcmlnKSArICgoYWRkciAmIH5QTURfTUFT SykgPj4gUEFHRV9TSElGVCk7Cj4gLQlkbyB7Cj4gLQkJcGFnZXNbKm5yXSA9IHBhZ2U7Cj4gLQkJ KCpucikrKzsKPiAtCQlwYWdlKys7Cj4gLQkJcmVmcysrOwo+IC0JfSB3aGlsZSAoYWRkciArPSBQ QUdFX1NJWkUsIGFkZHIgIT0gZW5kKTsKPiArCXJlZnMgPSBfX3JlY29yZF9zdWJwYWdlcyhwYWdl LCBhZGRyLCBlbmQsIHBhZ2VzICsgKm5yKTsKPiAgCj4gIAloZWFkID0gdHJ5X2dldF9jb21wb3Vu ZF9oZWFkKHBtZF9wYWdlKG9yaWcpLCByZWZzKTsKPiAtCWlmICghaGVhZCkgewo+IC0JCSpuciAt PSByZWZzOwo+ICsJaWYgKCFoZWFkKQo+ICAJCXJldHVybiAwOwo+IC0JfQo+ICAKPiAgCWlmICh1 bmxpa2VseShwbWRfdmFsKG9yaWcpICE9IHBtZF92YWwoKnBtZHApKSkgewo+IC0JCSpuciAtPSBy ZWZzOwo+IC0JCXdoaWxlIChyZWZzLS0pCj4gLQkJCXB1dF9wYWdlKGhlYWQpOwo+ICsJCXB1dF9j b21wb3VuZF9oZWFkKGhlYWQsIHJlZnMpOwo+ICAJCXJldHVybiAwOwo+ICAJfQo+ICAKPiArCSpu ciArPSByZWZzOwo+ICAJU2V0UGFnZVJlZmVyZW5jZWQoaGVhZCk7Cj4gIAlyZXR1cm4gMTsKPiAg fQo+IEBAIC0yMTE0LDI4ICsyMTEyLDE5IEBAIHN0YXRpYyBpbnQgZ3VwX2h1Z2VfcHVkKHB1ZF90 IG9yaWcsIHB1ZF90ICpwdWRwLCB1bnNpZ25lZCBsb25nIGFkZHIsCj4gIAkJCQkJICAgICBwYWdl cywgbnIpOwo+ICAJfQo+ICAKPiAtCXJlZnMgPSAwOwo+ICAJcGFnZSA9IHB1ZF9wYWdlKG9yaWcp ICsgKChhZGRyICYgflBVRF9NQVNLKSA+PiBQQUdFX1NISUZUKTsKPiAtCWRvIHsKPiAtCQlwYWdl c1sqbnJdID0gcGFnZTsKPiAtCQkoKm5yKSsrOwo+IC0JCXBhZ2UrKzsKPiAtCQlyZWZzKys7Cj4g LQl9IHdoaWxlIChhZGRyICs9IFBBR0VfU0laRSwgYWRkciAhPSBlbmQpOwo+ICsJcmVmcyA9IF9f cmVjb3JkX3N1YnBhZ2VzKHBhZ2UsIGFkZHIsIGVuZCwgcGFnZXMgKyAqbnIpOwo+ICAKPiAgCWhl YWQgPSB0cnlfZ2V0X2NvbXBvdW5kX2hlYWQocHVkX3BhZ2Uob3JpZyksIHJlZnMpOwo+IC0JaWYg KCFoZWFkKSB7Cj4gLQkJKm5yIC09IHJlZnM7Cj4gKwlpZiAoIWhlYWQpCj4gIAkJcmV0dXJuIDA7 Cj4gLQl9Cj4gIAo+ICAJaWYgKHVubGlrZWx5KHB1ZF92YWwob3JpZykgIT0gcHVkX3ZhbCgqcHVk cCkpKSB7Cj4gLQkJKm5yIC09IHJlZnM7Cj4gLQkJd2hpbGUgKHJlZnMtLSkKPiAtCQkJcHV0X3Bh Z2UoaGVhZCk7Cj4gKwkJcHV0X2NvbXBvdW5kX2hlYWQoaGVhZCwgcmVmcyk7Cj4gIAkJcmV0dXJu IDA7Cj4gIAl9Cj4gIAo+ICsJKm5yICs9IHJlZnM7Cj4gIAlTZXRQYWdlUmVmZXJlbmNlZChoZWFk KTsKPiAgCXJldHVybiAxOwo+ICB9Cj4gQEAgLTIxNTEsMjggKzIxNDAsMjAgQEAgc3RhdGljIGlu dCBndXBfaHVnZV9wZ2QocGdkX3Qgb3JpZywgcGdkX3QgKnBnZHAsIHVuc2lnbmVkIGxvbmcgYWRk ciwKPiAgCQlyZXR1cm4gMDsKPiAgCj4gIAlCVUlMRF9CVUdfT04ocGdkX2Rldm1hcChvcmlnKSk7 Cj4gLQlyZWZzID0gMDsKPiArCj4gIAlwYWdlID0gcGdkX3BhZ2Uob3JpZykgKyAoKGFkZHIgJiB+ UEdESVJfTUFTSykgPj4gUEFHRV9TSElGVCk7Cj4gLQlkbyB7Cj4gLQkJcGFnZXNbKm5yXSA9IHBh Z2U7Cj4gLQkJKCpucikrKzsKPiAtCQlwYWdlKys7Cj4gLQkJcmVmcysrOwo+IC0JfSB3aGlsZSAo YWRkciArPSBQQUdFX1NJWkUsIGFkZHIgIT0gZW5kKTsKPiArCXJlZnMgPSBfX3JlY29yZF9zdWJw YWdlcyhwYWdlLCBhZGRyLCBlbmQsIHBhZ2VzICsgKm5yKTsKPiAgCj4gIAloZWFkID0gdHJ5X2dl dF9jb21wb3VuZF9oZWFkKHBnZF9wYWdlKG9yaWcpLCByZWZzKTsKPiAtCWlmICghaGVhZCkgewo+ IC0JCSpuciAtPSByZWZzOwo+ICsJaWYgKCFoZWFkKQo+ICAJCXJldHVybiAwOwo+IC0JfQo+ICAK PiAgCWlmICh1bmxpa2VseShwZ2RfdmFsKG9yaWcpICE9IHBnZF92YWwoKnBnZHApKSkgewo+IC0J CSpuciAtPSByZWZzOwo+IC0JCXdoaWxlIChyZWZzLS0pCj4gLQkJCXB1dF9wYWdlKGhlYWQpOwo+ ICsJCXB1dF9jb21wb3VuZF9oZWFkKGhlYWQsIHJlZnMpOwo+ICAJCXJldHVybiAwOwo+ICAJfQo+ ICAKPiArCSpuciArPSByZWZzOwo+ICAJU2V0UGFnZVJlZmVyZW5jZWQoaGVhZCk7Cj4gIAlyZXR1 cm4gMTsKPiAgfQo+IC0tIAo+IDIuMjQuMAo+IAotLSAKSmFuIEthcmEgPGphY2tAc3VzZS5jb20+ ClNVU0UgTGFicywgQ1IKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVs