From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v1 3/5] fbtft: Drop useless #ifdef CONFIG_OF and dead code Date: Wed, 20 Nov 2019 17:28:50 +0200 Message-ID: <20191120152850.GQ32742@smile.fi.intel.com> References: <20191120095716.26628-1-andriy.shevchenko@linux.intel.com> <20191120095716.26628-3-andriy.shevchenko@linux.intel.com> <37435de0-873d-d20c-ac66-420ba91356fd@tronnes.org> <676c3f0e-81b7-d9be-8b37-a38eb3d762fb@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <676c3f0e-81b7-d9be-8b37-a38eb3d762fb@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, Nishad Kamdar , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Wed, Nov 20, 2019 at 04:04:17PM +0100, Noralf Tr=F8nnes wrote: > Den 20.11.2019 15.43, skrev Noralf Tr=F8nnes: > > Den 20.11.2019 10.57, skrev Andy Shevchenko: > >> First of all there is no need to guard GPIO request by CONFIG_OF. > >> It works for everybody independently on resource provider. While here, > >> rename the function to reflect the above. > >> > >> Moreover, since we have a global dependency to OF, the rest of > >> conditional compilation is no-op, i.e. it's always be true. > >> > >> Due to above drop useless #ifdef CONFIG_OF and therefore dead code. > >> > >> Signed-off-by: Andy Shevchenko > >> --- > >> drivers/staging/fbtft/fbtft-core.c | 19 ++----------------- > >> 1 file changed, 2 insertions(+), 17 deletions(-) > >> > >> diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtf= t/fbtft-core.c > > = > > > > = > >> @@ -1184,17 +1176,10 @@ static struct fbtft_platform_data *fbtft_probe= _dt(struct device *dev) > >> pdata->display.backlight =3D 1; > >> if (of_find_property(node, "init", NULL)) > >> pdata->display.fbtftops.init_display =3D fbtft_init_display_dt; > >> - pdata->display.fbtftops.request_gpios =3D fbtft_request_gpios_dt; > >> + pdata->display.fbtftops.request_gpios =3D fbtft_request_gpios; > > = > > You can ditch the .request_gpios callback and call fbtft_request_gpios() > > directly in fbtft_register_framebuffer(). That will make it safe to drop > > the OF dependency, otherwise .request_gpios will be NULL in the non-DT > > case. This is one of the bugs that follwed the gpio refactoring. > = > Really difficult to read this fbtft code (that I wrote...). > The NULL deref can only happen when dev->platform_data is set. That > can't happen, in mainline at least, now that fbtft_device is gone. Hmm... If I read code correctly this patch doesn't change this logic. We ha= ve non-NULL ->request_gpios() in case of pdata !=3D NULL if and only if suppli= er gives it to us. The above assignment happens only for DT case (fbtft_properties_read() is guarded against non-DT, okay non-fwnode, cases). > > You can also ditch the .request_gpios_match callback if you want, it > > isn't called anymore (it is set in fb_agm1264k-fl). I guess both improvements can be done later since they are not affecting the logic in this series. -- = With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23526C432C0 for ; Thu, 21 Nov 2019 07:59:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0356520872 for ; Thu, 21 Nov 2019 07:59:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0356520872 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 500FB6EB5C; Thu, 21 Nov 2019 07:59:21 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id B5BB66E03B for ; Wed, 20 Nov 2019 15:28:53 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2019 07:28:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,222,1571727600"; d="scan'208";a="209568358" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga003.jf.intel.com with ESMTP; 20 Nov 2019 07:28:51 -0800 Received: from andy by smile with local (Exim 4.93-RC1) (envelope-from ) id 1iXRuU-0006qT-KF; Wed, 20 Nov 2019 17:28:50 +0200 Date: Wed, 20 Nov 2019 17:28:50 +0200 From: Andy Shevchenko To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Subject: Re: [PATCH v1 3/5] fbtft: Drop useless #ifdef CONFIG_OF and dead code Message-ID: <20191120152850.GQ32742@smile.fi.intel.com> References: <20191120095716.26628-1-andriy.shevchenko@linux.intel.com> <20191120095716.26628-3-andriy.shevchenko@linux.intel.com> <37435de0-873d-d20c-ac66-420ba91356fd@tronnes.org> <676c3f0e-81b7-d9be-8b37-a38eb3d762fb@tronnes.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <676c3f0e-81b7-d9be-8b37-a38eb3d762fb@tronnes.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Approved-At: Thu, 21 Nov 2019 07:59:20 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, Nishad Kamdar , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191120152850.weCWRxzXG8PyYdJospH_JxZIUnZ8YuVg6cGY8yaKmcU@z> T24gV2VkLCBOb3YgMjAsIDIwMTkgYXQgMDQ6MDQ6MTdQTSArMDEwMCwgTm9yYWxmIFRyw7hubmVz IHdyb3RlOgo+IERlbiAyMC4xMS4yMDE5IDE1LjQzLCBza3JldiBOb3JhbGYgVHLDuG5uZXM6Cj4g PiBEZW4gMjAuMTEuMjAxOSAxMC41Nywgc2tyZXYgQW5keSBTaGV2Y2hlbmtvOgoKPiA+PiBGaXJz dCBvZiBhbGwgdGhlcmUgaXMgbm8gbmVlZCB0byBndWFyZCBHUElPIHJlcXVlc3QgYnkgQ09ORklH X09GLgo+ID4+IEl0IHdvcmtzIGZvciBldmVyeWJvZHkgaW5kZXBlbmRlbnRseSBvbiByZXNvdXJj ZSBwcm92aWRlci4gV2hpbGUgaGVyZSwKPiA+PiByZW5hbWUgdGhlIGZ1bmN0aW9uIHRvIHJlZmxl Y3QgdGhlIGFib3ZlLgo+ID4+Cj4gPj4gTW9yZW92ZXIsIHNpbmNlIHdlIGhhdmUgYSBnbG9iYWwg ZGVwZW5kZW5jeSB0byBPRiwgdGhlIHJlc3Qgb2YKPiA+PiBjb25kaXRpb25hbCBjb21waWxhdGlv biBpcyBuby1vcCwgaS5lLiBpdCdzIGFsd2F5cyBiZSB0cnVlLgo+ID4+Cj4gPj4gRHVlIHRvIGFi b3ZlIGRyb3AgdXNlbGVzcyAjaWZkZWYgQ09ORklHX09GIGFuZCB0aGVyZWZvcmUgZGVhZCBjb2Rl Lgo+ID4+Cj4gPj4gU2lnbmVkLW9mZi1ieTogQW5keSBTaGV2Y2hlbmtvIDxhbmRyaXkuc2hldmNo ZW5rb0BsaW51eC5pbnRlbC5jb20+Cj4gPj4gLS0tCj4gPj4gIGRyaXZlcnMvc3RhZ2luZy9mYnRm dC9mYnRmdC1jb3JlLmMgfCAxOSArKy0tLS0tLS0tLS0tLS0tLS0tCj4gPj4gIDEgZmlsZSBjaGFu Z2VkLCAyIGluc2VydGlvbnMoKyksIDE3IGRlbGV0aW9ucygtKQo+ID4+Cj4gPj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvc3RhZ2luZy9mYnRmdC9mYnRmdC1jb3JlLmMgYi9kcml2ZXJzL3N0YWdpbmcv ZmJ0ZnQvZmJ0ZnQtY29yZS5jCj4gPiAKPiA+IDxzbmlwPgo+ID4gCj4gPj4gQEAgLTExODQsMTcg KzExNzYsMTAgQEAgc3RhdGljIHN0cnVjdCBmYnRmdF9wbGF0Zm9ybV9kYXRhICpmYnRmdF9wcm9i ZV9kdChzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gPj4gIAkJcGRhdGEtPmRpc3BsYXkuYmFja2xpZ2h0 ID0gMTsKPiA+PiAgCWlmIChvZl9maW5kX3Byb3BlcnR5KG5vZGUsICJpbml0IiwgTlVMTCkpCj4g Pj4gIAkJcGRhdGEtPmRpc3BsYXkuZmJ0ZnRvcHMuaW5pdF9kaXNwbGF5ID0gZmJ0ZnRfaW5pdF9k aXNwbGF5X2R0Owo+ID4+IC0JcGRhdGEtPmRpc3BsYXkuZmJ0ZnRvcHMucmVxdWVzdF9ncGlvcyA9 IGZidGZ0X3JlcXVlc3RfZ3Bpb3NfZHQ7Cj4gPj4gKwlwZGF0YS0+ZGlzcGxheS5mYnRmdG9wcy5y ZXF1ZXN0X2dwaW9zID0gZmJ0ZnRfcmVxdWVzdF9ncGlvczsKPiA+IAo+ID4gWW91IGNhbiBkaXRj aCB0aGUgLnJlcXVlc3RfZ3Bpb3MgY2FsbGJhY2sgYW5kIGNhbGwgZmJ0ZnRfcmVxdWVzdF9ncGlv cygpCj4gPiBkaXJlY3RseSBpbiBmYnRmdF9yZWdpc3Rlcl9mcmFtZWJ1ZmZlcigpLiBUaGF0IHdp bGwgbWFrZSBpdCBzYWZlIHRvIGRyb3AKPiA+IHRoZSBPRiBkZXBlbmRlbmN5LCBvdGhlcndpc2Ug LnJlcXVlc3RfZ3Bpb3Mgd2lsbCBiZSBOVUxMIGluIHRoZSBub24tRFQKPiA+IGNhc2UuIFRoaXMg aXMgb25lIG9mIHRoZSBidWdzIHRoYXQgZm9sbHdlZCB0aGUgZ3BpbyByZWZhY3RvcmluZy4KPiAK PiBSZWFsbHkgZGlmZmljdWx0IHRvIHJlYWQgdGhpcyBmYnRmdCBjb2RlICh0aGF0IEkgd3JvdGUu Li4pLgo+IFRoZSBOVUxMIGRlcmVmIGNhbiBvbmx5IGhhcHBlbiB3aGVuIGRldi0+cGxhdGZvcm1f ZGF0YSBpcyBzZXQuIFRoYXQKPiBjYW4ndCBoYXBwZW4sIGluIG1haW5saW5lIGF0IGxlYXN0LCBu b3cgdGhhdCBmYnRmdF9kZXZpY2UgaXMgZ29uZS4KCkhtbS4uLiBJZiBJIHJlYWQgY29kZSBjb3Jy ZWN0bHkgdGhpcyBwYXRjaCBkb2Vzbid0IGNoYW5nZSB0aGlzIGxvZ2ljLiBXZSBoYXZlCm5vbi1O VUxMIC0+cmVxdWVzdF9ncGlvcygpIGluIGNhc2Ugb2YgcGRhdGEgIT0gTlVMTCBpZiBhbmQgb25s eSBpZiBzdXBwbGllcgpnaXZlcyBpdCB0byB1cy4KClRoZSBhYm92ZSBhc3NpZ25tZW50IGhhcHBl bnMgb25seSBmb3IgRFQgY2FzZSAoZmJ0ZnRfcHJvcGVydGllc19yZWFkKCkgaXMKZ3VhcmRlZCBh Z2FpbnN0IG5vbi1EVCwgb2theSBub24tZndub2RlLCBjYXNlcykuCgo+ID4gWW91IGNhbiBhbHNv IGRpdGNoIHRoZSAucmVxdWVzdF9ncGlvc19tYXRjaCBjYWxsYmFjayBpZiB5b3Ugd2FudCwgaXQK PiA+IGlzbid0IGNhbGxlZCBhbnltb3JlIChpdCBpcyBzZXQgaW4gZmJfYWdtMTI2NGstZmwpLgoK SSBndWVzcyBib3RoIGltcHJvdmVtZW50cyBjYW4gYmUgZG9uZSBsYXRlciBzaW5jZSB0aGV5IGFy ZSBub3QgYWZmZWN0aW5nIHRoZQpsb2dpYyBpbiB0aGlzIHNlcmllcy4KCi0tIApXaXRoIEJlc3Qg UmVnYXJkcywKQW5keSBTaGV2Y2hlbmtvCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVs