From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH v7 02/24] mm/gup: factor out duplicate code from four routines Date: Thu, 21 Nov 2019 10:54:11 +0100 Message-ID: <20191121095411.GC18190@quack2.suse.cz> References: <20191121071354.456618-1-jhubbard@nvidia.com> <20191121071354.456618-3-jhubbard@nvidia.com> <20191121080356.GA24784@lst.de> <852f6c27-8b65-547b-89e0-e8f32a4d17b9@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <852f6c27-8b65-547b-89e0-e8f32a4d17b9@nvidia.com> Sender: linux-kernel-owner@vger.kernel.org To: John Hubbard Cc: Christoph Hellwig , Andrew Morton , Al Viro , Alex Williamson , Benjamin Herrenschmidt , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Christoph Hellwig , Dan Williams , Daniel Vetter , Dave Chinner , David Airlie , "David S . Miller" , Ira Weiny , Jan Kara , Jason Gunthorpe , Jens Axboe , Jonathan Corbet , =?iso-8859-1?B?Suly9G1l?= Glisse , Magnus Karlsson , Mauro List-Id: dri-devel@lists.freedesktop.org On Thu 21-11-19 00:29:59, John Hubbard wrote: > > > > Otherwise this looks fine and might be a worthwhile cleanup to feed > > Andrew for 5.5 independent of the gut of the changes. > > > > Reviewed-by: Christoph Hellwig > > > > Thanks for the reviews! Say, it sounds like your view here is that this > series should be targeted at 5.6 (not 5.5), is that what you have in mind? > And get the preparatory patches (1-9, and maybe even 10-16) into 5.5? One more note :) If you are going to push pin_user_pages() interfaces (which I'm fine with), it would probably make sense to push also the put_user_pages() -> unpin_user_pages() renaming so that that inconsistency in naming does not exist in the released upstream kernel. Honza -- Jan Kara SUSE Labs, CR From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5A86C432C3 for ; Thu, 21 Nov 2019 09:54:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 935762067D for ; Thu, 21 Nov 2019 09:54:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 935762067D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F11996EC8C; Thu, 21 Nov 2019 09:54:16 +0000 (UTC) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 334A06EC8C for ; Thu, 21 Nov 2019 09:54:15 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 1B5FCAC46; Thu, 21 Nov 2019 09:54:13 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 5A11F1E47FC; Thu, 21 Nov 2019 10:54:11 +0100 (CET) Date: Thu, 21 Nov 2019 10:54:11 +0100 From: Jan Kara To: John Hubbard Subject: Re: [PATCH v7 02/24] mm/gup: factor out duplicate code from four routines Message-ID: <20191121095411.GC18190@quack2.suse.cz> References: <20191121071354.456618-1-jhubbard@nvidia.com> <20191121071354.456618-3-jhubbard@nvidia.com> <20191121080356.GA24784@lst.de> <852f6c27-8b65-547b-89e0-e8f32a4d17b9@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <852f6c27-8b65-547b-89e0-e8f32a4d17b9@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , Jan Kara , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Christoph Hellwig , Jonathan Corbet , linux-rdma@vger.kernel.org, Michael Ellerman , Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , linux-media@vger.kernel.org, Shuah Khan , linux-block@vger.kernel.org, =?iso-8859-1?B?Suly9G1l?= Glisse , Al Viro , Dan Williams , Mauro Carvalho Chehab , bpf@vger.kernel.org, Magnus Karlsson , Jens Axboe , netdev@vger.kernel.org, Alex Williamson , "Aneesh Kumar K . V" , linux-fsdevel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" , Mike Kravetz Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191121095411.sqR6oXOuJqX2QJuatSoOl17RrQQFWXSX0-auvLFGzXk@z> T24gVGh1IDIxLTExLTE5IDAwOjI5OjU5LCBKb2huIEh1YmJhcmQgd3JvdGU6Cj4gPiAKPiA+IE90 aGVyd2lzZSB0aGlzIGxvb2tzIGZpbmUgYW5kIG1pZ2h0IGJlIGEgd29ydGh3aGlsZSBjbGVhbnVw IHRvIGZlZWQKPiA+IEFuZHJldyBmb3IgNS41IGluZGVwZW5kZW50IG9mIHRoZSBndXQgb2YgdGhl IGNoYW5nZXMuCj4gPiAKPiA+IFJldmlld2VkLWJ5OiBDaHJpc3RvcGggSGVsbHdpZyA8aGNoQGxz dC5kZT4KPiA+IAo+IAo+IFRoYW5rcyBmb3IgdGhlIHJldmlld3MhIFNheSwgaXQgc291bmRzIGxp a2UgeW91ciB2aWV3IGhlcmUgaXMgdGhhdCB0aGlzCj4gc2VyaWVzIHNob3VsZCBiZSB0YXJnZXRl ZCBhdCA1LjYgKG5vdCA1LjUpLCBpcyB0aGF0IHdoYXQgeW91IGhhdmUgaW4gbWluZD8KPiBBbmQg Z2V0IHRoZSBwcmVwYXJhdG9yeSBwYXRjaGVzICgxLTksIGFuZCBtYXliZSBldmVuIDEwLTE2KSBp bnRvIDUuNT8KCk9uZSBtb3JlIG5vdGUgOikgSWYgeW91IGFyZSBnb2luZyB0byBwdXNoIHBpbl91 c2VyX3BhZ2VzKCkgaW50ZXJmYWNlcwood2hpY2ggSSdtIGZpbmUgd2l0aCksIGl0IHdvdWxkIHBy b2JhYmx5IG1ha2Ugc2Vuc2UgdG8gcHVzaCBhbHNvIHRoZQpwdXRfdXNlcl9wYWdlcygpIC0+IHVu cGluX3VzZXJfcGFnZXMoKSByZW5hbWluZyBzbyB0aGF0IHRoYXQgaW5jb25zaXN0ZW5jeQppbiBu YW1pbmcgZG9lcyBub3QgZXhpc3QgaW4gdGhlIHJlbGVhc2VkIHVwc3RyZWFtIGtlcm5lbC4KCgkJ CQkJCQkJSG9uemEKLS0gCkphbiBLYXJhIDxqYWNrQHN1c2UuY29tPgpTVVNFIExhYnMsIENSCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==