From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH v7 02/24] mm/gup: factor out duplicate code from four routines Date: Fri, 22 Nov 2019 12:15:02 +0100 Message-ID: <20191122111502.GC26721@quack2.suse.cz> References: <20191121071354.456618-1-jhubbard@nvidia.com> <20191121071354.456618-3-jhubbard@nvidia.com> <20191121080356.GA24784@lst.de> <852f6c27-8b65-547b-89e0-e8f32a4d17b9@nvidia.com> <20191121095411.GC18190@quack2.suse.cz> <9d0846af-2c4f-7cda-dfcb-1f642943afea@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5901D6F51F for ; Fri, 22 Nov 2019 11:15:06 +0000 (UTC) Content-Disposition: inline In-Reply-To: <9d0846af-2c4f-7cda-dfcb-1f642943afea@nvidia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Hubbard Cc: Michal Hocko , Jan Kara , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Christoph Hellwig , Jonathan Corbet , linux-rdma@vger.kernel.org, Michael Ellerman , Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , linux-media@vger.kernel.org, Shuah Khan , linux-block@vger.kernel.org, =?iso-8859-1?B?Suly9G1l?= Glisse , Al Viro , Dan Williams List-Id: dri-devel@lists.freedesktop.org T24gVGh1IDIxLTExLTE5IDE4OjU0OjAyLCBKb2huIEh1YmJhcmQgd3JvdGU6Cj4gT24gMTEvMjEv MTkgMTo1NCBBTSwgSmFuIEthcmEgd3JvdGU6Cj4gPiBPbiBUaHUgMjEtMTEtMTkgMDA6Mjk6NTks IEpvaG4gSHViYmFyZCB3cm90ZToKPiA+ID4gPiAKPiA+ID4gPiBPdGhlcndpc2UgdGhpcyBsb29r cyBmaW5lIGFuZCBtaWdodCBiZSBhIHdvcnRod2hpbGUgY2xlYW51cCB0byBmZWVkCj4gPiA+ID4g QW5kcmV3IGZvciA1LjUgaW5kZXBlbmRlbnQgb2YgdGhlIGd1dCBvZiB0aGUgY2hhbmdlcy4KPiA+ ID4gPiAKPiA+ID4gPiBSZXZpZXdlZC1ieTogQ2hyaXN0b3BoIEhlbGx3aWcgPGhjaEBsc3QuZGU+ Cj4gPiA+ID4gCj4gPiA+IAo+ID4gPiBUaGFua3MgZm9yIHRoZSByZXZpZXdzISBTYXksIGl0IHNv dW5kcyBsaWtlIHlvdXIgdmlldyBoZXJlIGlzIHRoYXQgdGhpcwo+ID4gPiBzZXJpZXMgc2hvdWxk IGJlIHRhcmdldGVkIGF0IDUuNiAobm90IDUuNSksIGlzIHRoYXQgd2hhdCB5b3UgaGF2ZSBpbiBt aW5kPwo+ID4gPiBBbmQgZ2V0IHRoZSBwcmVwYXJhdG9yeSBwYXRjaGVzICgxLTksIGFuZCBtYXli ZSBldmVuIDEwLTE2KSBpbnRvIDUuNT8KPiA+IAo+ID4gT25lIG1vcmUgbm90ZSA6KSBJZiB5b3Ug YXJlIGdvaW5nIHRvIHB1c2ggcGluX3VzZXJfcGFnZXMoKSBpbnRlcmZhY2VzCj4gPiAod2hpY2gg SSdtIGZpbmUgd2l0aCksIGl0IHdvdWxkIHByb2JhYmx5IG1ha2Ugc2Vuc2UgdG8gcHVzaCBhbHNv IHRoZQo+ID4gcHV0X3VzZXJfcGFnZXMoKSAtPiB1bnBpbl91c2VyX3BhZ2VzKCkgcmVuYW1pbmcg c28gdGhhdCB0aGF0IGluY29uc2lzdGVuY3kKPiA+IGluIG5hbWluZyBkb2VzIG5vdCBleGlzdCBp biB0aGUgcmVsZWFzZWQgdXBzdHJlYW0ga2VybmVsLgo+ID4gCj4gPiAJCQkJCQkJCUhvbnphCj4g Cj4gWWVzLCB0aGF0J3Mgd2hhdCB0aGlzIHBhdGNoIHNlcmllcyBkb2VzLiBCdXQgSSdtIG5vdCBz dXJlIGlmICJwdXNoIiBoZXJlCj4gbWVhbnMsICJwdXNoIG91dDogZGVmZXIgdG8gNS42IiwgInB1 c2ggKG5vdykgaW50byA1LjUiLCBvciAiYWR2b2NhdGUgZm9yIj8KCkkgbWVhbnQgdG8gaW5jbHVk ZSB0aGUgcGF0Y2ggaW4gdGhlICJmb3IgNS41IiBiYXRjaC4KCj4gSSB3aWxsIG5vdGUgdGhhdCBp dCdzIG5vdCBnb2luZyB0byBiZSBlYXN5IHRvIHJlbmFtZSBpbiBvbmUgc3RlcCwgbm93Cj4gdGhh dCB0aGlzIGlzIGJlaW5nIHNwbGl0IHVwLiBCZWNhdXNlIHZhcmlvdXMgcHV0X3VzZXJfcGFnZXMo KS1iYXNlZCBpdGVtcwo+IGFyZSBnb2luZyBpbnRvIDUuNSB2aWEgZGlmZmVyZW50IG1haW50YWlu ZXIgdHJlZXMgbm93LiBQcm9iYWJseSBJJ2QgbmVlZAo+IHRvIGludHJvZHVjZSB1bnBpbl91c2Vy X3BhZ2UoKSBhbG9uZ3NpZGUgcHV0X3VzZXJfcGFnZSgpLi4udGhvdWdodHM/CgpZZXMsIEkgdW5k ZXJzdGFuZCB0aGF0IG1vdmluZyB0aGF0IHBhdGNoIGZyb20gdGhlIGVuZCBvZiB0aGUgc2VyaWVz IHdvdWxkCmNhdXNlIGZhaXIgYW1vdW50IG9mIGNvbmZsaWN0cy4gSSB3YXMgaG9waW5nIHRoYXQg eW91IGNvdWxkIGdlbmVyYXRlIHRoZQpwYXRjaCB3aXRoIHNlZC9Db2NjaW5lbGxlIGFuZCB0aGVu IHJlYmFzaW5nIHdoYXQgcmVtYWlucyBmb3IgNS42IG9uIHRvcCBvZgp0aGF0IHBhdGNoIHNob3Vs ZCBub3QgYmUgdGhhdCBwYWluZnVsIHNvIG92ZXJhbGwgaXQgc2hvdWxkIG5vdCBiZSB0aGF0IG11 Y2gKd29yay4gQnV0IEkgbWF5IGJlIHdyb25nIHNvIGlmIGl0IHByb3ZlcyB0byBiZSB0b28gdGVk aW91cywgbGV0J3MganVzdApwb3N0cG9uZSB0aGUgcmVuYW1pbmcgdG8gNS42LiBJIGRvbid0IGZp bmQgaGF2aW5nIGJvdGggdW5waW5fdXNlcl9wYWdlKCkKYW5kIHB1dF91c2VyX3BhZ2UoKSBhIGJl dHRlciBhbHRlcm5hdGl2ZSB0byBjdXJyZW50IHN0YXRlLiBUaGFua3MhCgoJCQkJCQkJCUhvbnph Ci0tIApKYW4gS2FyYSA8amFja0BzdXNlLmNvbT4KU1VTRSBMYWJzLCBDUgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 157CEC43141 for ; Fri, 22 Nov 2019 11:15:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E988220730 for ; Fri, 22 Nov 2019 11:15:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E988220730 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4726B6F51F; Fri, 22 Nov 2019 11:15:08 +0000 (UTC) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5901D6F51F for ; Fri, 22 Nov 2019 11:15:06 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 21586B2F6; Fri, 22 Nov 2019 11:15:04 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 4FA541E484C; Fri, 22 Nov 2019 12:15:02 +0100 (CET) Date: Fri, 22 Nov 2019 12:15:02 +0100 From: Jan Kara To: John Hubbard Subject: Re: [PATCH v7 02/24] mm/gup: factor out duplicate code from four routines Message-ID: <20191122111502.GC26721@quack2.suse.cz> References: <20191121071354.456618-1-jhubbard@nvidia.com> <20191121071354.456618-3-jhubbard@nvidia.com> <20191121080356.GA24784@lst.de> <852f6c27-8b65-547b-89e0-e8f32a4d17b9@nvidia.com> <20191121095411.GC18190@quack2.suse.cz> <9d0846af-2c4f-7cda-dfcb-1f642943afea@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9d0846af-2c4f-7cda-dfcb-1f642943afea@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , Jan Kara , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Christoph Hellwig , Jonathan Corbet , linux-rdma@vger.kernel.org, Michael Ellerman , Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , linux-media@vger.kernel.org, Shuah Khan , linux-block@vger.kernel.org, =?iso-8859-1?B?Suly9G1l?= Glisse , Al Viro , Dan Williams , Mauro Carvalho Chehab , bpf@vger.kernel.org, Magnus Karlsson , Jens Axboe , netdev@vger.kernel.org, Alex Williamson , "Aneesh Kumar K . V" , linux-fsdevel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" , Mike Kravetz Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191122111502.RhZ4FYzleTQe06w7Qftefuy-Uw2xQyXROwvMK5YQhTY@z> T24gVGh1IDIxLTExLTE5IDE4OjU0OjAyLCBKb2huIEh1YmJhcmQgd3JvdGU6Cj4gT24gMTEvMjEv MTkgMTo1NCBBTSwgSmFuIEthcmEgd3JvdGU6Cj4gPiBPbiBUaHUgMjEtMTEtMTkgMDA6Mjk6NTks IEpvaG4gSHViYmFyZCB3cm90ZToKPiA+ID4gPiAKPiA+ID4gPiBPdGhlcndpc2UgdGhpcyBsb29r cyBmaW5lIGFuZCBtaWdodCBiZSBhIHdvcnRod2hpbGUgY2xlYW51cCB0byBmZWVkCj4gPiA+ID4g QW5kcmV3IGZvciA1LjUgaW5kZXBlbmRlbnQgb2YgdGhlIGd1dCBvZiB0aGUgY2hhbmdlcy4KPiA+ ID4gPiAKPiA+ID4gPiBSZXZpZXdlZC1ieTogQ2hyaXN0b3BoIEhlbGx3aWcgPGhjaEBsc3QuZGU+ Cj4gPiA+ID4gCj4gPiA+IAo+ID4gPiBUaGFua3MgZm9yIHRoZSByZXZpZXdzISBTYXksIGl0IHNv dW5kcyBsaWtlIHlvdXIgdmlldyBoZXJlIGlzIHRoYXQgdGhpcwo+ID4gPiBzZXJpZXMgc2hvdWxk IGJlIHRhcmdldGVkIGF0IDUuNiAobm90IDUuNSksIGlzIHRoYXQgd2hhdCB5b3UgaGF2ZSBpbiBt aW5kPwo+ID4gPiBBbmQgZ2V0IHRoZSBwcmVwYXJhdG9yeSBwYXRjaGVzICgxLTksIGFuZCBtYXli ZSBldmVuIDEwLTE2KSBpbnRvIDUuNT8KPiA+IAo+ID4gT25lIG1vcmUgbm90ZSA6KSBJZiB5b3Ug YXJlIGdvaW5nIHRvIHB1c2ggcGluX3VzZXJfcGFnZXMoKSBpbnRlcmZhY2VzCj4gPiAod2hpY2gg SSdtIGZpbmUgd2l0aCksIGl0IHdvdWxkIHByb2JhYmx5IG1ha2Ugc2Vuc2UgdG8gcHVzaCBhbHNv IHRoZQo+ID4gcHV0X3VzZXJfcGFnZXMoKSAtPiB1bnBpbl91c2VyX3BhZ2VzKCkgcmVuYW1pbmcg c28gdGhhdCB0aGF0IGluY29uc2lzdGVuY3kKPiA+IGluIG5hbWluZyBkb2VzIG5vdCBleGlzdCBp biB0aGUgcmVsZWFzZWQgdXBzdHJlYW0ga2VybmVsLgo+ID4gCj4gPiAJCQkJCQkJCUhvbnphCj4g Cj4gWWVzLCB0aGF0J3Mgd2hhdCB0aGlzIHBhdGNoIHNlcmllcyBkb2VzLiBCdXQgSSdtIG5vdCBz dXJlIGlmICJwdXNoIiBoZXJlCj4gbWVhbnMsICJwdXNoIG91dDogZGVmZXIgdG8gNS42IiwgInB1 c2ggKG5vdykgaW50byA1LjUiLCBvciAiYWR2b2NhdGUgZm9yIj8KCkkgbWVhbnQgdG8gaW5jbHVk ZSB0aGUgcGF0Y2ggaW4gdGhlICJmb3IgNS41IiBiYXRjaC4KCj4gSSB3aWxsIG5vdGUgdGhhdCBp dCdzIG5vdCBnb2luZyB0byBiZSBlYXN5IHRvIHJlbmFtZSBpbiBvbmUgc3RlcCwgbm93Cj4gdGhh dCB0aGlzIGlzIGJlaW5nIHNwbGl0IHVwLiBCZWNhdXNlIHZhcmlvdXMgcHV0X3VzZXJfcGFnZXMo KS1iYXNlZCBpdGVtcwo+IGFyZSBnb2luZyBpbnRvIDUuNSB2aWEgZGlmZmVyZW50IG1haW50YWlu ZXIgdHJlZXMgbm93LiBQcm9iYWJseSBJJ2QgbmVlZAo+IHRvIGludHJvZHVjZSB1bnBpbl91c2Vy X3BhZ2UoKSBhbG9uZ3NpZGUgcHV0X3VzZXJfcGFnZSgpLi4udGhvdWdodHM/CgpZZXMsIEkgdW5k ZXJzdGFuZCB0aGF0IG1vdmluZyB0aGF0IHBhdGNoIGZyb20gdGhlIGVuZCBvZiB0aGUgc2VyaWVz IHdvdWxkCmNhdXNlIGZhaXIgYW1vdW50IG9mIGNvbmZsaWN0cy4gSSB3YXMgaG9waW5nIHRoYXQg eW91IGNvdWxkIGdlbmVyYXRlIHRoZQpwYXRjaCB3aXRoIHNlZC9Db2NjaW5lbGxlIGFuZCB0aGVu IHJlYmFzaW5nIHdoYXQgcmVtYWlucyBmb3IgNS42IG9uIHRvcCBvZgp0aGF0IHBhdGNoIHNob3Vs ZCBub3QgYmUgdGhhdCBwYWluZnVsIHNvIG92ZXJhbGwgaXQgc2hvdWxkIG5vdCBiZSB0aGF0IG11 Y2gKd29yay4gQnV0IEkgbWF5IGJlIHdyb25nIHNvIGlmIGl0IHByb3ZlcyB0byBiZSB0b28gdGVk aW91cywgbGV0J3MganVzdApwb3N0cG9uZSB0aGUgcmVuYW1pbmcgdG8gNS42LiBJIGRvbid0IGZp bmQgaGF2aW5nIGJvdGggdW5waW5fdXNlcl9wYWdlKCkKYW5kIHB1dF91c2VyX3BhZ2UoKSBhIGJl dHRlciBhbHRlcm5hdGl2ZSB0byBjdXJyZW50IHN0YXRlLiBUaGFua3MhCgoJCQkJCQkJCUhvbnph Ci0tIApKYW4gS2FyYSA8amFja0BzdXNlLmNvbT4KU1VTRSBMYWJzLCBDUgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=