From: Sam Ravnborg <sam@ravnborg.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: yuehaibing@huawei.com, airlied@linux.ie, puck.chen@hisilicon.com,
dri-devel@lists.freedesktop.org, z.liuxinliang@hisilicon.com,
kong.kongxinwei@hisilicon.com, hslester96@gmail.com,
kraxel@redhat.com, zourongrong@gmail.com
Subject: Re: [PATCH 0/4] Replace hibmc code with generic implmentation
Date: Sat, 23 Nov 2019 09:59:12 +0100 [thread overview]
Message-ID: <20191123085912.GC17899@ravnborg.org> (raw)
In-Reply-To: <20191122083044.6627-1-tzimmermann@suse.de>
Hi Thomas.
> The patch set replaces code in hibmc with generic implementation.
>
> Patches 1 to 3 replace fbdev emuation, framebuffer and creation of
> dumb buffers with respective code from DRM helpers. Patch 4 adds an
> additional interface to debugfs that displays the allocated and free
> areas in video memory.
>
> The patches have only been compile-tested. Further testing is
> appreciated.
Changes looks good and diffstat is very nice.
From my quick browsing everything was fine, a small comment on
one of the patches.
You can add my:
Acked-by: Sam Ravnborg <sam@ravnborg.org>
to the whole series.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-11-23 8:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 8:30 [PATCH 0/4] Replace hibmc code with generic implmentation Thomas Zimmermann
2019-11-22 8:30 ` [PATCH 1/4] drm/hisilicon/hibmc: Switch to generic fbdev emulation Thomas Zimmermann
2019-11-25 9:08 ` Daniel Vetter
2019-11-22 8:30 ` [PATCH 2/4] drm/hisilicon/hibmc: Replace struct hibmc_framebuffer with generic code Thomas Zimmermann
2019-11-25 9:09 ` Daniel Vetter
2019-11-22 8:30 ` [PATCH 3/4] drm/hisilicon/hibmc: Implement hibmc_dumb_create() with generic helpers Thomas Zimmermann
2019-11-23 8:56 ` Sam Ravnborg
2019-11-26 7:41 ` Thomas Zimmermann
2019-11-25 9:14 ` Daniel Vetter
2019-11-26 7:40 ` Thomas Zimmermann
2019-11-26 8:38 ` Daniel Vetter
2019-11-22 8:30 ` [PATCH 4/4] drm/hisilicon/hibmc: Export VRAM MM information to debugfs Thomas Zimmermann
2019-11-25 9:15 ` Daniel Vetter
2019-11-23 8:59 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191123085912.GC17899@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=hslester96@gmail.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=kraxel@redhat.com \
--cc=puck.chen@hisilicon.com \
--cc=tzimmermann@suse.de \
--cc=yuehaibing@huawei.com \
--cc=z.liuxinliang@hisilicon.com \
--cc=zourongrong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).