From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/4] drm/hisilicon/hibmc: Replace struct hibmc_framebuffer with generic code Date: Mon, 25 Nov 2019 10:09:51 +0100 Message-ID: <20191125090951.GF29965@phenom.ffwll.local> References: <20191122083044.6627-1-tzimmermann@suse.de> <20191122083044.6627-3-tzimmermann@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 55D086E044 for ; Mon, 25 Nov 2019 09:09:56 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id a15so16928941wrf.9 for ; Mon, 25 Nov 2019 01:09:56 -0800 (PST) Content-Disposition: inline In-Reply-To: <20191122083044.6627-3-tzimmermann@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thomas Zimmermann Cc: yuehaibing@huawei.com, airlied@linux.ie, puck.chen@hisilicon.com, dri-devel@lists.freedesktop.org, z.liuxinliang@hisilicon.com, kong.kongxinwei@hisilicon.com, hslester96@gmail.com, kraxel@redhat.com, zourongrong@gmail.com, sam@ravnborg.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBOb3YgMjIsIDIwMTkgYXQgMDk6MzA6NDJBTSArMDEwMCwgVGhvbWFzIFppbW1lcm1h bm4gd3JvdGU6Cj4gVGhlIGhpYm1jIGRyaXZlcidzIHN0cnVjdCBoaWJtY19mcmFtZWJ1ZmZlciBz dG9yZXMgYSBEUk0gZnJhbWVidWZmZXIKPiB3aXRoIGFuIGFzc29jaWF0ZWQgR0VNIG9iamVjdC4g VGhpcyBmdW5jdGlvbmFsaXR5IGlzIGFsc28gcHJvdmlkZWQgYnkKPiBnZW5lcmljIGNvZGUuIFN3 aXRjaCBoaWJtYyBvdmVyLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFRob21hcyBaaW1tZXJtYW5uIDx0 emltbWVybWFubkBzdXNlLmRlPgoKQXNpZGUgZnJvbSB0aGUgb25lIHNpbGx5IGNvbXBpbGUgZmFp bCBJIG1hbmFnZWQgdG8gZG8gYW5kIG5vdCBzcG90IHRoaXMKbWF0Y2hlcyB3aGF0IEkndmUgZG9u ZS4KClJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgoK PiAtLS0KPiAgLi4uL2dwdS9kcm0vaGlzaWxpY29uL2hpYm1jL2hpYm1jX2RybV9kZS5jICAgIHwg IDQgKy0KPiAgLi4uL2dwdS9kcm0vaGlzaWxpY29uL2hpYm1jL2hpYm1jX2RybV9kcnYuaCAgIHwg MTEgLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9oaXNpbGljb24vaGlibWMvaGlibWNfdHRtLmMgICB8 IDY5ICstLS0tLS0tLS0tLS0tLS0tLS0KPiAgMyBmaWxlcyBjaGFuZ2VkLCAzIGluc2VydGlvbnMo KyksIDgxIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaGlz aWxpY29uL2hpYm1jL2hpYm1jX2RybV9kZS5jIGIvZHJpdmVycy9ncHUvZHJtL2hpc2lsaWNvbi9o aWJtYy9oaWJtY19kcm1fZGUuYwo+IGluZGV4IDY1MjdhOTdmNjhhMy4uN2ZhN2Q0OTMzZjYwIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9oaXNpbGljb24vaGlibWMvaGlibWNfZHJtX2Rl LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaGlzaWxpY29uL2hpYm1jL2hpYm1jX2RybV9kZS5j Cj4gQEAgLTk5LDE0ICs5OSwxMiBAQCBzdGF0aWMgdm9pZCBoaWJtY19wbGFuZV9hdG9taWNfdXBk YXRlKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ICAJczY0IGdwdV9hZGRyID0gMDsKPiAgCXVu c2lnbmVkIGludCBsaW5lX2w7Cj4gIAlzdHJ1Y3QgaGlibWNfZHJtX3ByaXZhdGUgKnByaXYgPSBw bGFuZS0+ZGV2LT5kZXZfcHJpdmF0ZTsKPiAtCXN0cnVjdCBoaWJtY19mcmFtZWJ1ZmZlciAqaGli bWNfZmI7Cj4gIAlzdHJ1Y3QgZHJtX2dlbV92cmFtX29iamVjdCAqZ2JvOwo+ICAKPiAgCWlmICgh c3RhdGUtPmZiKQo+ICAJCXJldHVybjsKPiAgCj4gLQloaWJtY19mYiA9IHRvX2hpYm1jX2ZyYW1l YnVmZmVyKHN0YXRlLT5mYik7Cj4gLQlnYm8gPSBkcm1fZ2VtX3ZyYW1fb2ZfZ2VtKGhpYm1jX2Zi LT5vYmopOwo+ICsJZ2JvID0gZHJtX2dlbV92cmFtX29mX2dlbShzdGF0ZS0+ZmItPm9ialswXSk7 Cj4gIAo+ICAJZ3B1X2FkZHIgPSBkcm1fZ2VtX3ZyYW1fb2Zmc2V0KGdibyk7Cj4gIAlpZiAoV0FS Tl9PTl9PTkNFKGdwdV9hZGRyIDwgMCkpCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9o aXNpbGljb24vaGlibWMvaGlibWNfZHJtX2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2hpc2lsaWNv bi9oaWJtYy9oaWJtY19kcm1fZHJ2LmgKPiBpbmRleCBiMzQ0OTNlYWQzMGIuLjhlYjcyNThiMjM2 YSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaGlzaWxpY29uL2hpYm1jL2hpYm1jX2Ry bV9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9oaXNpbGljb24vaGlibWMvaGlibWNfZHJt X2Rydi5oCj4gQEAgLTIwLDExICsyMCw2IEBACj4gIHN0cnVjdCBkcm1fZGV2aWNlOwo+ICBzdHJ1 Y3QgZHJtX2dlbV9vYmplY3Q7Cj4gIAo+IC1zdHJ1Y3QgaGlibWNfZnJhbWVidWZmZXIgewo+IC0J c3RydWN0IGRybV9mcmFtZWJ1ZmZlciBmYjsKPiAtCXN0cnVjdCBkcm1fZ2VtX29iamVjdCAqb2Jq Owo+IC19Owo+IC0KPiAgc3RydWN0IGhpYm1jX2RybV9wcml2YXRlIHsKPiAgCS8qIGh3ICovCj4g IAl2b2lkIF9faW9tZW0gICAqbW1pbzsKPiBAQCAtMzgsOCArMzMsNiBAQCBzdHJ1Y3QgaGlibWNf ZHJtX3ByaXZhdGUgewo+ICAJYm9vbCBtb2RlX2NvbmZpZ19pbml0aWFsaXplZDsKPiAgfTsKPiAg Cj4gLSNkZWZpbmUgdG9faGlibWNfZnJhbWVidWZmZXIoeCkgY29udGFpbmVyX29mKHgsIHN0cnVj dCBoaWJtY19mcmFtZWJ1ZmZlciwgZmIpCj4gLQo+ICB2b2lkIGhpYm1jX3NldF9wb3dlcl9tb2Rl KHN0cnVjdCBoaWJtY19kcm1fcHJpdmF0ZSAqcHJpdiwKPiAgCQkJICB1bnNpZ25lZCBpbnQgcG93 ZXJfbW9kZSk7Cj4gIHZvaWQgaGlibWNfc2V0X2N1cnJlbnRfZ2F0ZShzdHJ1Y3QgaGlibWNfZHJt X3ByaXZhdGUgKnByaXYsCj4gQEAgLTUwLDEwICs0Myw2IEBAIGludCBoaWJtY192ZGFjX2luaXQo c3RydWN0IGhpYm1jX2RybV9wcml2YXRlICpwcml2KTsKPiAgCj4gIGludCBoaWJtY19nZW1fY3Jl YXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHUzMiBzaXplLCBib29sIGlza2VybmVsLAo+ICAJ CSAgICAgc3RydWN0IGRybV9nZW1fb2JqZWN0ICoqb2JqKTsKPiAtc3RydWN0IGhpYm1jX2ZyYW1l YnVmZmVyICoKPiAtaGlibWNfZnJhbWVidWZmZXJfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 LAo+IC0JCSAgICAgICBjb25zdCBzdHJ1Y3QgZHJtX21vZGVfZmJfY21kMiAqbW9kZV9jbWQsCj4g LQkJICAgICAgIHN0cnVjdCBkcm1fZ2VtX29iamVjdCAqb2JqKTsKPiAgCj4gIGludCBoaWJtY19t bV9pbml0KHN0cnVjdCBoaWJtY19kcm1fcHJpdmF0ZSAqaGlibWMpOwo+ICB2b2lkIGhpYm1jX21t X2Zpbmkoc3RydWN0IGhpYm1jX2RybV9wcml2YXRlICpoaWJtYyk7Cj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9oaXNpbGljb24vaGlibWMvaGlibWNfdHRtLmMgYi9kcml2ZXJzL2dwdS9k cm0vaGlzaWxpY29uL2hpYm1jL2hpYm1jX3R0bS5jCj4gaW5kZXggMjFiNjg0ZWFiNWM5Li5mNmQy NWI4NWMyMDkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2hpc2lsaWNvbi9oaWJtYy9o aWJtY190dG0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9oaXNpbGljb24vaGlibWMvaGlibWNf dHRtLmMKPiBAQCAtMTUsNiArMTUsNyBAQAo+ICAKPiAgI2luY2x1ZGUgPGRybS9kcm1fYXRvbWlj X2hlbHBlci5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9nZW0uaD4KPiArI2luY2x1ZGUgPGRybS9k cm1fZ2VtX2ZyYW1lYnVmZmVyX2hlbHBlci5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9nZW1fdnJh bV9oZWxwZXIuaD4KPiAgI2luY2x1ZGUgPGRybS9kcm1fcHJpbnQuaD4KPiAgCj4gQEAgLTk3LDc0 ICs5OCw4IEBAIGludCBoaWJtY19kdW1iX2NyZWF0ZShzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGUsIHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAKPiAtc3RhdGljIHZv aWQgaGlibWNfdXNlcl9mcmFtZWJ1ZmZlcl9kZXN0cm95KHN0cnVjdCBkcm1fZnJhbWVidWZmZXIg KmZiKQo+IC17Cj4gLQlzdHJ1Y3QgaGlibWNfZnJhbWVidWZmZXIgKmhpYm1jX2ZiID0gdG9faGli bWNfZnJhbWVidWZmZXIoZmIpOwo+IC0KPiAtCWRybV9nZW1fb2JqZWN0X3B1dF91bmxvY2tlZCho aWJtY19mYi0+b2JqKTsKPiAtCWRybV9mcmFtZWJ1ZmZlcl9jbGVhbnVwKGZiKTsKPiAtCWtmcmVl KGhpYm1jX2ZiKTsKPiAtfQo+IC0KPiAtc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fZnJhbWVidWZm ZXJfZnVuY3MgaGlibWNfZmJfZnVuY3MgPSB7Cj4gLQkuZGVzdHJveSA9IGhpYm1jX3VzZXJfZnJh bWVidWZmZXJfZGVzdHJveSwKPiAtfTsKPiAtCj4gLXN0cnVjdCBoaWJtY19mcmFtZWJ1ZmZlciAq Cj4gLWhpYm1jX2ZyYW1lYnVmZmVyX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAtCQkg ICAgICAgY29uc3Qgc3RydWN0IGRybV9tb2RlX2ZiX2NtZDIgKm1vZGVfY21kLAo+IC0JCSAgICAg ICBzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKm9iaikKPiAtewo+IC0Jc3RydWN0IGhpYm1jX2ZyYW1l YnVmZmVyICpoaWJtY19mYjsKPiAtCWludCByZXQ7Cj4gLQo+IC0JaGlibWNfZmIgPSBremFsbG9j KHNpemVvZigqaGlibWNfZmIpLCBHRlBfS0VSTkVMKTsKPiAtCWlmICghaGlibWNfZmIpIHsKPiAt CQlEUk1fRVJST1IoImZhaWxlZCB0byBhbGxvY2F0ZSBoaWJtY19mYlxuIik7Cj4gLQkJcmV0dXJu IEVSUl9QVFIoLUVOT01FTSk7Cj4gLQl9Cj4gLQo+IC0JZHJtX2hlbHBlcl9tb2RlX2ZpbGxfZmJf c3RydWN0KGRldiwgJmhpYm1jX2ZiLT5mYiwgbW9kZV9jbWQpOwo+IC0JaGlibWNfZmItPm9iaiA9 IG9iajsKPiAtCXJldCA9IGRybV9mcmFtZWJ1ZmZlcl9pbml0KGRldiwgJmhpYm1jX2ZiLT5mYiwg JmhpYm1jX2ZiX2Z1bmNzKTsKPiAtCWlmIChyZXQpIHsKPiAtCQlEUk1fRVJST1IoImRybV9mcmFt ZWJ1ZmZlcl9pbml0IGZhaWxlZDogJWRcbiIsIHJldCk7Cj4gLQkJa2ZyZWUoaGlibWNfZmIpOwo+ IC0JCXJldHVybiBFUlJfUFRSKHJldCk7Cj4gLQl9Cj4gLQo+IC0JcmV0dXJuIGhpYm1jX2ZiOwo+ IC19Cj4gLQo+IC1zdGF0aWMgc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqCj4gLWhpYm1jX3VzZXJf ZnJhbWVidWZmZXJfY3JlYXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gLQkJCSAgICAgIHN0 cnVjdCBkcm1fZmlsZSAqZmlscCwKPiAtCQkJICAgICAgY29uc3Qgc3RydWN0IGRybV9tb2RlX2Zi X2NtZDIgKm1vZGVfY21kKQo+IC17Cj4gLQlzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKm9iajsKPiAt CXN0cnVjdCBoaWJtY19mcmFtZWJ1ZmZlciAqaGlibWNfZmI7Cj4gLQo+IC0JRFJNX0RFQlVHX0RS SVZFUigiJWR4JWQsIGZvcm1hdCAlYyVjJWMlY1xuIiwKPiAtCQkJIG1vZGVfY21kLT53aWR0aCwg bW9kZV9jbWQtPmhlaWdodCwKPiAtCQkJIChtb2RlX2NtZC0+cGl4ZWxfZm9ybWF0KSAmIDB4ZmYs Cj4gLQkJCSAobW9kZV9jbWQtPnBpeGVsX2Zvcm1hdCA+PiA4KSAgJiAweGZmLAo+IC0JCQkgKG1v ZGVfY21kLT5waXhlbF9mb3JtYXQgPj4gMTYpICYgMHhmZiwKPiAtCQkJIChtb2RlX2NtZC0+cGl4 ZWxfZm9ybWF0ID4+IDI0KSAmIDB4ZmYpOwo+IC0KPiAtCW9iaiA9IGRybV9nZW1fb2JqZWN0X2xv b2t1cChmaWxwLCBtb2RlX2NtZC0+aGFuZGxlc1swXSk7Cj4gLQlpZiAoIW9iaikKPiAtCQlyZXR1 cm4gRVJSX1BUUigtRU5PRU5UKTsKPiAtCj4gLQloaWJtY19mYiA9IGhpYm1jX2ZyYW1lYnVmZmVy X2luaXQoZGV2LCBtb2RlX2NtZCwgb2JqKTsKPiAtCWlmIChJU19FUlIoaGlibWNfZmIpKSB7Cj4g LQkJZHJtX2dlbV9vYmplY3RfcHV0X3VubG9ja2VkKG9iaik7Cj4gLQkJcmV0dXJuIEVSUl9QVFIo KGxvbmcpaGlibWNfZmIpOwo+IC0JfQo+IC0JcmV0dXJuICZoaWJtY19mYi0+ZmI7Cj4gLX0KPiAt Cj4gIGNvbnN0IHN0cnVjdCBkcm1fbW9kZV9jb25maWdfZnVuY3MgaGlibWNfbW9kZV9mdW5jcyA9 IHsKPiAgCS5hdG9taWNfY2hlY2sgPSBkcm1fYXRvbWljX2hlbHBlcl9jaGVjaywKPiAgCS5hdG9t aWNfY29tbWl0ID0gZHJtX2F0b21pY19oZWxwZXJfY29tbWl0LAo+IC0JLmZiX2NyZWF0ZSA9IGhp Ym1jX3VzZXJfZnJhbWVidWZmZXJfY3JlYXRlLAo+ICsJLmZiX2NyZWF0ZSA9IGRybV9nZW1fZmJf Y3JlYXRlLAo+ICB9Owo+IC0tIAo+IDIuMjMuMAo+IAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdh cmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==