From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 3/4] drm/hisilicon/hibmc: Implement hibmc_dumb_create() with generic helpers Date: Mon, 25 Nov 2019 10:14:26 +0100 Message-ID: <20191125091426.GG29965@phenom.ffwll.local> References: <20191122083044.6627-1-tzimmermann@suse.de> <20191122083044.6627-4-tzimmermann@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 59E1989FFD for ; Mon, 25 Nov 2019 09:14:30 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id i12so16914167wrn.11 for ; Mon, 25 Nov 2019 01:14:30 -0800 (PST) Content-Disposition: inline In-Reply-To: <20191122083044.6627-4-tzimmermann@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thomas Zimmermann Cc: yuehaibing@huawei.com, airlied@linux.ie, puck.chen@hisilicon.com, dri-devel@lists.freedesktop.org, z.liuxinliang@hisilicon.com, kong.kongxinwei@hisilicon.com, hslester96@gmail.com, kraxel@redhat.com, zourongrong@gmail.com, sam@ravnborg.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBOb3YgMjIsIDIwMTkgYXQgMDk6MzA6NDNBTSArMDEwMCwgVGhvbWFzIFppbW1lcm1h bm4gd3JvdGU6Cj4gVGhlIGhpYm1jIGRyaXZlciBhbGlnbnMgc2NhbmxpbmVzIHRvIDE2IGJ5dGVz LiBBZGRpbmcgdGhlIHBpdGNoIGFsaWdubWVudAo+IGFzIGFuIGFyZ3VtZW50IHRvIGRybV9nZW1f dnJhbV9maWxsX2NyZWF0ZV9kdW1iKCkgYWxsb3dzIHRvIHVzZSB0aGUgZ2VuZXJpYwo+IGltcGxl bWVudGF0aW9uIHdpdGggaGlibWMuIEEgdmFsdWUgb2YgMCBkaXNhYmxlcyBzY2FubGluZSBwaXRj aGVzLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFRob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBz dXNlLmRlPgoKSSBjb25jdXIgd2l0aCBTYW0sIHRoZSB2cmFtIGNoYW5nZSBzaG91bGQgYmUgc3Bs aXQgb3V0LgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9nZW1fdnJhbV9oZWxwZXIuYyAg ICAgICAgIHwgMTAgKystLQo+ICAuLi4vZ3B1L2RybS9oaXNpbGljb24vaGlibWMvaGlibWNfZHJt X2Rydi5oICAgfCAgNCAtLQo+ICBkcml2ZXJzL2dwdS9kcm0vaGlzaWxpY29uL2hpYm1jL2hpYm1j X3R0bS5jICAgfCA0OCArLS0tLS0tLS0tLS0tLS0tLS0tCj4gIGluY2x1ZGUvZHJtL2RybV9nZW1f dnJhbV9oZWxwZXIuaCAgICAgICAgICAgICB8ICAxICsKPiAgNCBmaWxlcyBjaGFuZ2VkLCAxMCBp bnNlcnRpb25zKCspLCA1MyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2RybV9nZW1fdnJhbV9oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtX3Zy YW1faGVscGVyLmMKPiBpbmRleCA2NjZjYjRjMjJiYjkuLmYwOTg3ODRlN2RmZCAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2dlbV92cmFtX2hlbHBlci5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2RybV9nZW1fdnJhbV9oZWxwZXIuYwo+IEBAIC00ODUsNiArNDg1LDcgQEAgRVhQ T1JUX1NZTUJPTChkcm1fZ2VtX3ZyYW1fdnVubWFwKTsKPiAgICogQGRldjoJCXRoZSBEUk0gZGV2 aWNlCj4gICAqIEBiZGV2OgkJdGhlIFRUTSBCTyBkZXZpY2UgbWFuYWdpbmcgdGhlIGJ1ZmZlciBv YmplY3QKPiAgICogQHBnX2FsaWduOgkJdGhlIGJ1ZmZlcidzIGFsaWdubWVudCBpbiBtdWx0aXBs ZXMgb2YgdGhlIHBhZ2Ugc2l6ZQo+ICsgKiBAcGl0Y2hfYWxpZ246CXRoZSBzY2FubGluZSdzIGFs aWdubWVudCBpbiBwb3dlcnMgb2YgMgo+ICAgKiBAaW50ZXJydXB0aWJsZToJc2xlZXAgaW50ZXJy dXB0aWJsZSBpZiB3YWl0aW5nIGZvciBtZW1vcnkKCkkgYWxzbyBub3RpY2VkIHRoYXQgbm8gb25l IHNldHMgdGhpcyB0byB0cnVlLCBuZWl0aGVyIGhlcmUgbm9yIGluCmRybV9nZW1fdnJhbV9jcmVh dGUoKS4gTWF5YmUgcmVtb3ZlIHRoYXQgdG9vPyBPdGhlcndpc2UgdGhlIGFyZ3VtZW50IGxpc3QK YmVjb21lcyB2ZXJ5IHVud2llbGRpbmcuIEFuZCB5b3UncmUgYWxyZWFkeSB0b3VjaGluZyB0aGUg KGZldykgY2FsbGVycy4KCj4gICAqIEBhcmdzOgkJdGhlIGFyZ3VtZW50cyBhcyBwcm92aWRlZCB0 byBcCj4gIAkJCQkmc3RydWN0IGRybV9kcml2ZXIuZHVtYl9jcmVhdGUKPiBAQCAtNTAyLDYgKzUw Myw3IEBAIGludCBkcm1fZ2VtX3ZyYW1fZmlsbF9jcmVhdGVfZHVtYihzdHJ1Y3QgZHJtX2ZpbGUg KmZpbGUsCj4gIAkJCQkgIHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAkJCQkgIHN0cnVjdCB0 dG1fYm9fZGV2aWNlICpiZGV2LAo+ICAJCQkJICB1bnNpZ25lZCBsb25nIHBnX2FsaWduLAo+ICsJ CQkJICB1bnNpZ25lZCBsb25nIHBpdGNoX2FsaWduLAo+ICAJCQkJICBib29sIGludGVycnVwdGli bGUsCj4gIAkJCQkgIHN0cnVjdCBkcm1fbW9kZV9jcmVhdGVfZHVtYiAqYXJncykKPiAgewo+IEBA IC01MTAsNyArNTEyLDkgQEAgaW50IGRybV9nZW1fdnJhbV9maWxsX2NyZWF0ZV9kdW1iKHN0cnVj dCBkcm1fZmlsZSAqZmlsZSwKPiAgCWludCByZXQ7Cj4gIAl1MzIgaGFuZGxlOwo+ICAKPiAtCXBp dGNoID0gYXJncy0+d2lkdGggKiAoKGFyZ3MtPmJwcCArIDcpIC8gOCk7Cj4gKwlwaXRjaCA9IGFy Z3MtPndpZHRoICogRElWX1JPVU5EX1VQKGFyZ3MtPmJwcCwgOCk7Cj4gKwlpZiAocGl0Y2hfYWxp Z24pCj4gKwkJcGl0Y2ggPSBBTElHTihwaXRjaCwgcGl0Y2hfYWxpZ24pOwoKTWF5YmUgdGhyb3cg YSBXQVJOX0lTKGlzX3BvdChhbGlnbikpIGluIGhlcmU/CgpDaGVlcnMsIERhbmllbAoKPiAgCXNp emUgPSBwaXRjaCAqIGFyZ3MtPmhlaWdodDsKPiAgCj4gIAlzaXplID0gcm91bmR1cChzaXplLCBQ QUdFX1NJWkUpOwo+IEBAIC02MTIsOCArNjE2LDggQEAgaW50IGRybV9nZW1fdnJhbV9kcml2ZXJf ZHVtYl9jcmVhdGUoc3RydWN0IGRybV9maWxlICpmaWxlLAo+ICAJaWYgKFdBUk5fT05DRSghZGV2 LT52cmFtX21tLCAiVlJBTSBNTSBub3QgaW5pdGlhbGl6ZWQiKSkKPiAgCQlyZXR1cm4gLUVJTlZB TDsKPiAgCj4gLQlyZXR1cm4gZHJtX2dlbV92cmFtX2ZpbGxfY3JlYXRlX2R1bWIoZmlsZSwgZGV2 LCAmZGV2LT52cmFtX21tLT5iZGV2LCAwLAo+IC0JCQkJCSAgICAgZmFsc2UsIGFyZ3MpOwo+ICsJ cmV0dXJuIGRybV9nZW1fdnJhbV9maWxsX2NyZWF0ZV9kdW1iKGZpbGUsIGRldiwgJmRldi0+dnJh bV9tbS0+YmRldiwKPiArCQkJCQkgICAgIDAsIDAsIGZhbHNlLCBhcmdzKTsKPiAgfQo+ICBFWFBP UlRfU1lNQk9MKGRybV9nZW1fdnJhbV9kcml2ZXJfZHVtYl9jcmVhdGUpOwo+ICAKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2hpc2lsaWNvbi9oaWJtYy9oaWJtY19kcm1fZHJ2LmggYi9k cml2ZXJzL2dwdS9kcm0vaGlzaWxpY29uL2hpYm1jL2hpYm1jX2RybV9kcnYuaAo+IGluZGV4IDhl YjcyNThiMjM2YS4uNTBhMGMxZjlkMjExIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9o aXNpbGljb24vaGlibWMvaGlibWNfZHJtX2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2hp c2lsaWNvbi9oaWJtYy9oaWJtY19kcm1fZHJ2LmgKPiBAQCAtMTgsNyArMTgsNiBAQAo+ICAjaW5j bHVkZSA8ZHJtL2RybV9mcmFtZWJ1ZmZlci5oPgo+ICAKPiAgc3RydWN0IGRybV9kZXZpY2U7Cj4g LXN0cnVjdCBkcm1fZ2VtX29iamVjdDsKPiAgCj4gIHN0cnVjdCBoaWJtY19kcm1fcHJpdmF0ZSB7 Cj4gIAkvKiBodyAqLwo+IEBAIC00MSw5ICs0MCw2IEBAIHZvaWQgaGlibWNfc2V0X2N1cnJlbnRf Z2F0ZShzdHJ1Y3QgaGlibWNfZHJtX3ByaXZhdGUgKnByaXYsCj4gIGludCBoaWJtY19kZV9pbml0 KHN0cnVjdCBoaWJtY19kcm1fcHJpdmF0ZSAqcHJpdik7Cj4gIGludCBoaWJtY192ZGFjX2luaXQo c3RydWN0IGhpYm1jX2RybV9wcml2YXRlICpwcml2KTsKPiAgCj4gLWludCBoaWJtY19nZW1fY3Jl YXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHUzMiBzaXplLCBib29sIGlza2VybmVsLAo+IC0J CSAgICAgc3RydWN0IGRybV9nZW1fb2JqZWN0ICoqb2JqKTsKPiAtCj4gIGludCBoaWJtY19tbV9p bml0KHN0cnVjdCBoaWJtY19kcm1fcHJpdmF0ZSAqaGlibWMpOwo+ICB2b2lkIGhpYm1jX21tX2Zp bmkoc3RydWN0IGhpYm1jX2RybV9wcml2YXRlICpoaWJtYyk7Cj4gIGludCBoaWJtY19kdW1iX2Ny ZWF0ZShzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGUsIHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9oaXNpbGljb24vaGlibWMvaGlibWNfdHRtLmMgYi9k cml2ZXJzL2dwdS9kcm0vaGlzaWxpY29uL2hpYm1jL2hpYm1jX3R0bS5jCj4gaW5kZXggZjZkMjVi ODVjMjA5Li4wYWY1ZDk2NmE0ODAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2hpc2ls aWNvbi9oaWJtYy9oaWJtY190dG0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9oaXNpbGljb24v aGlibWMvaGlibWNfdHRtLmMKPiBAQCAtNDcsNTUgKzQ3LDExIEBAIHZvaWQgaGlibWNfbW1fZmlu aShzdHJ1Y3QgaGlibWNfZHJtX3ByaXZhdGUgKmhpYm1jKQo+ICAJZHJtX3ZyYW1faGVscGVyX3Jl bGVhc2VfbW0oaGlibWMtPmRldik7Cj4gIH0KPiAgCj4gLWludCBoaWJtY19nZW1fY3JlYXRlKHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYsIHUzMiBzaXplLCBib29sIGlza2VybmVsLAo+IC0JCSAgICAg c3RydWN0IGRybV9nZW1fb2JqZWN0ICoqb2JqKQo+IC17Cj4gLQlzdHJ1Y3QgZHJtX2dlbV92cmFt X29iamVjdCAqZ2JvOwo+IC0JaW50IHJldDsKPiAtCj4gLQkqb2JqID0gTlVMTDsKPiAtCj4gLQlz aXplID0gcm91bmR1cChzaXplLCBQQUdFX1NJWkUpOwo+IC0JaWYgKHNpemUgPT0gMCkKPiAtCQly ZXR1cm4gLUVJTlZBTDsKPiAtCj4gLQlnYm8gPSBkcm1fZ2VtX3ZyYW1fY3JlYXRlKGRldiwgJmRl di0+dnJhbV9tbS0+YmRldiwgc2l6ZSwgMCwgZmFsc2UpOwo+IC0JaWYgKElTX0VSUihnYm8pKSB7 Cj4gLQkJcmV0ID0gUFRSX0VSUihnYm8pOwo+IC0JCWlmIChyZXQgIT0gLUVSRVNUQVJUU1lTKQo+ IC0JCQlEUk1fRVJST1IoImZhaWxlZCB0byBhbGxvY2F0ZSBHRU0gb2JqZWN0OiAlZFxuIiwgcmV0 KTsKPiAtCQlyZXR1cm4gcmV0Owo+IC0JfQo+IC0JKm9iaiA9ICZnYm8tPmJvLmJhc2U7Cj4gLQly ZXR1cm4gMDsKPiAtfQo+IC0KPiAgaW50IGhpYm1jX2R1bWJfY3JlYXRlKHN0cnVjdCBkcm1fZmls ZSAqZmlsZSwgc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCQkgICAgICBzdHJ1Y3QgZHJtX21v ZGVfY3JlYXRlX2R1bWIgKmFyZ3MpCj4gIHsKPiAtCXN0cnVjdCBkcm1fZ2VtX29iamVjdCAqZ29i ajsKPiAtCXUzMiBoYW5kbGU7Cj4gLQlpbnQgcmV0Owo+IC0KPiAtCWFyZ3MtPnBpdGNoID0gQUxJ R04oYXJncy0+d2lkdGggKiBESVZfUk9VTkRfVVAoYXJncy0+YnBwLCA4KSwgMTYpOwo+IC0JYXJn cy0+c2l6ZSA9IGFyZ3MtPnBpdGNoICogYXJncy0+aGVpZ2h0Owo+IC0KPiAtCXJldCA9IGhpYm1j X2dlbV9jcmVhdGUoZGV2LCBhcmdzLT5zaXplLCBmYWxzZSwKPiAtCQkJICAgICAgICZnb2JqKTsK PiAtCWlmIChyZXQpIHsKPiAtCQlEUk1fRVJST1IoImZhaWxlZCB0byBjcmVhdGUgR0VNIG9iamVj dDogJWRcbiIsIHJldCk7Cj4gLQkJcmV0dXJuIHJldDsKPiAtCX0KPiAtCj4gLQlyZXQgPSBkcm1f Z2VtX2hhbmRsZV9jcmVhdGUoZmlsZSwgZ29iaiwgJmhhbmRsZSk7Cj4gLQlkcm1fZ2VtX29iamVj dF9wdXRfdW5sb2NrZWQoZ29iaik7Cj4gLQlpZiAocmV0KSB7Cj4gLQkJRFJNX0VSUk9SKCJmYWls ZWQgdG8gdW5yZWZlcmVuY2UgR0VNIG9iamVjdDogJWRcbiIsIHJldCk7Cj4gLQkJcmV0dXJuIHJl dDsKPiAtCX0KPiAtCj4gLQlhcmdzLT5oYW5kbGUgPSBoYW5kbGU7Cj4gLQlyZXR1cm4gMDsKPiAr CXJldHVybiBkcm1fZ2VtX3ZyYW1fZmlsbF9jcmVhdGVfZHVtYihmaWxlLCBkZXYsICZkZXYtPnZy YW1fbW0tPmJkZXYsCj4gKwkJCQkJICAgICAwLCAxNiwgZmFsc2UsIGFyZ3MpOwo+ICB9Cj4gIAo+ ICBjb25zdCBzdHJ1Y3QgZHJtX21vZGVfY29uZmlnX2Z1bmNzIGhpYm1jX21vZGVfZnVuY3MgPSB7 Cj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9nZW1fdnJhbV9oZWxwZXIuaCBiL2luY2x1 ZGUvZHJtL2RybV9nZW1fdnJhbV9oZWxwZXIuaAo+IGluZGV4IGUwNDA1NDFhMTA1Zi4uYzY0MmI0 Y2I2NjAwIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9nZW1fdnJhbV9oZWxwZXIuaAo+ ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9nZW1fdnJhbV9oZWxwZXIuaAo+IEBAIC0xMTMsNiArMTEz LDcgQEAgaW50IGRybV9nZW1fdnJhbV9maWxsX2NyZWF0ZV9kdW1iKHN0cnVjdCBkcm1fZmlsZSAq ZmlsZSwKPiAgCQkJCSAgc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCQkJCSAgc3RydWN0IHR0 bV9ib19kZXZpY2UgKmJkZXYsCj4gIAkJCQkgIHVuc2lnbmVkIGxvbmcgcGdfYWxpZ24sCj4gKwkJ CQkgIHVuc2lnbmVkIGxvbmcgcGl0Y2hfYWxpZ24sCj4gIAkJCQkgIGJvb2wgaW50ZXJydXB0aWJs ZSwKPiAgCQkJCSAgc3RydWN0IGRybV9tb2RlX2NyZWF0ZV9kdW1iICphcmdzKTsKPiAgCj4gLS0g Cj4gMi4yMy4wCj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwg Q29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVs