From: Daniel Vetter <daniel@ffwll.ch>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org,
Jon Hunter <jonathanh@nvidia.com>
Subject: Re: [PATCH] drm/tegra: vic: Export module device table
Date: Mon, 25 Nov 2019 10:56:29 +0100 [thread overview]
Message-ID: <20191125095629.GK29965@phenom.ffwll.local> (raw)
In-Reply-To: <20191122133215.1317039-1-thierry.reding@gmail.com>
On Fri, Nov 22, 2019 at 02:32:15PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Export the module device table to ensure the VIC compatible strings are
> listed in the module's aliases table. This in turn causes the driver to
> be automatically loaded on boot if VIC is the only enabled subdevice of
> the logical host1x DRM device.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
I noticed that the drm subdev driver also lacks the matches. How does that
work? Just by getting loaded when any of the subdev drivers match?
-Daniel
> ---
> drivers/gpu/drm/tegra/vic.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/tegra/vic.c b/drivers/gpu/drm/tegra/vic.c
> index 9444ba183990..c4d82b8b3065 100644
> --- a/drivers/gpu/drm/tegra/vic.c
> +++ b/drivers/gpu/drm/tegra/vic.c
> @@ -386,13 +386,14 @@ static const struct vic_config vic_t194_config = {
> .supports_sid = true,
> };
>
> -static const struct of_device_id vic_match[] = {
> +static const struct of_device_id tegra_vic_of_match[] = {
> { .compatible = "nvidia,tegra124-vic", .data = &vic_t124_config },
> { .compatible = "nvidia,tegra210-vic", .data = &vic_t210_config },
> { .compatible = "nvidia,tegra186-vic", .data = &vic_t186_config },
> { .compatible = "nvidia,tegra194-vic", .data = &vic_t194_config },
> { },
> };
> +MODULE_DEVICE_TABLE(of, tegra_vic_of_match);
>
> static int vic_probe(struct platform_device *pdev)
> {
> @@ -516,7 +517,7 @@ static const struct dev_pm_ops vic_pm_ops = {
> struct platform_driver tegra_vic_driver = {
> .driver = {
> .name = "tegra-vic",
> - .of_match_table = vic_match,
> + .of_match_table = tegra_vic_of_match,
> .pm = &vic_pm_ops
> },
> .probe = vic_probe,
> --
> 2.23.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-11-25 9:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 13:32 [PATCH] drm/tegra: vic: Export module device table Thierry Reding
2019-11-25 9:56 ` Daniel Vetter [this message]
2019-11-25 10:45 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125095629.GK29965@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox