From: Sam Ravnborg <sam@ravnborg.org>
To: Jerry Han <jerry.han.hq@gmail.com>
Cc: Jitao Shi <jitao.shi@mediatek.com>,
Rock wang <rock_wang@himax.com.cn>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel
Date: Wed, 11 Dec 2019 21:06:51 +0100 [thread overview]
Message-ID: <20191211200651.GA10693@ravnborg.org> (raw)
In-Reply-To: <20191209014641.24685-1-jerry.han.hq@gmail.com>
Hi Jerry.
> Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI
> panel.
Thanks for your persistence with this driver.
Unfortunately the driver no longer builds after the drm_panel
work we committed earlier this week to drm-misc-next.
>
> V9:
> - Adjust init code, make the format more concise
> - kill off default_off_cmds (Emil)
> - use mipi_dsi_dcs_set_display_{on,off} in their enable/disable
> callbacks. (Emil)
> - Adjusting the delay function (Emil)
...
> +
> +struct panel_info {
> + struct drm_panel base;
> + struct mipi_dsi_device *link;
> + const struct panel_desc *desc;
> +
> + struct backlight_device *backlight;
We have included backlight support in drm_panel.
Can you please introduce this and post a patch updating the driver to
use this.
See other panle patches what is required to use it.
(Mostly deleting code)
I took a look at the rest of the driver and everything looks good.
Sorry for causing you this extra trouble due to the drm_panel changes.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-12-11 20:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 1:46 [PATCH] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel Jerry Han
2019-12-09 13:53 ` Emil Velikov
2019-12-11 20:06 ` Sam Ravnborg [this message]
2019-12-12 2:28 ` Jerry Han
-- strict thread matches above, loose matches on Subject: below --
2019-12-14 9:11 Jerry Han
2019-12-12 11:52 Jerry Han
2019-12-13 18:33 ` Sam Ravnborg
2019-12-06 7:45 Jerry Han
2019-12-07 20:30 ` kbuild test robot
2019-12-09 1:51 ` Jerry Han
2019-11-25 8:31 Jerry Han
2019-11-28 12:57 ` Emil Velikov
2019-12-06 7:51 ` Jerry Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191211200651.GA10693@ravnborg.org \
--to=sam@ravnborg.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jerry.han.hq@gmail.com \
--cc=jitao.shi@mediatek.com \
--cc=rock_wang@himax.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox