From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1464DC43603 for ; Thu, 12 Dec 2019 09:49:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E26D2214D8 for ; Thu, 12 Dec 2019 09:49:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E26D2214D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 353396ECEF; Thu, 12 Dec 2019 09:49:37 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2A5526ECEF for ; Thu, 12 Dec 2019 09:49:36 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 50CF220025; Thu, 12 Dec 2019 10:49:32 +0100 (CET) Date: Thu, 12 Dec 2019 10:49:30 +0100 From: Sam Ravnborg To: Thomas Zimmermann Subject: Re: [PATCH v2 0/3] drm/vram-helper: Various cleanups Message-ID: <20191212094930.GA32429@ravnborg.org> References: <20191212074117.29283-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191212074117.29283-1-tzimmermann@suse.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=Us_BYnCFKwWqwM_rN4gA:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=68kxEXcerHAAc8rfip4W:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: puck.chen@hisilicon.com, dri-devel@lists.freedesktop.org, kong.kongxinwei@hisilicon.com, kraxel@redhat.com, zourongrong@gmail.com, airlied@redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Thomas. On Thu, Dec 12, 2019 at 08:41:14AM +0100, Thomas Zimmermann wrote: > A number of cleanups that I wanted to apply for some time. The first > two patches simplify the public interface. The third patch adds support > for struct drm_driver.gem_create_object. All tested by running fbdev, > X11 and Weston on ast HW. > > v2: > * make drm_gem_vram_create() still work if GEM object is not > first in struct > > Thomas Zimmermann (3): > drm/vram-helper: Remove interruptible flag from public interface > drm/vram-helper: Remove BO device from public interface > drm/vram-helper: Support struct drm_driver.gem_create_object I have browsed the code changes - everything now looks fine. As I miss the high-level picture (which is just my lack of DRM knowledge) this is not a review. But you can add my: Acked-by: Sam Ravnborg Sam _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel