From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0E4BC32767 for ; Fri, 3 Jan 2020 22:26:51 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA901227BF for ; Fri, 3 Jan 2020 22:26:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA901227BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1D14C6E351; Fri, 3 Jan 2020 22:26:51 +0000 (UTC) Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by gabe.freedesktop.org (Postfix) with ESMTPS id E12B26E351 for ; Fri, 3 Jan 2020 22:26:49 +0000 (UTC) Received: by mail-il1-f196.google.com with SMTP id v15so37882632iln.0 for ; Fri, 03 Jan 2020 14:26:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nH8EiEpsw3qEqxTu/vy8rZgCVIsth2Q4jMx+TyJClBo=; b=MWGnbr+VjFv89vpt+K5ANG2xtIGXZ3K+HqnmgTpBdZ6OJnBn+cANHB73VxPkra/PQn RdQUZFYu+3jCyunSkXnmKFFP9BOYo/tbTOBVLitX5Z61GOZx3hyvMjs/1r2EcuJT2RXP X1EL8KjV+Ok+qQmn3Na4gZ98MGmM/QXFDXn6fgDimxk2cUbnqJKBoyJn2twvHtGQMmJ5 iJb605inqy0+fx+oGtr8xMOjR7hSQMiX5uFjm2YLGB+d6npkRjW0p+qmhXr8tERt4vnK cKo3udKusXqXuBeuaecklWeqqVdKcW3tZZKhWJwZsa4m+mVZGqM8VgF/MhKIj07236Da E1Zg== X-Gm-Message-State: APjAAAVWAg9jkEjw64FcGl+ZLfj+2r2EzR1aKMt2oADJxf11GS/IxeSE 6U7nBnQ0KzPhp3pwlziVjVOjobo= X-Google-Smtp-Source: APXvYqxBfAAk5uAmiwUNjbckpuM/KXaRt5y89pyW2xNiKPgbbjdPUtpqseD1K2dL6DAaydm/AdN/VQ== X-Received: by 2002:a92:4016:: with SMTP id n22mr75427638ila.13.1578090407818; Fri, 03 Jan 2020 14:26:47 -0800 (PST) Received: from rob-hp-laptop ([64.188.179.251]) by smtp.gmail.com with ESMTPSA id o12sm15093651ioh.42.2020.01.03.14.26.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2020 14:26:46 -0800 (PST) Received: from rob (uid 1000) (envelope-from rob@rob-hp-laptop) id 2219a5 by rob-hp-laptop (DragonFly Mail Agent v0.11); Fri, 03 Jan 2020 15:26:45 -0700 Date: Fri, 3 Jan 2020 15:26:45 -0700 From: Rob Herring To: Yongqiang Niu Subject: Re: [RESEND PATCH v6 01/17] dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display Message-ID: <20200103222645.GA24430@bogus> References: <1578021148-32413-1-git-send-email-yongqiang.niu@mediatek.com> <1578021148-32413-2-git-send-email-yongqiang.niu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1578021148-32413-2-git-send-email-yongqiang.niu@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Matthias Brugger , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Jan 03, 2020 at 11:12:12AM +0800, Yongqiang Niu wrote: > Update device tree binding documention for rdma_fifo_size Typo. And write complete sentences. > > Signed-off-by: Yongqiang Niu > --- > .../devicetree/bindings/display/mediatek/mediatek,disp.txt | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > index 681502e..34bef44 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > @@ -70,6 +70,10 @@ Required properties (DMA function blocks): > argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > for details. > > +Required properties (DMA function blocks): > +- mediatek,rdma_fifo_size: rdma fifo size may be different even in same SOC, add this > + property to the corresponding rdma s/_/-/ Valid values? Max value? > + > Examples: > > mmsys: clock-controller@14000000 { > @@ -211,3 +215,12 @@ od@14023000 { > power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>; > clocks = <&mmsys CLK_MM_DISP_OD>; > }; > + > +rdma1: rdma@1400c000 { > + compatible = "mediatek,mt8183-disp-rdma"; > + reg = <0 0x1400c000 0 0x1000>; > + interrupts = ; > + power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>; > + clocks = <&mmsys CLK_MM_DISP_RDMA1>; > + mediatek,rdma_fifo_size = <2048>; > +}; A new property doesn't really warrant a whole new example. > \ No newline at end of file ^^^ > -- > 1.8.1.1.dirty _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel