From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A6E5C35254 for ; Mon, 17 Feb 2020 09:23:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 560A42064C for ; Mon, 17 Feb 2020 09:23:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="TDUJAUEl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 560A42064C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C7FF889D8A; Mon, 17 Feb 2020 09:23:40 +0000 (UTC) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id 316A389D8A for ; Mon, 17 Feb 2020 09:23:39 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id a6so17578429wme.2 for ; Mon, 17 Feb 2020 01:23:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=SDHbQZgAe/0wL32buiu3qydqxJ8NuP7my4bW9GtwyNI=; b=TDUJAUElH15Ig5PUX0uQnd7Je+MaIxgpE9mNwdl28erTED/vHRD+5mMVEPXbi5h0gM ubg/8CdzH01TMJY8yfJje7gnvp7n4CtivS1TB1qYuK1eqcsdjVoaUt+MKxHMIFp5FQri TXbpwGPXQNPeGZCtPUhkKEFyVFcjppP49cnRw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=SDHbQZgAe/0wL32buiu3qydqxJ8NuP7my4bW9GtwyNI=; b=FOShjmzUf7IQXilNuolauwUJcGyw8gd6P4V2YXLibRjI9fRwbT45f88ndupN3lCMNn PHGVJFPuXWaRIQqJCPIRuU1P7oOZiJ+rkPRuUdWI63CmPU4Q3rf2aU+n5WdgN5oBNXhA n+DDLbado/COaEWEB5AhmpGNzety8orWcKi9iKH8ne4Z1+/m8hoGxxt5oVfRqYrQVjCP yGT8rDq8eM58jRDhl7fxNpg5WujvCyTf/UrHf1b6TG6ROFT39z5NsVSJdL3M47I4P0kA wpj02p3EgDdR+XG5n7Y60WTAaxWMAoPbuImwGY1Lp/oaKIKV56dJ+mHAAawRqmS7H/Yl 64QA== X-Gm-Message-State: APjAAAWXVGYvwGiTQMQle4qvDfEgqtf45h9qYURhFs4HE0QfQgEt895o xWR88fWdnGJO6ny+9uiHBR8S/w== X-Google-Smtp-Source: APXvYqxUSEO3oqlrl6mAlIwlwYFDGhy1hib1i902OAkCcuqbn3UGYx27uFW44njViswwDRL6MBQi5Q== X-Received: by 2002:a05:600c:21da:: with SMTP id x26mr21112207wmj.4.1581931417627; Mon, 17 Feb 2020 01:23:37 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id j15sm97557wrp.9.2020.02.17.01.23.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2020 01:23:37 -0800 (PST) Date: Mon, 17 Feb 2020 10:23:35 +0100 From: Daniel Vetter To: Maya Rashish Subject: Re: [PATCH] Correct typos in comments Message-ID: <20200217092335.GD2363188@phenom.ffwll.local> References: <20200214112938.GA26876@homeworld.netbsd.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200214112938.GA26876@homeworld.netbsd.org> X-Operating-System: Linux phenom 5.3.0-3-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Feb 14, 2020 at 11:29:38AM +0000, Maya Rashish wrote: > Signed-off-by: Maya Rashish > Co-authored-by: Thomas Klausner Also, we need a s-o-b from every co-author, because of the dco: https://developercertificate.org/ Thanks, Daniel > --- > drivers/gpu/drm/amd/include/atombios.h | 20 ++++++++++---------- > drivers/gpu/drm/amd/include/atomfirmware.h | 4 ++-- > drivers/gpu/drm/radeon/atombios.h | 8 ++++---- > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 2 +- > 4 files changed, 17 insertions(+), 17 deletions(-) > > diff --git a/drivers/gpu/drm/amd/include/atombios.h b/drivers/gpu/drm/amd/include/atombios.h > index 8ba21747b40a..2f124c1a9c8e 100644 > --- a/drivers/gpu/drm/amd/include/atombios.h > +++ b/drivers/gpu/drm/amd/include/atombios.h > @@ -1987,9 +1987,9 @@ typedef struct _PIXEL_CLOCK_PARAMETERS_V6 > #define PIXEL_CLOCK_V6_MISC_HDMI_BPP_MASK 0x0c > #define PIXEL_CLOCK_V6_MISC_HDMI_24BPP 0x00 > #define PIXEL_CLOCK_V6_MISC_HDMI_36BPP 0x04 > -#define PIXEL_CLOCK_V6_MISC_HDMI_36BPP_V6 0x08 //for V6, the correct defintion for 36bpp should be 2 for 36bpp(2:1) > +#define PIXEL_CLOCK_V6_MISC_HDMI_36BPP_V6 0x08 //for V6, the correct definition for 36bpp should be 2 for 36bpp(2:1) > #define PIXEL_CLOCK_V6_MISC_HDMI_30BPP 0x08 > -#define PIXEL_CLOCK_V6_MISC_HDMI_30BPP_V6 0x04 //for V6, the correct defintion for 30bpp should be 1 for 36bpp(5:4) > +#define PIXEL_CLOCK_V6_MISC_HDMI_30BPP_V6 0x04 //for V6, the correct definition for 30bpp should be 1 for 36bpp(5:4) > #define PIXEL_CLOCK_V6_MISC_HDMI_48BPP 0x0c > #define PIXEL_CLOCK_V6_MISC_REF_DIV_SRC 0x10 > #define PIXEL_CLOCK_V6_MISC_GEN_DPREFCLK 0x40 > @@ -2420,7 +2420,7 @@ typedef struct _LVDS_ENCODER_CONTROL_PARAMETERS > typedef struct _LVDS_ENCODER_CONTROL_PARAMETERS_V2 > { > USHORT usPixelClock; // in 10KHz; for bios convenient > - UCHAR ucMisc; // see PANEL_ENCODER_MISC_xx defintions below > + UCHAR ucMisc; // see PANEL_ENCODER_MISC_xx definitions below > UCHAR ucAction; // 0: turn off encoder > // 1: setup and turn on encoder > UCHAR ucTruncate; // bit0=0: Disable truncate > @@ -2873,7 +2873,7 @@ typedef struct _ATOM_MULTIMEDIA_CONFIG_INFO > // Structures used in FirmwareInfoTable > /****************************************************************************/ > > -// usBIOSCapability Defintion: > +// usBIOSCapability Definition: > // Bit 0 = 0: Bios image is not Posted, =1:Bios image is Posted; > // Bit 1 = 0: Dual CRTC is not supported, =1: Dual CRTC is supported; > // Bit 2 = 0: Extended Desktop is not supported, =1: Extended Desktop is supported; > @@ -4213,7 +4213,7 @@ typedef struct _ATOM_DPCD_INFO > #define ATOM_DPCD_MAX_LANE_MASK 0x1F > > /**************************************************************************/ > -// VRAM usage and their defintions > +// VRAM usage and their definitions > > // One chunk of VRAM used by Bios are for HWICON surfaces,EDID data. > // Current Mode timing and Dail Timing and/or STD timing data EACH device. They can be broken down as below. > @@ -6753,7 +6753,7 @@ typedef struct _ATOM_ASIC_INTERNAL_SS_INFO_V3 > #define ATOM_S0_SYSTEM_POWER_STATE_VALUE_LITEAC 3 > #define ATOM_S0_SYSTEM_POWER_STATE_VALUE_LIT2AC 4 > > -//Byte aligned defintion for BIOS usage > +//Byte aligned definition for BIOS usage > #define ATOM_S0_CRT1_MONOb0 0x01 > #define ATOM_S0_CRT1_COLORb0 0x02 > #define ATOM_S0_CRT1_MASKb0 (ATOM_S0_CRT1_MONOb0+ATOM_S0_CRT1_COLORb0) > @@ -6819,7 +6819,7 @@ typedef struct _ATOM_ASIC_INTERNAL_SS_INFO_V3 > #define ATOM_S2_DISPLAY_ROTATION_ANGLE_MASK 0xC0000000L > > > -//Byte aligned defintion for BIOS usage > +//Byte aligned definition for BIOS usage > #define ATOM_S2_TV1_STANDARD_MASKb0 0x0F > #define ATOM_S2_CURRENT_BL_LEVEL_MASKb1 0xFF > #define ATOM_S2_DEVICE_DPMS_STATEb2 0x01 > @@ -6871,7 +6871,7 @@ typedef struct _ATOM_ASIC_INTERNAL_SS_INFO_V3 > > > > -//Byte aligned defintion for BIOS usage > +//Byte aligned definition for BIOS usage > #define ATOM_S3_CRT1_ACTIVEb0 0x01 > #define ATOM_S3_LCD1_ACTIVEb0 0x02 > #define ATOM_S3_TV1_ACTIVEb0 0x04 > @@ -6910,7 +6910,7 @@ typedef struct _ATOM_ASIC_INTERNAL_SS_INFO_V3 > #define ATOM_S4_LCD1_REFRESH_MASK 0x0000FF00L > #define ATOM_S4_LCD1_REFRESH_SHIFT 8 > > -//Byte aligned defintion for BIOS usage > +//Byte aligned definition for BIOS usage > #define ATOM_S4_LCD1_PANEL_ID_MASKb0 0x0FF > #define ATOM_S4_LCD1_REFRESH_MASKb1 ATOM_S4_LCD1_PANEL_ID_MASKb0 > #define ATOM_S4_VRAM_INFO_MASKb2 ATOM_S4_LCD1_PANEL_ID_MASKb0 > @@ -6989,7 +6989,7 @@ typedef struct _ATOM_ASIC_INTERNAL_SS_INFO_V3 > #define ATOM_S6_VRI_BRIGHTNESS_CHANGE 0x40000000L > #define ATOM_S6_CONFIG_DISPLAY_CHANGE_MASK 0x80000000L > > -//Byte aligned defintion for BIOS usage > +//Byte aligned definition for BIOS usage > #define ATOM_S6_DEVICE_CHANGEb0 0x01 > #define ATOM_S6_SCALER_CHANGEb0 0x02 > #define ATOM_S6_LID_CHANGEb0 0x04 > diff --git a/drivers/gpu/drm/amd/include/atomfirmware.h b/drivers/gpu/drm/amd/include/atomfirmware.h > index 70146518174c..f9dcf67b3517 100644 > --- a/drivers/gpu/drm/amd/include/atomfirmware.h > +++ b/drivers/gpu/drm/amd/include/atomfirmware.h > @@ -445,7 +445,7 @@ struct atom_dtd_format > uint8_t refreshrate; > }; > > -/* atom_dtd_format.modemiscinfo defintion */ > +/* atom_dtd_format.modemiscinfo definition */ > enum atom_dtd_format_modemiscinfo{ > ATOM_HSYNC_POLARITY = 0x0002, > ATOM_VSYNC_POLARITY = 0x0004, > @@ -597,7 +597,7 @@ struct lcd_info_v2_1 > uint32_t reserved1[8]; > }; > > -/* lcd_info_v2_1.panel_misc defintion */ > +/* lcd_info_v2_1.panel_misc definition */ > enum atom_lcd_info_panel_misc{ > ATOM_PANEL_MISC_FPDI =0x0002, > }; > diff --git a/drivers/gpu/drm/radeon/atombios.h b/drivers/gpu/drm/radeon/atombios.h > index 4b86e8b45009..e118d4bec807 100644 > --- a/drivers/gpu/drm/radeon/atombios.h > +++ b/drivers/gpu/drm/radeon/atombios.h > @@ -1711,9 +1711,9 @@ typedef struct _PIXEL_CLOCK_PARAMETERS_V6 > #define PIXEL_CLOCK_V6_MISC_HDMI_BPP_MASK 0x0c > #define PIXEL_CLOCK_V6_MISC_HDMI_24BPP 0x00 > #define PIXEL_CLOCK_V6_MISC_HDMI_36BPP 0x04 > -#define PIXEL_CLOCK_V6_MISC_HDMI_36BPP_V6 0x08 //for V6, the correct defintion for 36bpp should be 2 for 36bpp(2:1) > +#define PIXEL_CLOCK_V6_MISC_HDMI_36BPP_V6 0x08 //for V6, the correct definition for 36bpp should be 2 for 36bpp(2:1) > #define PIXEL_CLOCK_V6_MISC_HDMI_30BPP 0x08 > -#define PIXEL_CLOCK_V6_MISC_HDMI_30BPP_V6 0x04 //for V6, the correct defintion for 30bpp should be 1 for 36bpp(5:4) > +#define PIXEL_CLOCK_V6_MISC_HDMI_30BPP_V6 0x04 //for V6, the correct definition for 30bpp should be 1 for 36bpp(5:4) > #define PIXEL_CLOCK_V6_MISC_HDMI_48BPP 0x0c > #define PIXEL_CLOCK_V6_MISC_REF_DIV_SRC 0x10 > #define PIXEL_CLOCK_V6_MISC_GEN_DPREFCLK 0x40 > @@ -2036,7 +2036,7 @@ typedef struct _LVDS_ENCODER_CONTROL_PARAMETERS > typedef struct _LVDS_ENCODER_CONTROL_PARAMETERS_V2 > { > USHORT usPixelClock; // in 10KHz; for bios convenient > - UCHAR ucMisc; // see PANEL_ENCODER_MISC_xx defintions below > + UCHAR ucMisc; // see PANEL_ENCODER_MISC_xx definitions below > UCHAR ucAction; // 0: turn off encoder > // 1: setup and turn on encoder > UCHAR ucTruncate; // bit0=0: Disable truncate > @@ -3732,7 +3732,7 @@ typedef struct _ATOM_DPCD_INFO > #define ATOM_DPCD_MAX_LANE_MASK 0x1F > > /**************************************************************************/ > -// VRAM usage and their defintions > +// VRAM usage and their definitions > > // One chunk of VRAM used by Bios are for HWICON surfaces,EDID data. > // Current Mode timing and Dail Timing and/or STD timing data EACH device. They can be broken down as below. > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > index f47d5710cc95..5195c19d25a4 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > @@ -2016,7 +2016,7 @@ void vmw_disable_vblank(struct drm_device *dev, unsigned int pipe) > * plugin and generate DRM uevent > * @dev_priv: device private > * @num_rects: number of drm_rect in rects > - * @rects: toplogy to update > + * @rects: topology to update > */ > static int vmw_du_update_layout(struct vmw_private *dev_priv, > unsigned int num_rects, struct drm_rect *rects) > -- > 2.21.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel