From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 584B0C11D04 for ; Thu, 20 Feb 2020 11:29:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32C402071E for ; Thu, 20 Feb 2020 11:29:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32C402071E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9FA656ED3A; Thu, 20 Feb 2020 11:29:20 +0000 (UTC) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4A5AD6ED38 for ; Thu, 20 Feb 2020 11:29:19 +0000 (UTC) Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id A7AFF294E04; Thu, 20 Feb 2020 11:29:16 +0000 (GMT) Date: Thu, 20 Feb 2020 12:29:13 +0100 From: Boris Brezillon To: Andrzej Pietrasiewicz Subject: Re: [PATCHv5 29/34] drm/arm/malidp: Make verify funcitons invocations independent Message-ID: <20200220122913.5cd80425@collabora.com> In-Reply-To: <20200220122601.1e2212a4@collabora.com> References: <20191213173350.GJ624164@phenom.ffwll.local> <20191217145020.14645-1-andrzej.p@collabora.com> <20191217145020.14645-30-andrzej.p@collabora.com> <20200220122601.1e2212a4@collabora.com> Organization: Collabora X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mihail Atanassov , David Airlie , Liviu Dudau , Sandy Huang , dri-devel@lists.freedesktop.org, Ayan Halder , James Wang , kernel@collabora.com, Sean Paul Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 20 Feb 2020 12:26:01 +0100 Boris Brezillon wrote: > In the subject: s/funcitons/functions/ > > On Tue, 17 Dec 2019 15:50:15 +0100 > Andrzej Pietrasiewicz wrote: > > > This will make it easier to transition to generic afbc-aware helpers. > > > > Signed-off-by: Andrzej Pietrasiewicz > > Reviewed-by: Boris Brezillon Wait, patch 30 is this patch completely irrelevant, so I take R-b back :-). You can just squash that one in patch 30. > > > --- > > drivers/gpu/drm/arm/malidp_drv.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c > > index 37d92a06318e..961e5a3f5b08 100644 > > --- a/drivers/gpu/drm/arm/malidp_drv.c > > +++ b/drivers/gpu/drm/arm/malidp_drv.c > > @@ -362,10 +362,10 @@ static bool > > malidp_verify_afbc_framebuffer(struct drm_device *dev, struct drm_file *file, > > const struct drm_mode_fb_cmd2 *mode_cmd) > > { > > - if (malidp_verify_afbc_framebuffer_caps(dev, mode_cmd)) > > - return malidp_verify_afbc_framebuffer_size(dev, file, mode_cmd); > > + if (!malidp_verify_afbc_framebuffer_caps(dev, mode_cmd)) > > + return false; > > > > - return false; > > + return malidp_verify_afbc_framebuffer_size(dev, file, mode_cmd); > > } > > > > static struct drm_framebuffer * > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel