From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98DB9C11D19 for ; Thu, 20 Feb 2020 18:14:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 759232467A for ; Thu, 20 Feb 2020 18:14:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="YbsgFHpr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 759232467A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AA1166EE30; Thu, 20 Feb 2020 18:14:47 +0000 (UTC) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0896E6EE30 for ; Thu, 20 Feb 2020 18:14:46 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id m10so3389050wmc.0 for ; Thu, 20 Feb 2020 10:14:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=gznl4640Pmjty68zKptsYkWkjNeUmDBlZFmAL3gSFPE=; b=YbsgFHprAZngpJ64emSEHbG/VsiZpyqbsgRuOHCXapQk3shJhhfNfjXpx0xrWdI1qt TInKZ6bAFGf/E6AENPaHYpSbVNWGhcsIFaUvfjpGJcABfkb49W5N+AxmkDR6BWI21DFn avUc4a4TTWJunNOed0cmyQwM+/q6KqPcoNFwI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=gznl4640Pmjty68zKptsYkWkjNeUmDBlZFmAL3gSFPE=; b=RWuJDovBeGKDJsoOG2ff+iOx5xzsUKBW40zd/o21nARIvcfGc/wWP0GYqDwIU3ee6/ x+aeWDjYsTLBvZHElMHodBSJ63ZcY6ovEsiB1eMy++L3w4f3Owp1cLCWzWsftFlKdH3E RL2Momg11iPTGOx7pB8OYK0Sm6bOkr9p03lbs/jUqr4SbH/IkAyQKDNqPU2y0TBW/sZz 2Qtg5OH6lF6s+MhHXbTLDIj4cJfdOxoQvBVGqdTZyTXP8fjTJTrwgSdeT8bf2zCNxngV iVhZgL33KVhlKIVw1ZN6yf1XXxw5hjE8edv5fBthFd48LRmYlA/XeXvTcU3iCLiCjFAv hEZw== X-Gm-Message-State: APjAAAXG+yurfsWarFCC8uw6fBnTAJNrWRjnRvoyWr9mdpQCM1qv+ezT cdAeTe23diPva/hBT6+MOMgtew== X-Google-Smtp-Source: APXvYqzTWpnmL8Z8rp8OENnYGEbj5HolTszXBtFYgJQK5//Eu/POgaU/ZY2vHhLmewsS8dUgPRJZkA== X-Received: by 2002:a1c:990b:: with SMTP id b11mr5769459wme.15.1582222484712; Thu, 20 Feb 2020 10:14:44 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id c141sm98136wme.41.2020.02.20.10.14.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2020 10:14:44 -0800 (PST) Date: Thu, 20 Feb 2020 19:14:42 +0100 From: Daniel Vetter To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 05/12] drm/msm/dpu: Stop copying around mode->private_flags Message-ID: <20200220181442.GV2363188@phenom.ffwll.local> References: <20200219203544.31013-1-ville.syrjala@linux.intel.com> <20200219203544.31013-6-ville.syrjala@linux.intel.com> <20200220153309.GB13686@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200220153309.GB13686@intel.com> X-Operating-System: Linux phenom 5.3.0-3-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, Intel Graphics Development , Emil Velikov , ML dri-devel , linux-arm-msm , Sean Paul Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Feb 20, 2020 at 05:33:09PM +0200, Ville Syrj=E4l=E4 wrote: > On Thu, Feb 20, 2020 at 11:24:20AM +0000, Emil Velikov wrote: > > On Wed, 19 Feb 2020 at 20:36, Ville Syrjala > > wrote: > > > > > > From: Ville Syrj=E4l=E4 > > > > > > The driver never sets mode->private_flags so copying > > > it back and forth is entirely pointless. Stop doing it. > > > > > > Also drop private_flags from the tracepoint. > > > > > > Cc: Rob Clark > > > Cc: Sean Paul > > > Cc: linux-arm-msm@vger.kernel.org > > > Cc: freedreno@lists.freedesktop.org > > > Signed-off-by: Ville Syrj=E4l=E4 > > = > > Perhaps the msm team has a WIP which makes use of it ? > = > Maybe if it's one of them five year projects. But anyways, = > with an atomic driver there are certainly better ways to > handle this. Yeah with atomic you have your display mode in drm_crtc_state, which you're subposed to subclass so that you can have terabytes of private state. At least in theory :-) ->private_flags was really only useful in pre-atomic drivers. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel