From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C440EC11D0C for ; Thu, 20 Feb 2020 18:17:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9EAEE2051A for ; Thu, 20 Feb 2020 18:17:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="ftQN6c90" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9EAEE2051A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E08706EE32; Thu, 20 Feb 2020 18:17:37 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 80FE76EE32 for ; Thu, 20 Feb 2020 18:17:36 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id z7so5653720wrl.13 for ; Thu, 20 Feb 2020 10:17:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=kkpaZ2U5TvafZIBZ+6Qq9oMo8RbsDcFqsliT+ioTLTA=; b=ftQN6c90iyAmLBcnuNpnl69tfFT3Cj/3isfIJ9d8yPvjDqIB3eJDwYhad4TU8VZnJ7 hUq6994zW04D0IwbHol8o8KbB5AI0UhVgxlvJwm0HeB+3c2X5Eqr5hbr7xibPx8G1x3Z 4IaovCDX0FaF5cV5BoQb2VWxfCI5KjSNFbB1g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=kkpaZ2U5TvafZIBZ+6Qq9oMo8RbsDcFqsliT+ioTLTA=; b=ob67gZxFXDRc+06Jjrj3VIoCBR9gpjtys8Po5rVXmZWwWsKhjdKt3qbuHT0QLuk/NZ la35o9168LWBBP2n4xdMj6ggBkovvl3A4B2MG9XBr3Gmgkb47RWaugHbzEjizDYkKj5b VnZivcC3UMmqSiGEIlzyoLLBvgdF0aBzgA74EVP8N1l7qgiPpRLRZKmO/cGi87hjQBaP oESKBTS87Y500QJ9+Rs6Oe6fs4wngN1Nza1t98dlXdXZR7G1PACuJbRIui5Q34SjfbzM qI6IDKsaTLC8JvFsB8z3tQ4xQB3WJwlNtPkV5JZ7ecaFlQ9pxHSG7zcZS1JieMCAK3S5 RlvQ== X-Gm-Message-State: APjAAAW7+KDs7wjZXcS4FNPVt/1FIDITrcFARGQa9LPN+5QwsFFtRgho +bFdp+xsvZ4HIXQ/XS6n4W+D0ToQqjk= X-Google-Smtp-Source: APXvYqwcjVOxifC7fZBqWBATi734nXV+ymS2y9QxBpvWBSfn1O+3yNEPLn4LEqg2n9AUEkDXdkLN+w== X-Received: by 2002:a05:6000:128a:: with SMTP id f10mr45618519wrx.116.1582222655246; Thu, 20 Feb 2020 10:17:35 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id j11sm187961wmi.3.2020.02.20.10.17.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2020 10:17:34 -0800 (PST) Date: Thu, 20 Feb 2020 19:17:32 +0100 From: Daniel Vetter To: Ville Syrjala Subject: Re: [Intel-gfx] [PATCH 07/12] drm: Shrink mode->type to u8 Message-ID: <20200220181732.GW2363188@phenom.ffwll.local> References: <20200219203544.31013-1-ville.syrjala@linux.intel.com> <20200219203544.31013-8-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200219203544.31013-8-ville.syrjala@linux.intel.com> X-Operating-System: Linux phenom 5.3.0-3-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Feb 19, 2020 at 10:35:39PM +0200, Ville Syrjala wrote: > From: Ville Syrj=E4l=E4 > = > We only have 7 bits defined for mode->type. Shrink the storage to u8. > = > Signed-off-by: Ville Syrj=E4l=E4 > --- > include/drm/drm_modes.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h > index 2bb2b1a8592a..5c20285cc317 100644 > --- a/include/drm/drm_modes.h > +++ b/include/drm/drm_modes.h > @@ -270,7 +270,7 @@ struct drm_display_mode { > * which are stuck around for hysterical raisins only. No one has an > * idea what they were meant for. Don't use. > */ > - unsigned int type; > + u8 type; Unfortunately DRM_MODE_TYPE_DRIVER is the largest and still in use, otherwise we could have cut off a few more bits here :-) Reviewed-by: Daniel Vetter > = > /** > * @clock: > -- = > 2.24.1 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel