Re: [PATCH] dt-bindings: arm-smmu: update the list of clocks

Robin Murphy
2020-02-26T13:55:22Z

[ /me fires off MAINTAINERS patch... ]

On 20/02/2020 9:02 pm, Matthias Kaehlcke wrote:
> On Thu, Feb 20, 2020 at 01:42:22PM +0530, Sharat Masetty wrote:
>> This patch adds a clock definition needed for powering on the GPU TBUs
>> and the GPU TCU.
>>
>> Signed-off-by: Sharat Masetty <smasetty@codeaurora.org>
>> ---
>> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>> index 6515dbe..235c0df 100644
>> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>> @@ -28,6 +28,7 @@ properties:
>> - enum:
>> - qcom,msm8996-smmu-v2
>> - qcom,msm8998-smmu-v2
>> + - qcom,sc7180-smmu-v2
>
> The addition of the compatible string isn't (directly) related with $subject,
> this should be done in a separate patch.

...or the patch should just be accurately described as "add support for
new variant X, which requires an additional clock Y".

And speaking of which, can anyone clarify how "TCU and TBU core clock"
manages to abbreviate to "mem_iface_clk"? I would have naively assumed
something like "core" would be most logical.

Robin.