From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D3BDC35646 for ; Fri, 21 Feb 2020 11:43:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1257222C4 for ; Fri, 21 Feb 2020 11:43:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1257222C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2E4CD6F425; Fri, 21 Feb 2020 11:43:15 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id A7F026F423; Fri, 21 Feb 2020 11:43:13 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Feb 2020 03:43:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,468,1574150400"; d="scan'208";a="225195571" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga007.jf.intel.com with SMTP; 21 Feb 2020 03:43:09 -0800 Received: by stinkbox (sSMTP sendmail emulation); Fri, 21 Feb 2020 13:43:09 +0200 Date: Fri, 21 Feb 2020 13:43:09 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Subject: Re: [Intel-gfx] [PATCH 00/12] drm: Put drm_display_mode on diet Message-ID: <20200221114309.GM13686@intel.com> References: <20200219203544.31013-1-ville.syrjala@linux.intel.com> <20200220142759.GA13686@intel.com> <20200220153426.GC13686@intel.com> <871rqoyy42.fsf@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <871rqoyy42.fsf@intel.com> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Kulkarni, Vandita" , Intel Graphics Development , Emil Velikov , ML dri-devel Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Feb 21, 2020 at 01:32:29PM +0200, Jani Nikula wrote: > On Thu, 20 Feb 2020, Ville Syrj=E4l=E4 wr= ote: > > Looks like getting rid of private_flags is going to be pretty > > straightforward. I'll post patches for that once this first series > > lands. > = > Going all in on crtc state? I suppose migrating away from private_flags > could easily start in i915 before that. Seems rather independent. > = > I guess it's __intel_get_crtc_scanline() and: > = > vblank =3D &crtc->base.dev->vblank[drm_crtc_index(&crtc->base)]; > mode =3D &vblank->hwmode; > = > if (mode->private_flags & I915_MODE_FLAG_GET_SCANLINE_FROM_TIMESTAMP) > = > that gives me the creeps in reviewing all that. > = > There's also [1] adding new uses for private_flags; I think there were > issues in getting at the right crtc state on some of those paths, but I > forget the exact details. Ideas? I'm just going to move them to the crtc_state and put a copy into the crtc itself for the vblank code. Pretty much a 1:1 replacement. = Saves me from having to think ;) -- = Ville Syrj=E4l=E4 Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel