From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCED7C3565B for ; Fri, 21 Feb 2020 19:03:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 757872071E for ; Fri, 21 Feb 2020 19:03:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="Y5e6uRfE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 757872071E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AFA726F4F8; Fri, 21 Feb 2020 19:03:13 +0000 (UTC) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 96BFE6F4F8 for ; Fri, 21 Feb 2020 19:03:11 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id e8so3210889wrm.5 for ; Fri, 21 Feb 2020 11:03:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=MJU4yIJ1OecX1mHUKDbEObOQjruIXSQ2ZxBhWrTtUGg=; b=Y5e6uRfE6sLzhHzmCheSW3DLIJ4hXkZ9XEIfb0xh9bXuteIGhYNEU0mHcCQLbsRBbq gx6pOJEzdbXGegCYo9FUpGTMA6UJUGZtiqKHWkukU4xEn119Y7DYpO9AIq2kYLsaU/MJ LiRE+LdAtDE7mSXCefIPi88xXWEvYwCveFd3U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MJU4yIJ1OecX1mHUKDbEObOQjruIXSQ2ZxBhWrTtUGg=; b=GObVChINmiS7vQSjM/e7YK1TrkmJqzU9/iNTTx7VZVPhp1RoM50iioXqM+7gwIQ1JH 9CHQexZvi11FHg0ymE/EbqVcU+A9U2WPGHAbgC3xQ42gEWF2kBLz526UC7GMUtFlUFpe 330Oqtvv7nyDzM35FaFXcXe8248RXiOc50mETHc0HNRPK3UU+CcO0M7zaCdzfMFA2Oxz tP3WWKs6USQuPXlMwGv575lf30Br8dY8yu4pZnHdlkV4PuckMaktl+cP+Ml8NQkbqUHm PL/jwwX3WOcN3sdPipJdPKs6nUhUji/0EOOFcNiIl7X6k8OFrQD6n9DLLrxoklsd6I+U C6jw== X-Gm-Message-State: APjAAAXr7QFMyHoeWv73oygPegUeVSc/DpcRd3BTfRwsLMkCP+43wEN+ Fvsn9sxY6s6hhxpDW0/u/9bL2A== X-Google-Smtp-Source: APXvYqyIsxVr3qhWNgflnJwy5Wr/iFuVcPl1oz3Oo8BPA8Ltenpsf+FYTeR4zPjyGhXyag79xnUhOQ== X-Received: by 2002:adf:e9d2:: with SMTP id l18mr1330674wrn.344.1582311790198; Fri, 21 Feb 2020 11:03:10 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id t12sm4985772wrq.97.2020.02.21.11.03.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Feb 2020 11:03:09 -0800 (PST) Date: Fri, 21 Feb 2020 20:03:07 +0100 From: Daniel Vetter To: Sam Ravnborg Subject: Re: [PATCH v2 3/4] drm/mgag200: Use simple encoder Message-ID: <20200221190307.GG2363188@phenom.ffwll.local> References: <20200218084815.2137-1-tzimmermann@suse.de> <20200218084815.2137-4-tzimmermann@suse.de> <20200220185642.GA20011@ravnborg.org> <3044661c-7552-e685-37b3-88865f97a991@suse.de> <20200221190057.GA27701@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200221190057.GA27701@ravnborg.org> X-Operating-System: Linux phenom 5.3.0-3-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, kraxel@redhat.com, Thomas Zimmermann , alexander.deucher@amd.com, spice-devel@lists.freedesktop.org, emil.velikov@collabora.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Feb 21, 2020 at 08:00:57PM +0100, Sam Ravnborg wrote: > Hi Thomas. > > On Fri, Feb 21, 2020 at 08:48:48AM +0100, Thomas Zimmermann wrote: > > Hi Sam > > > > thanks for reviewing the patch set. > > > > Am 20.02.20 um 19:56 schrieb Sam Ravnborg: > > > Hi Thomas. > > > > > > On Tue, Feb 18, 2020 at 09:48:14AM +0100, Thomas Zimmermann wrote: > > >> The mgag200 driver uses an empty implementation for its encoder. Replace > > >> the code with the generic simple encoder. > > >> > > >> v2: > > >> * rebase onto new simple-encoder interface > > >> > > >> Signed-off-by: Thomas Zimmermann > > >> --- > > >> drivers/gpu/drm/mgag200/mgag200_drv.h | 7 --- > > >> drivers/gpu/drm/mgag200/mgag200_mode.c | 61 ++------------------------ > > >> 2 files changed, 3 insertions(+), 65 deletions(-) > > >> > > >> diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.h b/drivers/gpu/drm/mgag200/mgag200_drv.h > > >> index aa32aad222c2..9bb9e8e14539 100644 > > >> --- a/drivers/gpu/drm/mgag200/mgag200_drv.h > > >> +++ b/drivers/gpu/drm/mgag200/mgag200_drv.h > > >> @@ -95,7 +95,6 @@ > > >> #define MATROX_DPMS_CLEARED (-1) > > >> > > >> #define to_mga_crtc(x) container_of(x, struct mga_crtc, base) > > >> -#define to_mga_encoder(x) container_of(x, struct mga_encoder, base) > > >> #define to_mga_connector(x) container_of(x, struct mga_connector, base) > > >> > > >> struct mga_crtc { > > >> @@ -110,12 +109,6 @@ struct mga_mode_info { > > >> struct mga_crtc *crtc; > > >> }; > > >> > > >> -struct mga_encoder { > > >> - struct drm_encoder base; > > >> - int last_dpms; > > >> -}; > > >> - > > >> - > > >> struct mga_i2c_chan { > > >> struct i2c_adapter adapter; > > >> struct drm_device *dev; > > > > > > Any particular reason why the drm_encoder is not embedded in struct > > > mga_device? > > > > > > I found it more elegant - like you did it for ast in the previous patch. > > > > I think I wanted something that uses drm_simple_encoder_create(). But I > > can change that. The embedded variant is indeed better. > > You should consider to drop drm_simple_encoder_create() until there > is a driver that really needs it. Yeah +1 on only the _init version. The create version really should use drmm_kzalloc I think, but we're not quite there yet :-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel