From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 182DBC35671 for ; Mon, 24 Feb 2020 13:14:32 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E700A20828 for ; Mon, 24 Feb 2020 13:14:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E700A20828 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 568686E4C4; Mon, 24 Feb 2020 13:14:31 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3A9E76E4C1; Mon, 24 Feb 2020 13:14:30 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Feb 2020 05:14:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,480,1574150400"; d="scan'208";a="255575855" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga002.jf.intel.com with SMTP; 24 Feb 2020 05:14:21 -0800 Received: by stinkbox (sSMTP sendmail emulation); Mon, 24 Feb 2020 15:14:20 +0200 Date: Mon, 24 Feb 2020 15:14:20 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Sam Ravnborg Subject: Re: [PATCH 04/12] drm: Nuke mode->vrefresh Message-ID: <20200224131420.GW13686@intel.com> References: <20200219203544.31013-1-ville.syrjala@linux.intel.com> <20200219203544.31013-5-ville.syrjala@linux.intel.com> <20200222123240.GD28287@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200222123240.GD28287@ravnborg.org> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , nouveau@lists.freedesktop.org, Guido =?iso-8859-1?Q?G=FCnther?= , dri-devel@lists.freedesktop.org, Andrzej Hajda , Thierry Reding , Laurent Pinchart , Thomas Hellstrom , Joonyoung Shim , Stefan Mavrodiev , Jerry Han , Ben Skeggs , VMware Graphics , Jagan Teki , Robert Chiras , Icenowy Zheng , Jonas Karlman , intel-gfx@lists.freedesktop.org, linux-amlogic@lists.infradead.org, Vincent Abriou , Jernej Skrabec , Purism Kernel Team , Seung-Woo Kim , Kyungmin Park Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, Feb 22, 2020 at 01:32:40PM +0100, Sam Ravnborg wrote: > Hi Ville. > = > Nice patch - and diffstat looks good: > > 63 files changed, 217 insertions(+), 392 deletions(-) > = > There is an item in the Documentation/gpu/todo.rst that > describes this. > Could you drop this from todo.rst in this patch too. Yeah, missed the TODO. Looks like there's one for hsync removal as well. > = > > diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c b/drivers/gpu/drm/mcde/mcd= e_dsi.c > > index bb6528b01cd0..6dca5344c0b3 100644 > > --- a/drivers/gpu/drm/mcde/mcde_dsi.c > > +++ b/drivers/gpu/drm/mcde/mcde_dsi.c > > @@ -538,7 +538,7 @@ static void mcde_dsi_setup_video_mode(struct mcde_d= si *d, > > */ > > /* (ps/s) / (pixels/s) =3D ps/pixels */ > > pclk =3D DIV_ROUND_UP_ULL(1000000000000, > > - (mode->vrefresh * mode->htotal * mode->vtotal)); > > + (drm_mode_vrefresh(mode) * mode->htotal * mode->vtotal)); > > dev_dbg(d->dev, "picoseconds between two pixels: %llu\n", > > pclk); > > = > = > This just caught my eye while browsing the patch. > It looks like a backward way to get the clock. Yep. I'll cook up a patch to switch this to ->clock. > = > But patch is fine, it was just a drive-by comment. > = > Whole patch is: > Reviewed-by: Sam Ravnborg > (with or without removal of todo item added) > = > Sam -- = Ville Syrj=E4l=E4 Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel