From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53F02C10F25 for ; Fri, 6 Mar 2020 18:23:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2B8B920675 for ; Fri, 6 Mar 2020 18:23:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="by/45/SC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B8B920675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D05D46E44A; Fri, 6 Mar 2020 18:23:19 +0000 (UTC) Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0104A6EBC1 for ; Fri, 6 Mar 2020 18:23:18 +0000 (UTC) Received: by mail-pf1-x444.google.com with SMTP id i13so1505718pfe.3 for ; Fri, 06 Mar 2020 10:23:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=44PG1bYEGaFCj7THr4F0ZjhE7QAfJ0hXnxjBIr00KfM=; b=by/45/SCHs0YbsDY9OV5TYWdxu8JGIz+fubFVMggvBKB7TymlB+dvgRPY6nAR687JW 9HN8ckHtJtDM9m/ei+KSwgp8yCzd64UpRP1LhMKabpG05hLYFPJ4Ri8m2Ue0xpY5moyR NiwMeZerQ4YeNwKYFEq4+30YwPQnddAWW3HLQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=44PG1bYEGaFCj7THr4F0ZjhE7QAfJ0hXnxjBIr00KfM=; b=AkYt8dUStTkCpLeansCYs8LzyWUJ57ljP+0wolf2QzGXIaE57UoEKwfGi6ZqPMO6U1 1mive2hZd104fK2kgBUaK4Ik/22DSAZ7jT5XkjFf0ybgkAynVvzVnY9McbhKsF99LoZv 3+YJ2cVoOQCOKOc+7ejqEyqOy8Gm0qBoih3KgkkWnEKUWnFIj2i1o8em72alaLjs9l5K FmDuHbvYS+L+Kecw5j6rj0+uJijCHqBKjQUhIaehppcq+fJdsMyln7jM/YYzz4fOLZWA co5Jl8GQnoNudr7lIuyGSZ8EL2L7tlmhmPFY7IVWr9s93O665mrwP8eImf0HrdlQba40 oakQ== X-Gm-Message-State: ANhLgQ2AT7FtGhQV7aO+Non4+sE28O7Lkf2wB8AjBaWhO+cLr6OXPCej 3oZqUzwqxZBSVQOxrb21Cmk3UQ== X-Google-Smtp-Source: ADFU+vsux5P/Cbqz3h1NLmhvth9Dl9JbIb2Z68tegMHcJlDiGiJVWbhl2y3h9Uq+Iym0hSXfr6TDpg== X-Received: by 2002:a63:180c:: with SMTP id y12mr4685461pgl.120.1583518998432; Fri, 06 Mar 2020 10:23:18 -0800 (PST) Received: from localhost ([2620:15c:202:1:4fff:7a6b:a335:8fde]) by smtp.gmail.com with ESMTPSA id b2sm10004866pjc.40.2020.03.06.10.23.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Mar 2020 10:23:17 -0800 (PST) Date: Fri, 6 Mar 2020 10:23:15 -0800 From: Matthias Kaehlcke To: Harigovindan P Subject: Re: [PATCH v4 2/2] drm/panel: add support for rm69299 visionox panel driver Message-ID: <20200306182315.GV24720@google.com> References: <20200306103628.8998-1-harigovi@codeaurora.org> <20200306103628.8998-3-harigovi@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200306103628.8998-3-harigovi@codeaurora.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sean@poorly.run, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, seanpaul@chromium.org, freedreno@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Fri, Mar 06, 2020 at 04:06:28PM +0530, Harigovindan P wrote: > Add support for Visionox panel driver. > > Signed-off-by: Harigovindan P > --- > > Changes in v2: > - Dropping redundant space in Kconfig(Sam Ravnborg). > - Changing structure for include files(Sam Ravnborg). > - Removing backlight related code and functions(Sam Ravnborg). > - Removing repeated printing of error message(Sam Ravnborg). > - Adding drm_connector as an argument for get_modes function. > Changes in v3: > - Adding arguments for drm_panel_init to support against mainline. > Changes in v4: > - Removing error messages from regulator_set_load. > - Removing dev struct entry. > - Removing checks. > - Dropping empty comment lines. > > drivers/gpu/drm/panel/Kconfig | 8 + > drivers/gpu/drm/panel/Makefile | 1 + > .../gpu/drm/panel/panel-visionox-rm69299.c | 322 ++++++++++++++++++ > 3 files changed, 331 insertions(+) > create mode 100644 drivers/gpu/drm/panel/panel-visionox-rm69299.c > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index ae44ac2ec106..7b696f304a99 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -389,6 +389,14 @@ config DRM_PANEL_TRULY_NT35597_WQXGA > Say Y here if you want to enable support for Truly NT35597 WQXGA Dual DSI > Video Mode panel > > +config DRM_PANEL_VISIONOX_RM69299 > + tristate "Visionox RM69299" > + depends on OF > + depends on DRM_MIPI_DSI > + help > + Say Y here if you want to enable support for Visionox > + RM69299 DSI Video Mode panel. > + > config DRM_PANEL_XINPENG_XPP055C272 > tristate "Xinpeng XPP055C272 panel driver" > depends on OF > diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile > index 7c4d3c581fd4..9f11d067a6b2 100644 > --- a/drivers/gpu/drm/panel/Makefile > +++ b/drivers/gpu/drm/panel/Makefile > @@ -41,4 +41,5 @@ obj-$(CONFIG_DRM_PANEL_TPO_TD028TTEC1) += panel-tpo-td028ttec1.o > obj-$(CONFIG_DRM_PANEL_TPO_TD043MTEA1) += panel-tpo-td043mtea1.o > obj-$(CONFIG_DRM_PANEL_TPO_TPG110) += panel-tpo-tpg110.o > obj-$(CONFIG_DRM_PANEL_TRULY_NT35597_WQXGA) += panel-truly-nt35597.o > +obj-$(CONFIG_DRM_PANEL_VISIONOX_RM69299) += panel-visionox-rm69299.o > obj-$(CONFIG_DRM_PANEL_XINPENG_XPP055C272) += panel-xinpeng-xpp055c272.o > diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c b/drivers/gpu/drm/panel/panel-visionox-rm69299.c > new file mode 100644 > index 000000000000..eb15dca15398 > --- /dev/null > +++ b/drivers/gpu/drm/panel/panel-visionox-rm69299.c > @@ -0,0 +1,322 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) 2019, The Linux Foundation. All rights reserved. > + */ > + > +#include > +#include > +#include > +#include > +#include > + > +#include