dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Kamlesh Gurudasani <kamlesh.gurudasani@gmail.com>
Cc: David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/tiny: fix sparse warning: incorrect type in assignment (different base types)
Date: Sat, 14 Mar 2020 08:34:49 +0100	[thread overview]
Message-ID: <20200314073449.GB5783@ravnborg.org> (raw)
In-Reply-To: <1583684084-4694-1-git-send-email-kamlesh.gurudasani@gmail.com>

Hi Kamlesh

On Sun, Mar 08, 2020 at 09:44:44PM +0530, Kamlesh Gurudasani wrote:
> This fixes the following sparse warning:
> 
> drivers/gpu/drm/tiny/ili9486.c:61:16: sparse: sparse: incorrect type in assignment (different base types)
> drivers/gpu/drm/tiny/ili9486.c:61:16: sparse:    expected unsigned short [usertype]
> drivers/gpu/drm/tiny/ili9486.c:61:16: sparse:    got restricted __be16 [usertype]
> drivers/gpu/drm/tiny/ili9486.c:71:32: sparse: sparse: incorrect type in assignment (different base types)
> drivers/gpu/drm/tiny/ili9486.c:71:32: sparse:    expected unsigned short [usertype]
> drivers/gpu/drm/tiny/ili9486.c:71:32: sparse:    got restricted __be16 [usertype]
> 
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Kamlesh Gurudasani <kamlesh.gurudasani@gmail.com>

Thanks. Applied and pushed to drm-misc-next.

	Sam

> ---
>  drivers/gpu/drm/tiny/ili9486.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tiny/ili9486.c b/drivers/gpu/drm/tiny/ili9486.c
> index 5084b38..532560ae 100644
> --- a/drivers/gpu/drm/tiny/ili9486.c
> +++ b/drivers/gpu/drm/tiny/ili9486.c
> @@ -45,7 +45,7 @@ static int waveshare_command(struct mipi_dbi *mipi, u8 *cmd, u8 *par,
>  	void *data = par;
>  	u32 speed_hz;
>  	int i, ret;
> -	u16 *buf;
> +	__be16 *buf;
>  
>  	buf = kmalloc(32 * sizeof(u16), GFP_KERNEL);
>  	if (!buf)
> -- 
> 2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2020-03-14  7:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-08 16:14 [PATCH] drm/tiny: fix sparse warning: incorrect type in assignment (different base types) Kamlesh Gurudasani
2020-03-14  7:34 ` Sam Ravnborg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200314073449.GB5783@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kamlesh.gurudasani@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox