From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E353FC0044D for ; Mon, 16 Mar 2020 10:03:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B8DB42051A for ; Mon, 16 Mar 2020 10:03:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="B2USPv5K" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8DB42051A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 91DC56E3BB; Mon, 16 Mar 2020 10:03:45 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9E4016E3BB for ; Mon, 16 Mar 2020 10:03:44 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id f11so3574084wrp.8 for ; Mon, 16 Mar 2020 03:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=AcRSHSdiOyqt1hfLF4oq0FUotM9AVIQhsg3GLo4T9TA=; b=B2USPv5KbpHIGhkfFrJQCuShva+t1YuJ9supVSZJi7SmeRkQ+Ok1KYee9YtHwBKrRJ yl9Kx1VkDMtstyjHEa8hNZcH1bbmZ1PSKNLF8Wfi1VdxCwTEMpEDz/+R+LbQcMd387Ub aRmOwj1y8nIqpvf7WZqqHh9pJdmqcn05LP20o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AcRSHSdiOyqt1hfLF4oq0FUotM9AVIQhsg3GLo4T9TA=; b=rdj1kh6OhGi0f/VcdLd++xEA88Jtn6lO5dWhDCgRCDo8i7hJAEKd+9+MGeHZ4C39rk +D5aCMEhXvDTGEntlgdtujD2kqqIdVC4A86ZOQ6pIkZDVkWfzXk+IwcpTE0c7bAadeaI Poiehx6M75O7EKtQQd3efEQD4xNEgoA3UCz94DeqgdDRsmNfqekWZBBFFXOqMwnT+j1A M8CrascFVatK1Dcq+f9+DS1PScA5uorhWMmc0EyxPEhoRWASg0ozMFM0nWD8xmEG1baJ dm2y5lIr9iPboQI0pIVuyWEmQvcK6ODAjVoA+9BJGyq6fXbywIO/Qh/lnu8IEOAaB3Za TB6A== X-Gm-Message-State: ANhLgQ3nyGEjN/MnnEdoI3Bh4+FrN3TZqS0BY2tYk0QHRFh7mN7HCz0t 7AMEGrhXhnj6sL36JcW6vB31LA== X-Google-Smtp-Source: ADFU+vtSU5e+h6WkNw2sJ6apKMD24Minuj5xZyJFTkMlwMWGN+xpvYH0bJgEK7m2Qk/CueY//LMKFg== X-Received: by 2002:adf:fc81:: with SMTP id g1mr36703578wrr.410.1584353023220; Mon, 16 Mar 2020 03:03:43 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id v2sm23290034wme.2.2020.03.16.03.03.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2020 03:03:42 -0700 (PDT) Date: Mon, 16 Mar 2020 11:03:40 +0100 From: Daniel Vetter To: Chris Wilson Subject: Re: [PATCH] drm: Mark up racy check of drm_gem_object.handle_count Message-ID: <20200316100340.GL2363188@phenom.ffwll.local> References: <20200309120151.7675-1-chris@chris-wilson.co.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200309120151.7675-1-chris@chris-wilson.co.uk> X-Operating-System: Linux phenom 5.3.0-3-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mika.kuoppala@linux.intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Mar 09, 2020 at 12:01:51PM +0000, Chris Wilson wrote: > [ 1715.899800] BUG: KCSAN: data-race in drm_gem_handle_create_tail / drm_gem_object_handle_put_unlocked > [ 1715.899838] > [ 1715.899861] write to 0xffff8881830f3604 of 4 bytes by task 7834 on cpu 1: > [ 1715.899896] drm_gem_handle_create_tail+0x62/0x250 > [ 1715.899927] drm_gem_open_ioctl+0xc1/0x160 > [ 1715.899956] drm_ioctl_kernel+0xe4/0x120 > [ 1715.899981] drm_ioctl+0x297/0x4c7 > [ 1715.900003] ksys_ioctl+0x89/0xb0 > [ 1715.900027] __x64_sys_ioctl+0x42/0x60 > [ 1715.900052] do_syscall_64+0x6e/0x2c0 > [ 1715.900079] entry_SYSCALL_64_after_hwframe+0x44/0xa9 > [ 1715.900100] > [ 1715.900119] read to 0xffff8881830f3604 of 4 bytes by task 8137 on cpu 0: > [ 1715.900149] drm_gem_object_handle_put_unlocked+0x31/0x130 > [ 1715.900180] drm_gem_object_release_handle+0x93/0xe0 > [ 1715.900208] drm_gem_handle_delete+0x7b/0xe0 > [ 1715.900235] drm_gem_close_ioctl+0x61/0x80 > [ 1715.900264] drm_ioctl_kernel+0xe4/0x120 > [ 1715.900291] drm_ioctl+0x297/0x4c7 > [ 1715.900316] ksys_ioctl+0x89/0xb0 > [ 1715.900340] __x64_sys_ioctl+0x42/0x60 > [ 1715.900363] do_syscall_64+0x6e/0x2c0 > [ 1715.900388] entry_SYSCALL_64_after_hwframe+0x44/0xa9 I'm impressed. The dream that we all get replaced by some scripts might be real :-) > Signed-off-by: Chris Wilson Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/drm_gem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c > index a9e4a610445a..37627d06fb06 100644 > --- a/drivers/gpu/drm/drm_gem.c > +++ b/drivers/gpu/drm/drm_gem.c > @@ -218,7 +218,7 @@ drm_gem_object_handle_put_unlocked(struct drm_gem_object *obj) > struct drm_device *dev = obj->dev; > bool final = false; > > - if (WARN_ON(obj->handle_count == 0)) > + if (WARN_ON(READ_ONCE(obj->handle_count) == 0)) > return; > > /* > -- > 2.20.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel