From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA538C0044D for ; Mon, 16 Mar 2020 13:28:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99E0220575 for ; Mon, 16 Mar 2020 13:28:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99E0220575 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 044AB6E43A; Mon, 16 Mar 2020 13:28:59 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1E92C6E43A for ; Mon, 16 Mar 2020 13:28:56 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 1788080475; Mon, 16 Mar 2020 14:28:46 +0100 (CET) Date: Mon, 16 Mar 2020 14:28:44 +0100 From: Sam Ravnborg To: Mark Brown Subject: Re: [PATCH v1 02/36] dt-bindings: spi: support non-spi bindings as SPI slaves Message-ID: <20200316132844.GA22822@ravnborg.org> References: <20200315134416.16527-1-sam@ravnborg.org> <20200315134416.16527-3-sam@ravnborg.org> <20200316120239.GC5010@sirena.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200316120239.GC5010@sirena.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=XpTUx2N9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=vD5-ug2-evzQM-DbIjUA:9 a=CjuIK1q_8ugA:10 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , Nikolaus Schaller , Jonathan Bakker , Sandeep Panda , dri-devel@lists.freedesktop.org, Paul Cercueil , Andrzej Hajda , Thierry Reding , Laurent Pinchart , Chris Zhong , Marco Franchi , Stefan Mavrodiev , Jerry Han , Hoegeun Kwon , Tony Lindgren , Nickey Yang , Tomi Valkeinen , Jagan Teki , Robert Chiras , Vinay Simha BN , Marek Belisko , Heiko Schocher , Brian Masney , devicetree@vger.kernel.org, Guido Gunther , Alexandre Courbot , Werner Johansson , Purism Kernel Team , Peter Ujfalusi , Lin Huang , Douglas Anderson , linux-spi@vger.kernel.org, Peter Rosin Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Mark. On Mon, Mar 16, 2020 at 12:02:41PM +0000, Mark Brown wrote: > On Sun, Mar 15, 2020 at 02:43:42PM +0100, Sam Ravnborg wrote: > > > Independent bindings can be SPI slaves which for example is > > the case for several panel bindings. > > What is an "independent binding"? For several panels we have device trees that looks like this: spi { #address-cells = <1>; #size-cells = <0>; panel@0 { compatible = "kingdisplay,kd035g6-54nt"; reg = <0>; spi-max-frequency = <3125000>; spi-3wire; spi-cs-high; ... The bindings are child of the spi controller node, but not specified in the same binding file as the spi controller node. A lot of bindings repeats the descriptions of (some of) the pi-slave properties. To avoid introducing yet another set of redundant and maybe incomplete SPI slave property descriptions I moved the relevant properties from spi-controller.yaml to spi-slave.yaml. So SPI slaves can now reference spi-slave.yaml to get access to the SPI slave properties - and the copies can be avoided. Likewise spi-controller.yml now references spi-slave.yaml. This was the best way I saw it could be done. This approach is used in several bindings in this patch set. Sam _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel