From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FCA9C2BB1D for ; Mon, 16 Mar 2020 16:35:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1CB76206C0 for ; Mon, 16 Mar 2020 16:35:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CB76206C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 419696E22E; Mon, 16 Mar 2020 16:35:41 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id D55846E22E for ; Mon, 16 Mar 2020 16:35:40 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 145371FB; Mon, 16 Mar 2020 09:35:40 -0700 (PDT) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 931FB3F534; Mon, 16 Mar 2020 09:35:39 -0700 (PDT) Date: Mon, 16 Mar 2020 16:35:38 +0000 From: Mark Brown To: Sam Ravnborg Subject: Re: [PATCH v1 02/36] dt-bindings: spi: support non-spi bindings as SPI slaves Message-ID: <20200316163538.GJ5010@sirena.org.uk> References: <20200315134416.16527-1-sam@ravnborg.org> <20200315134416.16527-3-sam@ravnborg.org> <20200316120239.GC5010@sirena.org.uk> <20200316132844.GA22822@ravnborg.org> MIME-Version: 1.0 In-Reply-To: <20200316132844.GA22822@ravnborg.org> X-Cookie: I thought YOU silenced the guard! User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , Nikolaus Schaller , Jonathan Bakker , Sandeep Panda , dri-devel@lists.freedesktop.org, Paul Cercueil , Andrzej Hajda , Thierry Reding , Laurent Pinchart , Chris Zhong , Marco Franchi , Stefan Mavrodiev , Jerry Han , Hoegeun Kwon , Tony Lindgren , Nickey Yang , Tomi Valkeinen , Jagan Teki , Robert Chiras , Vinay Simha BN , Marek Belisko , Heiko Schocher , Brian Masney , devicetree@vger.kernel.org, Guido Gunther , Alexandre Courbot , Werner Johansson , Purism Kernel Team , Peter Ujfalusi , Lin Huang , Douglas Anderson , linux-spi@vger.kernel.org, Peter Rosin Content-Type: multipart/mixed; boundary="===============1925844773==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --===============1925844773== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3MMMIZFJzhAsRj/+" Content-Disposition: inline --3MMMIZFJzhAsRj/+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Mar 16, 2020 at 02:28:44PM +0100, Sam Ravnborg wrote: > On Mon, Mar 16, 2020 at 12:02:41PM +0000, Mark Brown wrote: > > On Sun, Mar 15, 2020 at 02:43:42PM +0100, Sam Ravnborg wrote: > > > Independent bindings can be SPI slaves which for example is > > > the case for several panel bindings. > > What is an "independent binding"? > For several panels we have device trees that looks like this: So what you're trying to do is define a generic class for SPI slaves which are just normal children of SPI nodes? I really can't get to there from your changelog so we need some work there - in particular "non-spi bindings" is *very* confusing as as far as I can see these are bindings for SPI devices. > The bindings are child of the spi controller node, but not specified > in the same binding file as the spi controller node. Of course not, this how all buses work isn't it? > So SPI slaves can now reference spi-slave.yaml to get access to > the SPI slave properties - and the copies can be avoided. > Likewise spi-controller.yml now references spi-slave.yaml. > This was the best way I saw it could be done. Rob didn't do the binding conversion but he did review it - I'm a bit surprised that there's issues here? Also shouldn't there be some constraint that these devices have to be the child of a SPI controller or something? Just including a file doesn't look right for something like class definition. --3MMMIZFJzhAsRj/+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5vqtkACgkQJNaLcl1U h9D9Jgf7BDsLTp/6OG/zIxXw5pr33X7ZgheGEgzqYDaH/LK45lJUNdpYb2eTABDv Jg1MzeqqPxP1ppvEvmo3VRdudgU+m+hKTtHAbIwVnxY32nmSAweUnDySfKWCNl/1 LZXTrA6hFaFU4AmTj3iCIbNe4mHY9jt5f+DZN/31ZNr43VGfjXvqpSei/exRu+/i Hnh0w0MvGQVHfD3V6AMGlaFrhLO59ZR6KPxXfQCGlJRfCuAgrjgJUK+0KSGsDf48 oTef8wJIjDm4r8LCFdN10GzODwdcLE6HGGzWl8pB1sEfKP4p4tFtWOTh/JIyTQZM dHvwfKrDy65fP8P6ytpHy352wV8kQw== =nY4o -----END PGP SIGNATURE----- --3MMMIZFJzhAsRj/+-- --===============1925844773== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1925844773==--