Re: [PATCH v1 13/36] dt-bindings: display: convert kingdisplay,kd035g6-54nt to DT Schema

From: Paul Cercueil <paul@crapouillou.net>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
	Nikolaus Schaller <hns@goldelico.com>,
	Jonathan Bakker <xc-racer2@live.ca>,
	Sandeep Panda <spanda@codeaurora.org>,
	dri-devel@lists.freedesktop.org,
	Peter Ujfalusi <peter.ujfalusi@ti.com>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Chris Zhong <zyw@rock-chips.com>,
	Marco Franchi <marco.franchi@nxp.com>,
	Stefan Mavrodiev <stefan@olimex.com>,
	Jerry Han <hanxu5@huaqin.corp-partner.google.com>,
	Hoegeun Kwon <hoegeun.kwon@samsung.com>,
	Tony Lindgren <tony@atomide.com>,
	Nickey Yang <nickey.yang@rock-chips.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Jagan Teki <jagan@amarulasolutions.com>,
	Robert Chiras <robert.chiras@nxp.com>,
	Vinay Simha BN <simhavcs@gmail.com>,
	Marek Belisko <marek@goldelico.com>, Heiko Schocher <hs@denx.de>,
	Brian Masney <masneyb@onstation.org>,
	devicetree@vger.kernel.org, Guido Gunther <agx@sigxcpu.org>,
	Mark Brown <broonie@kernel.org>,
	Alexandre Courbot <acourbot@nvidia.com>,
	Werner Johansson <werner.johansson@sonymobile.com>,
	Purism Kernel Team <kernel@puri.sm>,
	Lin Huang <hl@rock-chips.com>,
	Douglas Anderson <dianders@chromium.org>,
	linux-spi@vger.kernel.org, Peter Rosin <peda@axentia.se>
Subject: Re: [PATCH v1 13/36] dt-bindings: display: convert kingdisplay,kd035g6-54nt to DT Schema
Date: Tue, 17 Mar 2020 12:32:07 +0100	[thread overview]
Message-ID: <20200317141650.8B3F16E5C5@gabe.freedesktop.org> (raw)
In-Reply-To: <20200315134416.16527-14-sam@ravnborg.org>

Hi Sam,

Le dim. 15 mars 2020 à 14:43, Sam Ravnborg <sam@ravnborg.org> a écrit 
:
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>

Reviewed-by: Paul Cercueil <paul@crapouillou.net>

Cheers,
-Paul

> Cc: Paul Cercueil <paul@crapouillou.net>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> ---
>  .../panel/kingdisplay,kd035g6-54nt.txt        | 42 -------------
>  .../panel/kingdisplay,kd035g6-54nt.yaml       | 60 
> +++++++++++++++++++
>  2 files changed, 60 insertions(+), 42 deletions(-)
>  delete mode 100644 
> Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.txt
>  create mode 100644 
> Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml
> 
> diff --git 
> a/Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.txt 
> b/Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.txt
> deleted file mode 100644
> index fa9596082e44..000000000000
> --- 
> a/Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.txt
> +++ /dev/null
> @@ -1,42 +0,0 @@
> -King Display KD035G6-54NT 3.5" (320x240 pixels) 24-bit TFT LCD panel
> -
> -Required properties:
> -- compatible: should be "kingdisplay,kd035g6-54nt"
> -- power-supply: See panel-common.txt
> -- reset-gpios: See panel-common.txt
> -
> -Optional properties:
> -- backlight: see panel-common.txt
> -
> -The generic bindings for the SPI slaves documented in [1] also apply.
> -
> -The device node can contain one 'port' child node with one child
> -'endpoint' node, according to the bindings defined in [2]. This
> -node should describe panel's video bus.
> -
> -[1]: Documentation/devicetree/bindings/spi/spi-bus.txt
> -[2]: Documentation/devicetree/bindings/graph.txt
> -
> -Example:
> -
> -&spi {
> -	panel@0 {
> -		compatible = "kingdisplay,kd035g6-54nt";
> -		reg = <0>;
> -
> -		spi-max-frequency = <3125000>;
> -		spi-3wire;
> -		spi-cs-high;
> -
> -		reset-gpios = <&gpe 2 GPIO_ACTIVE_LOW>;
> -
> -		backlight = <&backlight>;
> -		power-supply = <&ldo6>;
> -
> -		port {
> -			panel_input: endpoint {
> -				remote-endpoint = <&panel_output>;
> -			};
> -		};
> -	};
> -};
> diff --git 
> a/Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml 
> b/Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml
> new file mode 100644
> index 000000000000..31fc63294a9f
> --- /dev/null
> +++ 
> b/Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml
> @@ -0,0 +1,60 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: 
> http://devicetree.org/schemas/display/panel/kingdisplay,kd035g6-54nt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: King Display KD035G6-54NT 3.5" (320x240 pixels) 24-bit TFT 
> LCD panel
> +
> +maintainers:
> +  - Paul Cercueil <paul@crapouillou.net>
> +
> +allOf:
> +  - $ref: ../../spi/spi-slave.yaml#
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: kingdisplay,kd035g6-54nt
> +
> +  backlight: true
> +  port: true
> +  power-supply: true
> +  reg: true
> +  reset-gpios: true
> +
> +required:
> +  - compatible
> +  - power-supply
> +  - reset-gpios
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        panel@0 {
> +            compatible = "kingdisplay,kd035g6-54nt";
> +            reg = <0>;
> +
> +            spi-max-frequency = <3125000>;
> +            spi-3wire;
> +            spi-cs-high;
> +
> +            reset-gpios = <&gpe 2 GPIO_ACTIVE_LOW>;
> +
> +            backlight = <&backlight>;
> +            power-supply = <&ldo6>;
> +
> +            port {
> +                panel_input: endpoint {
> +                    remote-endpoint = <&panel_output>;
> +                };
> +            };
> +        };
> +    };
> +
> +...
> --
> 2.20.1
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel