From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3E8AC2BB1D for ; Tue, 17 Mar 2020 19:23:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE33820753 for ; Tue, 17 Mar 2020 19:23:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="dVdK3MFx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE33820753 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 362296E81C; Tue, 17 Mar 2020 19:23:48 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6043D6E81C for ; Tue, 17 Mar 2020 19:23:47 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 998C1F9; Tue, 17 Mar 2020 20:23:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1584473025; bh=0im86SX1I5lqjQ+Li/yFgTxWIJKa9bcKPIK5SxM07R8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dVdK3MFx4bUhjO+7M4I7R1qsctbehUyJge8k9kICwJnvzoUysoccB/UQpzy9a4kjK 5cpf9ZQUBabhcMKmPoFnt6qa0HoHL/WGL+OItoPfrpryhtfOLKqCHG/WQOkME8+5cc mHao00b5l03Ebt5cifWZZR89jP6+i2gFd/IaMv6Q= Date: Tue, 17 Mar 2020 21:23:40 +0200 From: Laurent Pinchart To: Sam Ravnborg Subject: Re: [PATCH v1 2/3] drm/panel-simple: drop use of data-mapping property Message-ID: <20200317192340.GC2527@pendragon.ideasonboard.com> References: <20200314153047.2486-1-sam@ravnborg.org> <20200314153047.2486-3-sam@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200314153047.2486-3-sam@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thierry Reding , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Sam, Thank you for the patch. On Sat, Mar 14, 2020 at 04:30:46PM +0100, Sam Ravnborg wrote: > The "data-mapping" property may not be the best way to describe the > interface between panels and display interfaces. > Drop use of in the panel-simple driver, so we have time to find > the right way to describe this interface. For the same reason as for patch 1/3, Reviewed-by: Laurent Pinchart > Signed-off-by: Sam Ravnborg > Cc: Thierry Reding > Cc: Rob Herring > Cc: Maxime Ripard > Cc: Laurent Pinchart > --- > drivers/gpu/drm/panel/panel-simple.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 0ce81b1f36af..3ad828eaefe1 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -361,7 +361,6 @@ static int panel_dpi_probe(struct device *dev, > struct panel_desc *desc; > unsigned int bus_flags; > struct videomode vm; > - const char *mapping; > int ret; > > np = dev->of_node; > @@ -386,16 +385,6 @@ static int panel_dpi_probe(struct device *dev, > of_property_read_u32(np, "width-mm", &desc->size.width); > of_property_read_u32(np, "height-mm", &desc->size.height); > > - of_property_read_string(np, "data-mapping", &mapping); > - if (!strcmp(mapping, "rgb24")) > - desc->bus_format = MEDIA_BUS_FMT_RGB888_1X24; > - else if (!strcmp(mapping, "rgb565")) > - desc->bus_format = MEDIA_BUS_FMT_RGB565_1X16; > - else if (!strcmp(mapping, "bgr666")) > - desc->bus_format = MEDIA_BUS_FMT_RGB666_1X18; > - else if (!strcmp(mapping, "lvds666")) > - desc->bus_format = MEDIA_BUS_FMT_RGB666_1X24_CPADHI; > - > /* Extract bus_flags from display_timing */ > bus_flags = 0; > vm.flags = timing->flags; -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel