Re: [Intel-gfx] [PATCH 03/18] drm/i915/display/ddi: Prefer drm_WARN* over WARN*

From: kbuild test robot <lkp@intel.com>
To: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
Cc: kbuild-all@lists.01.org, "David Airlie" <airlied@linux.ie>,
	intel-gfx@lists.freedesktop.org,
	"Lucas De Marchi" <lucas.demarchi@intel.com>,
	dri-devel@lists.freedesktop.org,
	clang-built-linux@googlegroups.com,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"José Roberto de Souza" <jose.souza@intel.com>
Subject: Re: [Intel-gfx] [PATCH 03/18] drm/i915/display/ddi: Prefer drm_WARN* over WARN*
Date: Tue, 7 Apr 2020 04:21:38 +0800	[thread overview]
Message-ID: <202004070411.usUwgu3N%lkp@intel.com> (raw)
In-Reply-To: <20200406112800.23762-4-pankaj.laxminarayan.bharadiya@intel.com>

[-- Attachment #1: Type: text/plain, Size: 2556 bytes --]

Hi Pankaj,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20200406]
[cannot apply to v5.6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Pankaj-Bharadiya/Prefer-drm_WARN-over-WARN/20200406-210932
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-f002-20200406 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project a43e23360657e3df82af6b96b403d1a5a3174744)
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/i915/display/intel_ddi.c:3624:14: error: use of undeclared identifier 'state'
           drm_WARN_ON(state->base.dev, crtc_state->has_pch_encoder);
                       ^
>> drivers/gpu/drm/i915/display/intel_ddi.c:3624:14: error: use of undeclared identifier 'state'
   2 errors generated.

vim +/state +3624 drivers/gpu/drm/i915/display/intel_ddi.c

  3619	
  3620	static void intel_enable_ddi(struct intel_encoder *encoder,
  3621				     const struct intel_crtc_state *crtc_state,
  3622				     const struct drm_connector_state *conn_state)
  3623	{
> 3624		drm_WARN_ON(state->base.dev, crtc_state->has_pch_encoder);
  3625	
  3626		intel_enable_pipe(crtc_state);
  3627	
  3628		intel_crtc_vblank_on(crtc_state);
  3629	
  3630		if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI))
  3631			intel_enable_ddi_hdmi(encoder, crtc_state, conn_state);
  3632		else
  3633			intel_enable_ddi_dp(encoder, crtc_state, conn_state);
  3634	
  3635		/* Enable hdcp if it's desired */
  3636		if (conn_state->content_protection ==
  3637		    DRM_MODE_CONTENT_PROTECTION_DESIRED)
  3638			intel_hdcp_enable(to_intel_connector(conn_state->connector),
  3639					  crtc_state->cpu_transcoder,
  3640					  (u8)conn_state->hdcp_content_type);
  3641	}
  3642	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33686 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel