From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FCBBC2BA1A for ; Tue, 7 Apr 2020 15:52:01 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D3B020730 for ; Tue, 7 Apr 2020 15:52:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D3B020730 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CFABF6E8A7; Tue, 7 Apr 2020 15:52:00 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5B14989C55 for ; Tue, 7 Apr 2020 15:51:59 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 07C9380462; Tue, 7 Apr 2020 17:51:56 +0200 (CEST) Date: Tue, 7 Apr 2020 17:51:55 +0200 From: Sam Ravnborg To: Daniel Vetter Subject: Re: [PATCH v2 3/3] drm/writeback: wire drm_writeback.h to kernel-doc Message-ID: <20200407155155.GB24075@ravnborg.org> References: <20200406194746.26433-1-sam@ravnborg.org> <20200406194746.26433-4-sam@ravnborg.org> <20200407080851.GH3456981@phenom.ffwll.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200407080851.GH3456981@phenom.ffwll.local> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=XpTUx2N9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=P1BnusSwAAAA:8 a=7CQSdrXTAAAA:8 a=VwQbUJbxAAAA:8 a=25-AhOLfAAAA:8 a=JbJgYhgYaR88VrxWCWoA:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=D0XLA9XvdZm18NrgonBM:22 a=a-qgeE7W1pNrGK8U0ZQC:22 a=AjGcO6oz07-iQ99wixmX:22 a=dnuY3_Gu-P7Vi9ynLKQe:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Pinchart , David Airlie , Daniel Vetter , Liviu Dudau , dri-devel@lists.freedesktop.org, Thomas Zimmermann Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Apr 07, 2020 at 10:08:51AM +0200, Daniel Vetter wrote: > On Mon, Apr 06, 2020 at 09:47:46PM +0200, Sam Ravnborg wrote: > > drm_writeback.h included a lot of nice kernel-doc comments. > > Wire it up so the header file is included in the kernel-doc > > generated documentation. > > > > Added a few simple comments to the two structs so they > > get picked up by kernel-doc. > > > > Signed-off-by: Sam Ravnborg > > Cc: Laurent Pinchart > > Cc: Brian Starkey > > Cc: Liviu Dudau > > Cc: Daniel Vetter > > Cc: Thomas Zimmermann > > Cc: Maxime Ripard > > Cc: Maxime Ripard > > Reviewed-by: Daniel Vetter Thanks. Applied to drm-misc-next and pushed out. Sam > > --- > > Documentation/gpu/drm-kms.rst | 3 +++ > > include/drm/drm_writeback.h | 9 +++++++++ > > 2 files changed, 12 insertions(+) > > > > diff --git a/Documentation/gpu/drm-kms.rst b/Documentation/gpu/drm-kms.rst > > index e1f685015807..397314d08f77 100644 > > --- a/Documentation/gpu/drm-kms.rst > > +++ b/Documentation/gpu/drm-kms.rst > > @@ -397,6 +397,9 @@ Connector Functions Reference > > Writeback Connectors > > -------------------- > > > > +.. kernel-doc:: include/drm/drm_writeback.h > > + :internal: > > + > > .. kernel-doc:: drivers/gpu/drm/drm_writeback.c > > :doc: overview > > > > diff --git a/include/drm/drm_writeback.h b/include/drm/drm_writeback.h > > index 777c14c847f0..9697d2714d2a 100644 > > --- a/include/drm/drm_writeback.h > > +++ b/include/drm/drm_writeback.h > > @@ -15,7 +15,13 @@ > > #include > > #include > > > > +/** > > + * struct drm_writeback_connector - DRM writeback connector > > + */ > > struct drm_writeback_connector { > > + /** > > + * @base: base drm_connector object > > + */ > > struct drm_connector base; > > > > /** > > @@ -78,6 +84,9 @@ struct drm_writeback_connector { > > char timeline_name[32]; > > }; > > > > +/** > > + * struct drm_writeback_job - DRM writeback job > > + */ > > struct drm_writeback_job { > > /** > > * @connector: > > -- > > 2.20.1 > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel