From: Sam Ravnborg <sam@ravnborg.org>
To: Rob Herring <robh@kernel.org>
Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com>,
devicetree@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 1/1] dt-bindings: display: allow port and ports in panel-lvds
Date: Tue, 14 Apr 2020 18:24:13 +0200 [thread overview]
Message-ID: <20200414162413.GA31129@ravnborg.org> (raw)
In-Reply-To: <20200414135501.GA22903@bogus>
Hi Rob.
> > Cc: Thierry Reding <thierry.reding@gmail.com>
> > Cc: dri-devel@lists.freedesktop.org
> > ---
> > .../devicetree/bindings/display/panel/lvds.yaml | 10 +++++++++-
> > 1 file changed, 9 insertions(+), 1 deletion(-)
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
> One nit below...
>
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/lvds.yaml b/Documentation/devicetree/bindings/display/panel/lvds.yaml
> > index d0083301acbe..a5587c4f5ad0 100644
> > --- a/Documentation/devicetree/bindings/display/panel/lvds.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/lvds.yaml
> > @@ -96,12 +96,20 @@ properties:
> > If set, reverse the bit order described in the data mappings below on all
> > data lanes, transmitting bits for slots 6 to 0 instead of 0 to 6.
> >
> > + port: true
> > + ports: true
> > +
> > required:
> > - compatible
> > - data-mapping
> > - width-mm
> > - height-mm
> > - panel-timing
> > - - port
> > +
> > +oneOf:
> > + - required:
> > + - port
> > + - required:
> > + - ports
>
> Should be indented 2 more spaces. It only matters for any scripted
> processing we do on the files.
Fixed and pushed to drm-misc-next.
Will cherry-pick to drm-fixes.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-04-14 16:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-12 13:21 [PATCH v2 0/1] dt-bindings: fix warning in panel/advantech, idk-2121wr Sam Ravnborg
2020-04-12 13:21 ` [PATCH v2 1/1] dt-bindings: display: allow port and ports in panel-lvds Sam Ravnborg
2020-04-14 13:55 ` Rob Herring
2020-04-14 16:24 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414162413.GA31129@ravnborg.org \
--to=sam@ravnborg.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabrizio.castro@bp.renesas.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).