From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7808FC2BA19 for ; Wed, 15 Apr 2020 12:43:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4838D20737 for ; Wed, 15 Apr 2020 12:43:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="fZQxdNoA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4838D20737 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B57A6E221; Wed, 15 Apr 2020 12:43:09 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id D8C2C6E221 for ; Wed, 15 Apr 2020 12:43:08 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id a25so18970614wrd.0 for ; Wed, 15 Apr 2020 05:43:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xz+YTOHNYCXdP1BDbqG5YAFKwQGTYMNNrFa2gvIXERM=; b=fZQxdNoApyvNeBsn2jIoaMwXN15cK/vKO9+PLRI3LBOsjXFLn1GeBzPPyjw8+KtTjs 2bWgWwxitVfu/M9wMaOThxOv5T6M1Yli+RdLaZpOoKLavGVebcSEYNu5W9DM3WtPApxF 2BW8mDeLeATpX7He1zzfcqJPEz4C6aKSWI1qc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xz+YTOHNYCXdP1BDbqG5YAFKwQGTYMNNrFa2gvIXERM=; b=ccR3zBTvIxQJZ2UCA2IfkROzXMRRv4zM6tfHGISsDVtyxgpgfrUVEnDIBND5IWqI16 b/W1nue/edtomzey8K8PkNds/HSSZWS+YVy/KeywIDG1iC6TrG5BwF/IQyXT597DespB eYDKxKah8Ru623ipNrkQeDTmmzwzMDyZD/U20CUUJA10s8kLuluP1PIec7CN6a4lnfo+ WVrQVNIggmlRW2PTTOGhZ0P55TpcGVoyyGLISCOPAVr2YR8XcVP0AsPz6ccOQbAR67C+ S1Re6q++J7EsfDQfr/Bkrfb6JUDU35v+pPyoaThGaMLKnqNIbzzk91ld/kadY3cAQyhd oLZQ== X-Gm-Message-State: AGi0PuabFdx9E35EPJSmPgue9pLp+s0dby1+dKeJnPbF12iYUbpfwc/M ojNhn0aMPfhV2LLBUrbaeP1w8A== X-Google-Smtp-Source: APiQypI/joouelURTy4OKxn0y/Uzbjwa4A81ZP3a5dY66+yY/aNdM1czkBjo4FY/RYkgSehhK70yMg== X-Received: by 2002:adf:afe4:: with SMTP id y36mr29792465wrd.205.1586954587467; Wed, 15 Apr 2020 05:43:07 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id t13sm7139552wre.70.2020.04.15.05.43.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2020 05:43:06 -0700 (PDT) Date: Wed, 15 Apr 2020 14:43:05 +0200 From: Daniel Vetter To: Linus Walleij Subject: Re: [PATCH] drm/tegra: Clean up GPIO includes Message-ID: <20200415124305.GC3456981@phenom.ffwll.local> References: <20200415122427.111769-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200415122427.111769-1-linus.walleij@linaro.org> X-Operating-System: Linux phenom 5.3.0-3-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, Thierry Reding , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Apr 15, 2020 at 02:24:27PM +0200, Linus Walleij wrote: > The Tegra DRM drivers includes the legacy GPIO headers > and but what it really > uses is since only gpio_desc > structs are ever referenced. > > Include the right header on the top level tegra/drm.h > file and drop all the surplus includes. > > Signed-off-by: Linus Walleij Hm, I wonder whether we should do similar splits for drm_bridge and drm_panel, so that drivers don't pick the wrong interfaces ... Anyway this looks neat, I spent a bit of time looking at how this is done, fwiw (not much) and assuming it compiles: Acked-by: Daniel Vetter > --- > drivers/gpu/drm/tegra/dpaux.c | 2 -- > drivers/gpu/drm/tegra/drm.h | 2 +- > drivers/gpu/drm/tegra/hdmi.c | 1 - > drivers/gpu/drm/tegra/sor.c | 1 - > 4 files changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c > index 7dfb50f65067..105fb9cdbb3b 100644 > --- a/drivers/gpu/drm/tegra/dpaux.c > +++ b/drivers/gpu/drm/tegra/dpaux.c > @@ -5,12 +5,10 @@ > > #include > #include > -#include > #include > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/gpu/drm/tegra/drm.h b/drivers/gpu/drm/tegra/drm.h > index ed99b67deb29..bf0512177e8f 100644 > --- a/drivers/gpu/drm/tegra/drm.h > +++ b/drivers/gpu/drm/tegra/drm.h > @@ -9,7 +9,7 @@ > > #include > #include > -#include > +#include > > #include > #include > diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/hdmi.c > index 38252c0f068d..94fb0193fa3d 100644 > --- a/drivers/gpu/drm/tegra/hdmi.c > +++ b/drivers/gpu/drm/tegra/hdmi.c > @@ -7,7 +7,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c > index 81226a4953c1..b010826e86da 100644 > --- a/drivers/gpu/drm/tegra/sor.c > +++ b/drivers/gpu/drm/tegra/sor.c > @@ -6,7 +6,6 @@ > #include > #include > #include > -#include > #include > #include > #include > -- > 2.25.2 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel