From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE41CC2D0EF for ; Fri, 17 Apr 2020 13:11:13 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 92D9320780 for ; Fri, 17 Apr 2020 13:11:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="sxkGqCfA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 92D9320780 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DCD926EBDD; Fri, 17 Apr 2020 13:11:12 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7E5C66EBDD for ; Fri, 17 Apr 2020 13:11:12 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 87B6597D; Fri, 17 Apr 2020 15:11:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1587129070; bh=7193wIuK9xxfxyCeMGXk0h21dUcBAn3R8Nhtk/5Ub2o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sxkGqCfAyOynGO7MzoiD7coZhOWcbA2kmtLP+iIVIXvdQd/N6WYRmyarKl4OzuWEV oUgbMHtO29y2XW9Tl1hkYFH7YgFBaWfG88skKE6D6oWJHdPqafxQVJgevugNDHFduZ VSexBtTPfQl1b0MhLCDM20aE4F9IPJqXtbnymtgY= Date: Fri, 17 Apr 2020 16:10:58 +0300 From: Laurent Pinchart To: Tomi Valkeinen Subject: Re: [PATCH] drm/panel: panel-simple: Set AUO G101EVN010 panel type Message-ID: <20200417131058.GC4748@pendragon.ideasonboard.com> References: <20200417114043.25381-1-tomi.valkeinen@ti.com> <1163e6e1-254d-07c9-496b-7bf2d3157a51@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1163e6e1-254d-07c9-496b-7bf2d3157a51@ti.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alex Gonzalez , Thierry Reding , Sam Ravnborg , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Tomi, Thank you for the patch. On Fri, Apr 17, 2020 at 04:00:34PM +0300, Tomi Valkeinen wrote: > (Adding Alex to the thread) > > On 17/04/2020 14:40, Tomi Valkeinen wrote: > > The AUO G101EVN010 is a 18-bit LVDS panel, not a parallel panel, as > > indicated by the current bus_format. > > > > Fix the bus_format to MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, and also set the > > connector_type to LVDS. > > > > Signed-off-by: Tomi Valkeinen I'll trust you on the format, Acked-by: Laurent Pinchart > > --- > > drivers/gpu/drm/panel/panel-simple.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > > index 3ad828eaefe1..bf781e260fe7 100644 > > --- a/drivers/gpu/drm/panel/panel-simple.c > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > @@ -836,7 +836,8 @@ static const struct panel_desc auo_g101evn010 = { > > .width = 216, > > .height = 135, > > }, > > - .bus_format = MEDIA_BUS_FMT_RGB666_1X18, > > + .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, > > + .connector_type = DRM_MODE_CONNECTOR_LVDS, > > }; > > > > static const struct drm_display_mode auo_g104sn02_mode = { -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel