From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50556C38A2B for ; Fri, 17 Apr 2020 13:40:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F39C42087E for ; Fri, 17 Apr 2020 13:40:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ruenEzsM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F39C42087E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 119C66EC00; Fri, 17 Apr 2020 13:40:09 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1DE136EBEC for ; Fri, 17 Apr 2020 13:39:56 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5F4A197D; Fri, 17 Apr 2020 15:39:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1587130794; bh=qr6XyNABx9qoiyDN+lAVFxJg+kgTtf9JX5wDU0HbXQw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ruenEzsMlMhWou7LDNt+MNlTeSLcYnLPmg6xE/YZwP6OvrmqQbUwZpuRVW95IvsoD l9vFpLzPxB+WoYKDF0SY1WWTWn/13GALTS5YcnVb1gk1xuoClEbpsjIX5pnh2Lcgd8 y2KhOXNcy3GF0eTyGALTLs1rdwG4G2VHBhnOzMVk= Date: Fri, 17 Apr 2020 16:39:42 +0300 From: Laurent Pinchart To: Tomi Valkeinen Subject: Re: [PATCH] drm/omap: change default signal polarities and drives Message-ID: <20200417133942.GD4748@pendragon.ideasonboard.com> References: <20200417114151.25843-1-tomi.valkeinen@ti.com> <20200417132902.GA11473@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jyri Sarha , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Tomi, On Fri, Apr 17, 2020 at 04:34:19PM +0300, Tomi Valkeinen wrote: > On 17/04/2020 16:29, Laurent Pinchart wrote: > > On Fri, Apr 17, 2020 at 02:41:51PM +0300, Tomi Valkeinen wrote: > >> If the given videomode does not specify DISPLAY_FLAG_* for the specific > >> signal property, the driver used a default value. These defaults were > >> never thought through, as the expectation was that all the DISPLAY_FLAGS > >> are always set explicitly. > >> > >> With DRM bridge and panel drivers this is not the case, and while that > >> issue should be resolved in the future, it's still good to have sane > >> signal defaults. > >> > >> This patch changes the defaults to what the hardware has as reset > >> defaults. Also, based on my experience, I think they make sense and are > >> more likely correct than the defaults without this patch. > >> > >> Signed-off-by: Tomi Valkeinen > >> --- > >> drivers/gpu/drm/omapdrm/dss/dispc.c | 33 ++++++----------------------- > >> 1 file changed, 6 insertions(+), 27 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c b/drivers/gpu/drm/omapdrm/dss/dispc.c > >> index dbb90f2d2ccd..6639ee9b05d3 100644 > >> --- a/drivers/gpu/drm/omapdrm/dss/dispc.c > >> +++ b/drivers/gpu/drm/omapdrm/dss/dispc.c > >> @@ -3137,33 +3137,12 @@ static void _dispc_mgr_set_lcd_timings(struct dispc_device *dispc, > >> dispc_write_reg(dispc, DISPC_TIMING_H(channel), timing_h); > >> dispc_write_reg(dispc, DISPC_TIMING_V(channel), timing_v); > >> > >> - if (vm->flags & DISPLAY_FLAGS_VSYNC_HIGH) > >> - vs = false; > >> - else > >> - vs = true; > >> - > >> - if (vm->flags & DISPLAY_FLAGS_HSYNC_HIGH) > >> - hs = false; > >> - else > >> - hs = true; > >> - > >> - if (vm->flags & DISPLAY_FLAGS_DE_HIGH) > >> - de = false; > >> - else > >> - de = true; > >> - > >> - if (vm->flags & DISPLAY_FLAGS_PIXDATA_POSEDGE) > >> - ipc = false; > >> - else > >> - ipc = true; > >> - > >> - /* always use the 'rf' setting */ > >> - onoff = true; > >> - > >> - if (vm->flags & DISPLAY_FLAGS_SYNC_POSEDGE) > >> - rf = true; > >> - else > >> - rf = false; > >> + vs = !!(vm->flags & DISPLAY_FLAGS_VSYNC_LOW); > >> + hs = !!(vm->flags & DISPLAY_FLAGS_HSYNC_LOW); > >> + de = !!(vm->flags & DISPLAY_FLAGS_DE_LOW); > >> + ipc = !!(vm->flags & DISPLAY_FLAGS_PIXDATA_NEGEDGE); > >> + onoff = true; /* always use the 'rf' setting */ > >> + rf = !!(vm->flags & DISPLAY_FLAGS_SYNC_POSEDGE); > > > > Would it make sense to WARN() if flags are not set, to catch offenders > > and fix them ? Apart from that, > > Maybe at some point, but for now it would probably be printing WARNs on all boards. I haven't looked > at exactly which driver combinations get the bus flags/formats right, but I have a feeling that it's > not too many. Fair enough. Maybe we should try it locally first and see how many components are faulty. > And some pieces of hardware also may be "don't care" for certain flags, so I think it's a valid case > that a bridge/panel doesn't define some of the flags. -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel