From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED517C55192 for ; Thu, 23 Apr 2020 22:51:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C53BF20736 for ; Thu, 23 Apr 2020 22:51:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="chSOWq4W" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C53BF20736 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EB1DE6EA3B; Thu, 23 Apr 2020 22:50:49 +0000 (UTC) Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by gabe.freedesktop.org (Postfix) with ESMTPS id EE4A96E804 for ; Thu, 23 Apr 2020 14:14:20 +0000 (UTC) Received: by mail-pj1-x1043.google.com with SMTP id y6so2551975pjc.4 for ; Thu, 23 Apr 2020 07:14:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Gr4q+GtQ73VeA1ex9WDdOXnvVsAGwwpT9Br82wEFbbM=; b=chSOWq4WT8sLvJ6tgwVOsVV5xwk0uqU1QNxzyAno/WKveBs/2IXVsFUCOT54GDobkv uPcs1fPtUIZUVsC6VD8qweivTuwJ/1hAj/RawRP5iJNQVG142svwWGv6aLVblg04PQQg DH/k4yOQrq3alOMg9cqUM9x3UI82NDP4tWpYZgG0gL5C79inVyY8+AJMTRRBBUaOwZ+b PZWTFjzPSdf8CZBov1dA/M8NALAUc2B7KSUAdsJs6bRzc75liNI157k5AanFHPLP0MJy 2KGWGXRQtHHGqLi0YA8KehFLMOfixaDWKcEjzB6BIJ2E6hyxgWri3GwAUGkQtV+81miE bq3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Gr4q+GtQ73VeA1ex9WDdOXnvVsAGwwpT9Br82wEFbbM=; b=AlxXSNsR1Aj8opDCm5JCaOoo+TuOCdVwdNQkgdVL2nWroVZ7yzREBFnNdB4li5XQIb rQ7Vsywm4HjndTTEOV7/bDq8XgsxJAEcjrq8orA6Cs8IxFMPuV/7yvtKyqjjcTteRUhd gVCL4gj+o/lupfTe3YQ0e5hznJhdYK+1rHAlFsx19b+kedGaS627DfB8S6FfXyRQnSV3 n5ZJbqjaG1hIs/K/azfauT+9Dub1mXOqYkeaD8koYgI8uJXpme8Q28ZXyvivFCJ7HGrH 5yqa8/yUGwGrSvTLcY+vnJrKng6n+YvOgcC/iTxqQ9KifWDI1DseFifrNtZzcWTpOlQJ lO6A== X-Gm-Message-State: AGi0Puax5NF8o/tZd2PKfG/gmCvrsBpMmphlZAvc5vsG7NaMj4BoA3ul Ivj4WnkD4kesgNvkOgYeO0k= X-Google-Smtp-Source: APiQypJ9D5YwGJP6XZ0Hx/3cE3rM1cNh5FmISzcRlldumlGuRKgCjPow9KPEvSp4D9K3K9JS3R/h6Q== X-Received: by 2002:a17:902:aa97:: with SMTP id d23mr3921865plr.244.1587651260522; Thu, 23 Apr 2020 07:14:20 -0700 (PDT) Received: from localhost (176.122.158.71.16clouds.com. [176.122.158.71]) by smtp.gmail.com with ESMTPSA id s145sm2237772pgs.57.2020.04.23.07.14.19 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 Apr 2020 07:14:20 -0700 (PDT) Date: Thu, 23 Apr 2020 22:14:16 +0800 From: Dejin Zheng To: Gerd Hoffmann Subject: Re: [PATCH v1] drm/bochs: fix an issue of ioremap() leak Message-ID: <20200423141416.GA1562@nuc8i5> References: <20200421164543.16605-1-zhengdejin5@gmail.com> <20200422135215.GA25950@nuc8i5> <20200422152142.GA26943@nuc8i5> <20200423101420.ityynrorrehjvxrs@sirius.home.kraxel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200423101420.ityynrorrehjvxrs@sirius.home.kraxel.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Mailman-Approved-At: Thu, 23 Apr 2020 22:50:35 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Linux Kernel Mailing List , dri-devel , virtualization@lists.linux-foundation.org, Andy Shevchenko Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Apr 23, 2020 at 12:14:20PM +0200, Gerd Hoffmann wrote: > Hi, > > > I am a newbie, andy gave me some directions to submit the patch, eg: check > > ioremap leak. At this time, I found that the bochs driver may have similar > > problems, so I submitted this patch, then, Andy said the best is to switch > > this driver to use pcim _ * () functions and drop tons of legacy code. > > I think we might be able to fix this issue first, after that, drop tons > > of legacy code by pcim_*() functions. Can you give me some suggestions? > > thank you very much! > > drm has drmm_* functions for that. Daniel Vetter has > a patch series pending switching lots of drivers over and IIRC it fixes > this bug too. > Gerd, Thanks for your info and abandon this commit. BR, Dejin > cheers, > Gerd > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel