From: Sam Ravnborg <sam@ravnborg.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
drinkcat@chromium.org, Neil Armstrong <narmstrong@baylibre.com>,
David Airlie <airlied@linux.ie>, Jonas Karlman <jonas@kwiboo.se>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Andrzej Hajda <a.hajda@samsung.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
hsinyi@chromium.org, matthias.bgg@gmail.com,
Collabora Kernel ML <kernel@collabora.com>
Subject: Re: [PATCH 2/2] drm/bridge: ps8640: Let panel to set the connector type
Date: Sat, 25 Apr 2020 16:48:11 +0200 [thread overview]
Message-ID: <20200425144811.GD32235@ravnborg.org> (raw)
In-Reply-To: <20200416164404.2418426-2-enric.balletbo@collabora.com>
On Thu, Apr 16, 2020 at 06:44:04PM +0200, Enric Balletbo i Serra wrote:
> The panel connector type should be set by the panel not the bridge, so
> remove the connector_type assignment.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Thanks, applied to drm-misc-next.
Sam
> ---
>
> drivers/gpu/drm/bridge/parade-ps8640.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
> index 956b76e0a44d..13755d278db6 100644
> --- a/drivers/gpu/drm/bridge/parade-ps8640.c
> +++ b/drivers/gpu/drm/bridge/parade-ps8640.c
> @@ -278,8 +278,6 @@ static int ps8640_probe(struct i2c_client *client)
> if (!panel)
> return -ENODEV;
>
> - panel->connector_type = DRM_MODE_CONNECTOR_eDP;
> -
> ps_bridge->panel_bridge = devm_drm_panel_bridge_add(dev, panel);
> if (IS_ERR(ps_bridge->panel_bridge))
> return PTR_ERR(ps_bridge->panel_bridge);
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-25 14:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 16:44 [PATCH 1/2] drm: panel: Set connector type for LP120UP1 Enric Balletbo i Serra
2020-04-16 16:44 ` [PATCH 2/2] drm/bridge: ps8640: Let panel to set the connector type Enric Balletbo i Serra
2020-04-16 17:04 ` Laurent Pinchart
2020-04-25 14:48 ` Sam Ravnborg [this message]
2020-04-16 17:03 ` [PATCH 1/2] drm: panel: Set connector type for LP120UP1 Laurent Pinchart
2020-04-25 14:47 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200425144811.GD32235@ravnborg.org \
--to=sam@ravnborg.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=drinkcat@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=hsinyi@chromium.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox