From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEFE9C55191 for ; Sat, 25 Apr 2020 14:49:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA65A20714 for ; Sat, 25 Apr 2020 14:49:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA65A20714 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 635E16E267; Sat, 25 Apr 2020 14:49:48 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8AA786E267 for ; Sat, 25 Apr 2020 14:49:46 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 8BB5620070; Sat, 25 Apr 2020 16:49:44 +0200 (CEST) Date: Sat, 25 Apr 2020 16:49:43 +0200 From: Sam Ravnborg To: Enric Balletbo i Serra Subject: Re: [PATCH] drm/bridge: panel: Return always an error pointer in drm_panel_bridge_add() Message-ID: <20200425144943.GE32235@ravnborg.org> References: <20200416210654.2468805-1-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200416210654.2468805-1-enric.balletbo@collabora.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=ULXz4hXy c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=P1BnusSwAAAA:8 a=QX4gbG5DAAAA:8 a=e5mUnYsNAAAA:8 a=-fIW-uut3qeXBzhQ7CAA:9 a=CjuIK1q_8ugA:10 a=D0XLA9XvdZm18NrgonBM:22 a=AbAUZ8qAyYyZVLSsDulk:22 a=Vxmtnl_E_bksehYqCbjh:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Neil Armstrong , David Airlie , Jonas Karlman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrzej Hajda , Laurent Pinchart , Collabora Kernel ML Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Apr 16, 2020 at 11:06:54PM +0200, Enric Balletbo i Serra wrote: > Since commit 89958b7cd955 ("drm/bridge: panel: Infer connector type from > panel by default"), drm_panel_bridge_add() and their variants can return > NULL and an error pointer. This is fine but none of the actual users of > the API are checking for the NULL value. Instead of change all the > users, seems reasonable to return an error pointer instead. So change > the returned value for those functions when the connector type is unknown. > > Suggested-by: Laurent Pinchart > Signed-off-by: Enric Balletbo i Serra Thanks, added to drm-misc-next. Sam > --- > > drivers/gpu/drm/bridge/panel.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c > index 8461ee8304ba..7a3df0f319f3 100644 > --- a/drivers/gpu/drm/bridge/panel.c > +++ b/drivers/gpu/drm/bridge/panel.c > @@ -166,7 +166,7 @@ static const struct drm_bridge_funcs panel_bridge_bridge_funcs = { > * > * The connector type is set to @panel->connector_type, which must be set to a > * known type. Calling this function with a panel whose connector type is > - * DRM_MODE_CONNECTOR_Unknown will return NULL. > + * DRM_MODE_CONNECTOR_Unknown will return ERR_PTR(-EINVAL). > * > * See devm_drm_panel_bridge_add() for an automatically managed version of this > * function. > @@ -174,7 +174,7 @@ static const struct drm_bridge_funcs panel_bridge_bridge_funcs = { > struct drm_bridge *drm_panel_bridge_add(struct drm_panel *panel) > { > if (WARN_ON(panel->connector_type == DRM_MODE_CONNECTOR_Unknown)) > - return NULL; > + return ERR_PTR(-EINVAL); > > return drm_panel_bridge_add_typed(panel, panel->connector_type); > } > @@ -265,7 +265,7 @@ struct drm_bridge *devm_drm_panel_bridge_add(struct device *dev, > struct drm_panel *panel) > { > if (WARN_ON(panel->connector_type == DRM_MODE_CONNECTOR_Unknown)) > - return NULL; > + return ERR_PTR(-EINVAL); > > return devm_drm_panel_bridge_add_typed(dev, panel, > panel->connector_type); > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel