From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BEFCC38A24 for ; Thu, 7 May 2020 07:06:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F7B5208CA for ; Thu, 7 May 2020 07:06:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="CDYYUXVy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F7B5208CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 198E16E946; Thu, 7 May 2020 07:05:31 +0000 (UTC) Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) by gabe.freedesktop.org (Postfix) with ESMTPS id DEA6D6E8A4 for ; Wed, 6 May 2020 16:18:26 +0000 (UTC) Received: by mail-qt1-x844.google.com with SMTP id b1so1981810qtt.1 for ; Wed, 06 May 2020 09:18:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dI/8k01wqNtPsEMN3JryPuexKMUAM9GFAPsiKlMJOgs=; b=CDYYUXVytFKURB46DxLbtSQhLKEUVHOamKg4N6ws/VeYuZqe48aW2fVU4DY/h9Bp0C oxPsar9OJVyyfKYewl2b61UAK/iYMJhUOEztf6FyAWUPWMHx6K52Ms3zjFawc0T82Nl1 7Xt+P1aPijxMvudfHiyJNFg5C9ZFGxb7Xq5W8dbwJ21FJwxC/q1Blc/Rw7qi4EBtZ7QU QsgB9ERVVjUURncAAw80TIEnHnDpJ9Brzd9+PloSZTbvOPoos60r/CIiiaGLTHr18jlp z1hKejvJ2XMgEhTqjmxxET3DODSbvUQWlTA4t/TK35N6seBmGymATrWanur938yEOAM8 A/+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dI/8k01wqNtPsEMN3JryPuexKMUAM9GFAPsiKlMJOgs=; b=Fu0utCoNDtDZ22vst8WKxnC2/oKH7+hJ/UwnvJCjoj35oDI5UW9NpIhUCaHLiM+r2H iFjSXbpZQ1p0WNEmm70Okvz1zi3eu0CZ0D3YtKNA5+NruOuUJNJzl6CabxtSCCuKNph1 qea6ziOrgc4wZuRk8etVPHvybvdN4VM712nbzaTBTnDdyqdi+A0XBl8co8qhnrmVRXkJ Z8ucyH0TvUyvtOzgkuu0P3PfSkshVJaa3FSzBP+nNs6VWomaFFNf2UkXjuW4HjGXQzA6 Tm8KEgcJBS83PHjWA2fxmBOsQIsaAg43TZ4NukFZ5HFtA+ikw3ixXuSTkETj0T4q9LJt MbHA== X-Gm-Message-State: AGi0Pub+m7FTVLst6Vl7oZguX40d3ZRh2DoUAqKrakfdTijRu+nKkyvp M2P+C3n2x1kqE3HVDFFy8OvPEg== X-Google-Smtp-Source: APiQypKyDRDNEzprm+gsfACpH0aQyfocl+/L2XhuNJKEuZItD8tyLPJ84MVvdGkrVM9/6D8550tNkg== X-Received: by 2002:aed:2e83:: with SMTP id k3mr9101168qtd.2.1588781906015; Wed, 06 May 2020 09:18:26 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id h13sm1895261qti.32.2020.05.06.09.18.25 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 May 2020 09:18:25 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jWMka-0002ut-Lq; Wed, 06 May 2020 13:18:24 -0300 Date: Wed, 6 May 2020 13:18:24 -0300 From: Jason Gunthorpe To: Ralph Campbell Subject: Re: [PATCH hmm v2 5/5] mm/hmm: remove the customizable pfn format from hmm_range_fault Message-ID: <20200506161824.GG26002@ziepe.ca> References: <5-v2-b4e84f444c7d+24f57-hmm_no_flags_jgg@mellanox.com> <3c06a94c-c17f-dc31-537e-f3f6e1ace9a2@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3c06a94c-c17f-dc31-537e-f3f6e1ace9a2@nvidia.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Mailman-Approved-At: Thu, 07 May 2020 07:05:09 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Yang, Philip" , John Hubbard , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Christoph Hellwig , linux-mm@kvack.org, =?utf-8?B?SsOpcsO0bWU=?= Glisse , Ben Skeggs , nouveau@lists.freedesktop.org, Alex Deucher , Felix Kuehling , Niranjana Vishwanathapura , intel-gfx@lists.freedesktop.org, Christian =?utf-8?B?S8O2bmln?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, May 01, 2020 at 05:53:26PM -0700, Ralph Campbell wrote: > > Acked-by: Felix Kuehling > > Tested-by: Ralph Campbell > > Signed-off-by: Jason Gunthorpe > > Signed-off-by: Christoph Hellwig > > Documentation/vm/hmm.rst | 26 ++-- > > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 35 ++---- > > drivers/gpu/drm/nouveau/nouveau_dmem.c | 27 +--- > > drivers/gpu/drm/nouveau/nouveau_dmem.h | 3 +- > > drivers/gpu/drm/nouveau/nouveau_svm.c | 87 ++++++++----- > > include/linux/hmm.h | 99 ++++++--------- > > mm/hmm.c | 160 +++++++++++------------- > > 7 files changed, 192 insertions(+), 245 deletions(-) > > > > ...snip... > > > +static void nouveau_hmm_convert_pfn(struct nouveau_drm *drm, > > + struct hmm_range *range, u64 *ioctl_addr) > > +{ > > + unsigned long i, npages; > > + > > + /* > > + * The ioctl_addr prepared here is passed through nvif_object_ioctl() > > + * to an eventual DMA map in something like gp100_vmm_pgt_pfn() > > + * > > + * This is all just encoding the internal hmm reprensetation into a > > s/reprensetation/representation/ > > Looks good and still tests OK with nouveau. Got it, thanks Jason _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel