From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 340EEC38A2A for ; Fri, 8 May 2020 10:12:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA21A20870 for ; Fri, 8 May 2020 10:12:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="PdSLtzsT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA21A20870 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 569ED6E162; Fri, 8 May 2020 10:12:54 +0000 (UTC) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0E20B6E162 for ; Fri, 8 May 2020 10:12:54 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id v8so9555728wma.0 for ; Fri, 08 May 2020 03:12:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=80e4YhVYsBOu9hDZgrB+N7FSQ8gx2xhSHcqa3FFcxTg=; b=PdSLtzsTfw8LPinD94rHM7kHwUY2682vpO0onvuC8PzJMDLiA+m4D1Eh2qA6qtg1MQ T/lmg9cmNJ5zoOwV50V5eV5HbgIGokgAvPEvY5fyKy7xPk3MF6SHJC9BqwnWA8C197Mi Gt9p0KgYD1MctPcXYt4Zn3Y1NKz4vw0RRPps8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=80e4YhVYsBOu9hDZgrB+N7FSQ8gx2xhSHcqa3FFcxTg=; b=CwQ8T37WWuoZ3oiqnfNwZG56XYU1tlEknI49z2srH+nXt3fdkUfI9a91zukmaZRJIo +RO2/CByvLYspElg4WQG1N9K6MMdFT23+xSNogeeKkV7kTh9NxmWZ9gFOmtvwaj6+Lz4 cIRsQL7i/FA8KnDO5jPkE9DkdDj3TEAzJ4cdbO5mNlVGI7no8tvbsXkwy/qAKuHRPHjr i7AcPb+lZzJqdKQkbeTtg3CkvhZAQuLACYKLK9o8sdnd5sBsl9wB5ZrLPtjYCWYcCs6L QN6FmoTjU3WjCz66gKduPidXgNaTdDTVeV3Cgy2nZCOzpoXTHVMlV831ugb3QxEHoH8k quTQ== X-Gm-Message-State: AGi0PuYT/5cA/tHrsQxHsbJUPMznqWVjkvYa/6FmnhbHzvI2XgMp7Q3t WTk+NAJjT7Isblc5BPfosmotHQ== X-Google-Smtp-Source: APiQypJMij7IvC3lWLmIUqT0PRp+I0x/fqztWOHDiYOs7hTuFqUhNJB2oUX5ovP524jc7eNI208IfQ== X-Received: by 2002:a1c:2289:: with SMTP id i131mr1520574wmi.111.1588932772670; Fri, 08 May 2020 03:12:52 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id m1sm1751304wrx.44.2020.05.08.03.12.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 03:12:51 -0700 (PDT) Date: Fri, 8 May 2020 12:12:49 +0200 From: Daniel Vetter To: Mika Kahola Subject: Re: [PATCH v2] uapi/drm/drm_fourcc.h: Note on platform specificity for format modifiers Message-ID: <20200508101249.GG1383626@phenom.ffwll.local> References: <20200506120827.12250-1-mika.kahola@intel.com> <20200508065628.GD1383626@phenom.ffwll.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200508065628.GD1383626@phenom.ffwll.local> X-Operating-System: Linux phenom 5.4.0-4-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, May 08, 2020 at 08:56:28AM +0200, Daniel Vetter wrote: > On Wed, May 06, 2020 at 03:08:27PM +0300, Mika Kahola wrote: > > Make an additional note on DRM format modifiers for x and y tiling. These > > format modifiers are defined for BDW+ platforms and therefore definition > > is not valid for older gens. This is due to address swizzling for tiled > > surfaces is no longer used. For newer platforms main memory controller has > > a more effective address swizzling algorithm. > > > > v2: Rephrase comment (Daniel) > > > > Signed-off-by: Mika Kahola > > Reviewed-by: Daniel Vetter Ok I assumed you'd just push that to drm-intel with commit rights or something, but that got stuck so applying to drm-misc-next now. Cheers, Daniel > > > --- > > include/uapi/drm/drm_fourcc.h | 18 ++++++++++++------ > > 1 file changed, 12 insertions(+), 6 deletions(-) > > > > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > > index 8bc0b31597d8..9e488d10f8b4 100644 > > --- a/include/uapi/drm/drm_fourcc.h > > +++ b/include/uapi/drm/drm_fourcc.h > > @@ -354,9 +354,12 @@ extern "C" { > > * a platform-dependent stride. On top of that the memory can apply > > * platform-depending swizzling of some higher address bits into bit6. > > * > > - * This format is highly platforms specific and not useful for cross-driver > > - * sharing. It exists since on a given platform it does uniquely identify the > > - * layout in a simple way for i915-specific userspace. > > + * Note that this layout is only accurate on intel gen 8+ or valleyview chipsets. > > + * On earlier platforms the is highly platforms specific and not useful for > > + * cross-driver sharing. It exists since on a given platform it does uniquely > > + * identify the layout in a simple way for i915-specific userspace, which > > + * facilitated conversion of userspace to modifiers. Additionally the exact > > + * format on some really old platforms is not known. > > */ > > #define I915_FORMAT_MOD_X_TILED fourcc_mod_code(INTEL, 1) > > > > @@ -369,9 +372,12 @@ extern "C" { > > * memory can apply platform-depending swizzling of some higher address bits > > * into bit6. > > * > > - * This format is highly platforms specific and not useful for cross-driver > > - * sharing. It exists since on a given platform it does uniquely identify the > > - * layout in a simple way for i915-specific userspace. > > + * Note that this layout is only accurate on intel gen 8+ or valleyview chipsets. > > + * On earlier platforms the is highly platforms specific and not useful for > > + * cross-driver sharing. It exists since on a given platform it does uniquely > > + * identify the layout in a simple way for i915-specific userspace, which > > + * facilitated conversion of userspace to modifiers. Additionally the exact > > + * format on some really old platforms is not known. > > */ > > #define I915_FORMAT_MOD_Y_TILED fourcc_mod_code(INTEL, 2) > > > > -- > > 2.20.1 > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel