From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79870C433E0 for ; Mon, 18 May 2020 16:41:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5602D20826 for ; Mon, 18 May 2020 16:41:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5602D20826 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DEF736E440; Mon, 18 May 2020 16:41:38 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id B1D666E43F; Mon, 18 May 2020 16:41:37 +0000 (UTC) IronPort-SDR: FWTy1zy5R0YEFoGrEgoYsdc2I4T28Fljp9KIdZPoEj0Z+FdMRgfF+1AsTH1GLow1+QCN8fpsIp EglaedJQIVew== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2020 09:41:36 -0700 IronPort-SDR: DdRupnlW915/XGPvI30A7NNVHB//e9zj/PopMfo4KDI956LyLV2p+C8eHaHwPaV9F0O+7DjFlY BbOEgU5Y+wQA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,407,1583222400"; d="scan'208";a="264016714" Received: from ramaling-i9x.iind.intel.com (HELO intel.com) ([10.99.66.154]) by orsmga003.jf.intel.com with ESMTP; 18 May 2020 09:41:33 -0700 Date: Mon, 18 May 2020 22:11:31 +0530 From: Ramalingam C To: Sean Paul Subject: Re: [PATCH v6 00/16] drm/i915: Add support for HDCP 1.4 over MST connectors Message-ID: <20200518164130.GA14897@intel.com> References: <20200429195502.39919-1-sean@poorly.run> <20200515144812.GB11877@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel , Daniel Vetter , Intel Graphics Development , Sean Paul , Juston Li , Rodrigo Vivi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2020-05-18 at 10:32:09 -0400, Sean Paul wrote: > On Fri, May 15, 2020 at 10:48 AM Ramalingam C wrote: > > > > On 2020-04-29 at 15:54:46 -0400, Sean Paul wrote: > > > From: Sean Paul > > > > > > Changes in v6: > > > -Rebased on -tip > > > -Disabled HDCP over MST on GEN12 > > > -Addressed Lyude's review comments in the QUERY_STREAM_ENCRYPTION_STATUS patch > > > > Sean, > > > > What is the test setup you have used? > > > > Hi Ram, > Thanks for the feedback. To be completely honest it's really > frustrating that I'm just now getting questions and review feedback > (which I've been begging for on IRC) on this review that could have > been addressed ~5 months ago. It's super disruptive to have to keep > switching back to this after a long hiatus and many i915 refactors > complicating my rebases. Hi Sean, As a developer I really feel bad for the delay happened in review. I couldn't spend required time for understanding MST part hence I couldn't review. Just for this series now I have started preparing myself on these topics, hence started reviewing the series. If you are still interested to work on this, I can commit for regular reviews. Thanks, Ram. > > If no one wants this patchset, that's fine, please just let me know so > I don't waste any more time. If Intel is interested, could we please > stop the review trickle and lay out exactly what needs to be done to > get this landed? > > Sean > > > > I am afraid our CI dont have the coverage for MST capability yet to provide > > the functional status of the code. > > > > -Ram. > > > > > > Sean Paul (16): > > > drm/i915: Fix sha_text population code > > > drm/i915: Clear the repeater bit on HDCP disable > > > drm/i915: WARN if HDCP signalling is enabled upon disable > > > drm/i915: Intercept Aksv writes in the aux hooks > > > drm/i915: Use the cpu_transcoder in intel_hdcp to toggle HDCP > > > signalling > > > drm/i915: Factor out hdcp->value assignments > > > drm/i915: Protect workers against disappearing connectors > > > drm/i915: Don't fully disable HDCP on a port if multiple pipes are > > > using it > > > drm/i915: Support DP MST in enc_to_dig_port() function > > > drm/i915: Use ddi_update_pipe in intel_dp_mst > > > drm/i915: Factor out HDCP shim functions from dp for use by dp_mst > > > drm/i915: Plumb port through hdcp init > > > drm/i915: Add connector to hdcp_shim->check_link() > > > drm/mst: Add support for QUERY_STREAM_ENCRYPTION_STATUS MST sideband > > > message > > > drm/i915: Print HDCP version info for all connectors > > > drm/i915: Add HDCP 1.4 support for MST connectors > > > > > > drivers/gpu/drm/drm_dp_mst_topology.c | 142 ++++ > > > drivers/gpu/drm/i915/Makefile | 1 + > > > drivers/gpu/drm/i915/display/intel_ddi.c | 29 +- > > > drivers/gpu/drm/i915/display/intel_ddi.h | 2 + > > > .../drm/i915/display/intel_display_debugfs.c | 21 +- > > > .../drm/i915/display/intel_display_types.h | 30 +- > > > drivers/gpu/drm/i915/display/intel_dp.c | 654 +-------------- > > > drivers/gpu/drm/i915/display/intel_dp.h | 9 + > > > drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 743 ++++++++++++++++++ > > > drivers/gpu/drm/i915/display/intel_dp_mst.c | 19 + > > > drivers/gpu/drm/i915/display/intel_hdcp.c | 217 +++-- > > > drivers/gpu/drm/i915/display/intel_hdcp.h | 2 +- > > > drivers/gpu/drm/i915/display/intel_hdmi.c | 25 +- > > > .../drm/selftests/test-drm_dp_mst_helper.c | 17 + > > > include/drm/drm_dp_helper.h | 3 + > > > include/drm/drm_dp_mst_helper.h | 44 ++ > > > include/drm/drm_hdcp.h | 3 + > > > 17 files changed, 1235 insertions(+), 726 deletions(-) > > > create mode 100644 drivers/gpu/drm/i915/display/intel_dp_hdcp.c > > > > > > -- > > > Sean Paul, Software Engineer, Google / Chromium OS > > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel