From: Sam Ravnborg <sam@ravnborg.org>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
Colin Ian King <colin.king@canonical.com>,
ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v2 2/2] drm/auth: make drm_{set,drop]master_ioctl symmetrical
Date: Sat, 30 May 2020 15:43:34 +0200 [thread overview]
Message-ID: <20200530134334.GA84399@ravnborg.org> (raw)
In-Reply-To: <CACvgo52VvmS-izutgFwdpvuB5gPqNL8jMfd7qYuyfum-hp7XOQ@mail.gmail.com>
On Sat, May 30, 2020 at 02:34:10PM +0100, Emil Velikov wrote:
> On Sat, 30 May 2020 at 14:18, Sam Ravnborg <sam@ravnborg.org> wrote:
> >
> > Hi Emil.
> > On Sat, May 30, 2020 at 01:46:40PM +0100, Emil Velikov wrote:
> > > Currently the ret handling is all over the place - with two redundant
> > > assignments and another one addressed earlier.
> > >
> > > Use the exact same flow in both functions.
> > >
> > > v2: straighten the code flow, instead of just removing the assignments
> > Now even I should be able to follow the flow - thanks :-)
> >
> Fwiw reading at the code the first couple of times, did confuse the
> hell out of me.
> So "there is nothing wrong with your television set" :-P
>
> > >
> > > Cc: David Airlie <airlied@linux.ie>
> > > Cc: Daniel Vetter <daniel@ffwll.ch>
> > > Cc: Sam Ravnborg <sam@ravnborg.org>
> > > Cc: Colin Ian King <colin.king@canonical.com>
> > > Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
> > Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
>
> Thanks. If you're up for a few more neat patches - check these out [1].
>
> -Emil
>
> [1] https://patchwork.freedesktop.org/series/76967/
On my backlog. They require, I think, a bit more time.
backlog atm is way too big - but thats a common issue for everyone.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-05-30 13:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-30 12:46 [PATCH v2 1/2] drm: vmwgfx: remove drm_driver::master_set() return typ Emil Velikov
2020-05-30 12:46 ` [PATCH v2 2/2] drm/auth: make drm_{set,drop]master_ioctl symmetrical Emil Velikov
2020-05-30 13:18 ` Sam Ravnborg
2020-05-30 13:34 ` [PATCH v2 2/2] drm/auth: make drm_{set, drop]master_ioctl symmetrical Emil Velikov
2020-05-30 13:43 ` Sam Ravnborg [this message]
2020-06-03 18:37 ` [PATCH v2 1/2] drm: vmwgfx: remove drm_driver::master_set() return typ Roland Scheidegger
2020-06-05 14:07 ` Emil Velikov
2020-06-15 19:22 ` Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200530134334.GA84399@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=colin.king@canonical.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox