From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56173C433E0 for ; Thu, 11 Jun 2020 07:54:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 227C22072F for ; Thu, 11 Jun 2020 07:54:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D+gOK5e5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 227C22072F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A5486E8A0; Thu, 11 Jun 2020 07:54:03 +0000 (UTC) Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 241FE6E863 for ; Wed, 10 Jun 2020 20:51:56 +0000 (UTC) Received: by mail-pf1-x444.google.com with SMTP id b201so1650294pfb.0 for ; Wed, 10 Jun 2020 13:51:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=BBQ0kH7eFUEzdi1aOvEKWX8Td5hf8bU8NRtY72Z+54M=; b=D+gOK5e5N4uDHgaJEiVzXMr6VuyH27uOIfpnVLZCy5Svn8efbO2h827R3C7PSG9a6K nSxI9rCKBM4+edb+ob89dSUUXQZZWJrsEl8UC/4RkIct10qQ6WfwWd8slAvfV1/HlK/4 ykKf76IVM/KVIwnVtOcQc5SFY3uoVQV1mOixWR7kBTjfcGeM6FFil+FjQMvZX2lH6/fD gHslJ0At6A3/MekYWNpXmXm3Vi+6i8d7T3bOXM0tia17DDU08MIcYxt4wKKuf7x2IHoS KvHq6vwU+GQ2TNficbOEiCmyrVYunxWWsavQXQOZAWvXa7y+sW3BAUPx/QOpU3y9HdG4 aA2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=BBQ0kH7eFUEzdi1aOvEKWX8Td5hf8bU8NRtY72Z+54M=; b=BSXo1f/zz7igxD5SQv2Kk1xTC1JcOk4hTvyIN0Vvfo9qiCMw6AUhYWeMcMVC6yX+th 55x070cBzzlbJ1jan9MVch3xGlVgtX6hBxR1k7xKCBn+lkgLvwwv+sBxS4m6LS1ByQvq Yh7J6iRAHfbGCe1ik0HDS7kWl5pm3vwXmFg1BuWdOyvIT2f7X8ugQP1zlFohXGuuEL08 BYD10PgBHyMInb1jqk4vR5L/o/ZCasSLQ2nlMUEJIrKuLhO5dkIqEnMjqDuHBl4tamnk E+Uc/uvZ/PUVrOolC1UvWGO+SKYGAct0RmFLuQGZCh564GGzV4OKtY/tHPtDjr9Bs78v a9Gg== X-Gm-Message-State: AOAM531PacxOY2CTiFwYA2l9ygLgfy2YutUliLU7mG49UEzWadyCl8GW T6POVro6N0OJu0cEb4xAZFY= X-Google-Smtp-Source: ABdhPJxKo0OgffPzJUXcMIqo8lFX22kcJRM0lWIv/TfEFZDqsYln/aDXLO3H4Aw664SDq8TfeoQ80A== X-Received: by 2002:a62:7a89:: with SMTP id v131mr4254293pfc.38.1591822315664; Wed, 10 Jun 2020 13:51:55 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id x19sm793349pfo.96.2020.06.10.13.51.54 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 10 Jun 2020 13:51:55 -0700 (PDT) Date: Wed, 10 Jun 2020 13:51:54 -0700 From: Guenter Roeck To: Emil Velikov Subject: Re: [PATCH 01/11] tty/sysrq: alpha: export and use __sysrq_get_key_op() Message-ID: <20200610205154.GA14854@roeck-us.net> References: <20200513214351.2138580-1-emil.l.velikov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200513214351.2138580-1-emil.l.velikov@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Mailman-Approved-At: Thu, 11 Jun 2020 07:54:02 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Ivan Kokshaysky , Jiri Slaby , Matt Turner , Richard Henderson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, May 13, 2020 at 10:43:41PM +0100, Emil Velikov wrote: > Export a pointer to the sysrq_get_key_op(). This way we can cleanly > unregister it, instead of the current solutions of modifuing it inplace. > > Since __sysrq_get_key_op() is no longer used externally, let's make it > a static function. > > This patch will allow us to limit access to each and every sysrq op and > constify the sysrq handling. > > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > Cc: linux-kernel@vger.kernel.org > Cc: Richard Henderson > Cc: Ivan Kokshaysky > Cc: Matt Turner > Cc: linux-alpha@vger.kernel.org > Signed-off-by: Emil Velikov > --- > Please keep me in the CC list, as I'm not subscribed to the list. > > IMHO it would be better if this gets merged this via the tty tree. Still observed: Building alpha:defconfig ... failed -------------- Error log: :1511:2: warning: #warning syscall clone3 not implemented [-Wcpp] arch/alpha/kernel/setup.c:434:13: error: initialization of 'void (*)(int)' from incompatible pointer type 'void (*)(void)' [-Werror=incompatible-pointer-types] 434 | .handler = machine_halt, | ^~~~~~~~~~~~ arch/alpha/kernel/setup.c:434:13: note: (near initialization for 'srm_sysrq_reboot_op.handler') I did not see a reply to the initial report. Is this being addressed ? Guenter _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel