From: Sam Ravnborg <sam@ravnborg.org>
To: Maksim Melnikov <approximatenumber@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/panel-simple: add support for NEC NL10276BC13-01C panel
Date: Mon, 29 Jun 2020 10:04:08 +0200 [thread overview]
Message-ID: <20200629080408.GE227119@ravnborg.org> (raw)
In-Reply-To: <842736c513b948ee00fdcbe30df3a5a6d0eed9f0.1589226066.git.approximatenumber@gmail.com>
On Mon, May 11, 2020 at 11:29:24PM +0300, Maksim Melnikov wrote:
> The NL10276BC13-01C is a 6.5" 1024x768 XGA TFT LCD panel with LVDS interface. It is used for industrial purposes in devices such as HMI.
>
> Signed-off-by: Maksim Melnikov <approximatenumber@gmail.com>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 3ad828eae..7ded13157 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2372,6 +2372,31 @@ static const struct panel_desc nec_nl4827hc19_05b = {
> .bus_flags = DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
> };
>
> +static const struct display_timing nec_nl10276bc13_01c_timing = {
> + .pixelclock = { 62600000, 68200000, 78100000 },
> + .hactive = { 1024, 1024, 1024 },
> + .hfront_porch = { 15, 64, 159 },
> + .hback_porch = { 5, 5, 5 },
> + .hsync_len = { 1, 1, 256 },
> + .vactive = { 768, 768, 768 },
> + .vfront_porch = { 3, 40, 99 },
> + .vback_porch = { 2, 2, 2 },
> + .vsync_len = { 1, 1, 128 },
> + .flags = DISPLAY_FLAGS_DE_HIGH,
> +};
> +
> +static const struct panel_desc nec_nl10276bc13_01c = {
> + .timings = &nec_nl10276bc13_01c_timing,
> + .num_timings = 1,
> + .bpc = 8,
> + .size = {
> + .width = 132,
> + .height = 99,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA,
> + .connector_type = DRM_MODE_CONNECTOR_LVDS,
Sorry for getting back so late.
Please include .bus_flags too.
We want the description to be complete.
Sam
> +};
> +
> static const struct drm_display_mode netron_dy_e231732_mode = {
> .clock = 66000,
> .hdisplay = 1024,
> @@ -3634,6 +3659,9 @@ static const struct of_device_id platform_of_match[] = {
> }, {
> .compatible = "nec,nl4827hc19-05b",
> .data = &nec_nl4827hc19_05b,
> + }, {
> + .compatible = "nec,nl10276bc13_01c",
> + .data = &nec_nl10276bc13_01c,
> }, {
> .compatible = "netron-dy,e231732",
> .data = &netron_dy_e231732,
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-06-29 8:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 20:29 [PATCH 0/2] Add support for NEC NL10276BC13-01C panel Maksim Melnikov
2020-05-11 20:29 ` [PATCH 1/2] drm/panel-simple: add " Maksim Melnikov
2020-06-29 8:04 ` Sam Ravnborg [this message]
2020-05-11 20:29 ` [PATCH 2/2] dt-bindings: display: panel: Add NEC NL10276BC13-01C panel bindings Maksim Melnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629080408.GE227119@ravnborg.org \
--to=sam@ravnborg.org \
--cc=approximatenumber@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox