From: Lee Jones <lee.jones@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Jingoo Han <jingoohan1@gmail.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] backlight: Delete the OT200 backlight driver
Date: Wed, 1 Jul 2020 10:57:03 +0100 [thread overview]
Message-ID: <20200701095703.GD1179328@dell> (raw)
In-Reply-To: <20200626102500.292230-1-linus.walleij@linaro.org>
On Fri, 26 Jun 2020, Linus Walleij wrote:
> This driver has no in-kernel users. The device can only be populated
> by board files since it does not support device tree nor ACPI,
> and nothing in the kernel creates a device named "ot200-backlight".
>
> This driver has been in the kernel since 2012. If it is used by
> out-of-tree code that code should have been upstreamed by now,
> it's been 8 years.
>
> It uses the idiomatic forked GPIO of the CS5535 which combines
> pin control and GPIO into its private custom interface, which
> causes me a headache because that is not how we do things these
> days: we creates separate pin control and GPIO drivers.
>
> Delete this unused driver.
>
> Cc: Christian Gmeiner <christian.gmeiner@gmail.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/video/backlight/Kconfig | 7 --
> drivers/video/backlight/Makefile | 1 -
> drivers/video/backlight/ot200_bl.c | 162 -----------------------------
> 3 files changed, 170 deletions(-)
> delete mode 100644 drivers/video/backlight/ot200_bl.c
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-07-01 9:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 10:25 [PATCH] backlight: Delete the OT200 backlight driver Linus Walleij
2020-06-26 11:10 ` Daniel Thompson
2020-07-01 9:57 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701095703.GD1179328@dell \
--to=lee.jones@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=linus.walleij@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox