From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68C0AC433DF for ; Thu, 2 Jul 2020 18:21:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3BE3A2084C for ; Thu, 2 Jul 2020 18:21:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="UyCARtoB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3BE3A2084C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EB1146E963; Thu, 2 Jul 2020 18:21:43 +0000 (UTC) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5E8156E9A3 for ; Thu, 2 Jul 2020 18:21:43 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id f7so26609529wrw.1 for ; Thu, 02 Jul 2020 11:21:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3hPvGC/HkagaCR9HulPob6e55+qIh6naoY1GWRQP/P8=; b=UyCARtoBCRxJz8yzvVPLXJEETcY1MimBLC5mOAzoosrh2Pjd8B5VFX7RYHhv8mr5JS w3083ls2AlVka+7WgZ/xxcUj3MIZdGgoB8EaigsY+zuR+Qyn15LDBIjQT2llEb8ZgW4r qZiQP1zLCTgxAAk5J+DqTmc6Q072nB3zsWTo0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3hPvGC/HkagaCR9HulPob6e55+qIh6naoY1GWRQP/P8=; b=FdVcFjZtXPAPVfjVv75zJeM22ntortHBfFtrgL5fn5pcCUZOqYw4pWNUb5gkeS7BqW hSO0Yjfovqu7j/KDJELWb1lBnwl+SHkJ7286svPCys+bJ3jBGpdCn+2fSZ/RsOelImcj LfiWb1UiHmEVf6wqTY+f6QyXjQ5q/yThZBAVC0DnwdsIHVyklEC11FSQUQF1It+2PqEO yN3jMmFXcIyQd1sMtEiERc//kMRw08e5hcyHPaWYQYDqZLop6Tt2TIz/nxE7o9wMkE/A oht2+zM21aBlfTX+boY6+0nagV2d/2Open8nTQq8M87f3xa3Tstzra5A4vbP+QucAQUe q7kw== X-Gm-Message-State: AOAM533P2h+gt8F70MzgsjO5RGAhDVgFetknqYFMYbt6cgkRg2DmSftB /U4erssfQKWr9h+4UhRu5/Zkog== X-Google-Smtp-Source: ABdhPJy9vmA6imnvMObJEUW/p+OQIMBPOpiRjvTTVls/209rJgxCRsDdiiuED8PRwO417cH4YBjhtA== X-Received: by 2002:adf:f14e:: with SMTP id y14mr32774321wro.151.1593714101975; Thu, 02 Jul 2020 11:21:41 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id 30sm12394767wrm.74.2020.07.02.11.21.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 11:21:41 -0700 (PDT) Date: Thu, 2 Jul 2020 20:21:39 +0200 From: Daniel Vetter To: Alex Deucher Subject: Re: [PATCH 2/8] drm/amdgpu: Use __drm_atomic_helper_crtc_reset Message-ID: <20200702182139.GD3278063@phenom.ffwll.local> References: <20200612160056.2082681-1-daniel.vetter@ffwll.ch> <20200612160056.2082681-2-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.6.0-1-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stylon Wang , Daniel Vetter , Intel Graphics Development , Rodrigo Siqueira , Roman Li , DRI Development , Harry Wentland , Alex Deucher , Daniel Vetter , Mikita Lipski , Bhawanpreet Lakha , Nicholas Kazlauskas Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Jun 12, 2020 at 01:41:17PM -0400, Alex Deucher wrote: > On Fri, Jun 12, 2020 at 1:24 PM Harry Wentland wrote: > > > > On 2020-06-12 12:00 p.m., Daniel Vetter wrote: > > > Now also comes with the added benefit of doing a drm_crtc_vblank_off(), > > > which means vblank state isn't ill-defined and fail-y at driver load > > > before the first modeset on each crtc. > > > > > > Signed-off-by: Daniel Vetter > > > Cc: Alex Deucher > > > Cc: Nicholas Kazlauskas > > > Cc: Harry Wentland > > > Cc: Rodrigo Siqueira > > > Cc: Bhawanpreet Lakha > > > Cc: Roman Li > > > Cc: Mikita Lipski > > > Cc: Stylon Wang > > > > Reviewed-by: Harry Wentland > > > > Daniel, do you want to take the whole series, or should I pull this in > through my tree? Either way works for me. Thanks for the patch! Merged the entire series through drm-misc-next now. -Daniel > > Alex > > > Harry > > > > > --- > > > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +--- > > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > > index 68a73065b516..36d605a6eb16 100644 > > > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > > @@ -4594,9 +4594,7 @@ static void dm_crtc_reset_state(struct drm_crtc *crtc) > > > if (WARN_ON(!state)) > > > return; > > > > > > - crtc->state = &state->base; > > > - crtc->state->crtc = crtc; > > > - > > > + __drm_atomic_helper_crtc_reset(crtc, &state->base); > > > } > > > > > > static struct drm_crtc_state * > > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel