From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C0B0C433E0 for ; Fri, 3 Jul 2020 19:24:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3394F207FF for ; Fri, 3 Jul 2020 19:24:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k21Kn1mq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3394F207FF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9559E6EBAE; Fri, 3 Jul 2020 19:24:30 +0000 (UTC) Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 373786EBAB for ; Fri, 3 Jul 2020 19:24:29 +0000 (UTC) Received: by mail-lj1-x244.google.com with SMTP id e4so38223836ljn.4 for ; Fri, 03 Jul 2020 12:24:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TTecFeWhnkJS04/6vJx6YjKZESPPJ5FYJVs0LA7y+wc=; b=k21Kn1mqEpNm0J4N9eAzvMcKPUp80/EqId9x76AOzNJl9hLAaOIE9t4CmymenpSL+3 udl/AkE4Fgu6mhnswUT9gmgT/JGi7invjCJl2IGplYYS7+YYpMQVIJspoqVNmnJ6gLfi SAdNFFWx5H5Z481ufKHtqJU8BXOaCGSUb9L55LKr5ahfW/BwkMpe73t5Pdj8JGcb+HHC jcr4RVapLrdXp7vsmpBvSUmo/khcZE9/pnPcq57O+obBet4iHF9Y8E6jkc7FDLwYCvft gVmEdHiBeab9MRW5xh2gf5vYcItyauCk/UE+tix1wfBIDEifn5N7zehnqI32rreI937k oXNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=TTecFeWhnkJS04/6vJx6YjKZESPPJ5FYJVs0LA7y+wc=; b=lASESnGxdXxIeXMUfajkI/d9b/RHCsVEheWhAZbfyK/8z/jLfnrm6asto2Zf0Jjwus dkeP7iOBNtB+5orumdIbsazv0K8YeD14B0zzY5/EjkM72qlz46oQYVgQ0211u8kOwdAR SRt9mmvOU7GSM87fnHdXswGUkTW4jhehABpBsoPmCvvWYH7rysbTMyU97CEyOGizNI+8 WohGpoD7P5uMlLjO4ZQsTB+MxSIb9c0NvIAY1aNHAak3fEW/kjzWtjhSuskOhPS7kdbi IlbGDEQtB4o++n6cnBJPZ1KsjQDMMWPsDelQc+zXozbQ/E+6HBZiUDnGwv7FyGQU/Hg/ +ulA== X-Gm-Message-State: AOAM5300ZZvaeVS0sImb0J2gmQqDuhOIPfK9yRz2U5gzOG+PGGXdkN00 +rcgzbVBoMGzyuoFE29IzF0OuNWJk7w= X-Google-Smtp-Source: ABdhPJxIL1rwJl7DS1D9whh/28L0b2F3QaArb6NnM64C9SsmbJNcTTjC0M8fdDAeDUtWTXRlCyVYTg== X-Received: by 2002:a2e:700e:: with SMTP id l14mr12971371ljc.131.1593804267477; Fri, 03 Jul 2020 12:24:27 -0700 (PDT) Received: from saturn.lan ([2a00:fd00:805f:db00:4025:a614:1d5c:b7bc]) by smtp.gmail.com with ESMTPSA id y26sm4411791ljm.46.2020.07.03.12.24.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 12:24:27 -0700 (PDT) From: Sam Ravnborg To: dri-devel@lists.freedesktop.org, Laurent Pinchart , Neil Armstrong Subject: [PATCH v3 02/21] drm/panel: panel-simple: add default connector_type Date: Fri, 3 Jul 2020 21:23:58 +0200 Message-Id: <20200703192417.372164-3-sam@ravnborg.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703192417.372164-1-sam@ravnborg.org> References: <20200703192417.372164-1-sam@ravnborg.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Martyn Welch , Jonas Karlman , Peter Senna Tschudin , Andrzej Hajda , Thierry Reding , Sam Ravnborg , kbuild test robot Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" All panels shall report a connector type. panel-simple has a lot of panels with no connector_type, and for these fall back to DPI as the default. Signed-off-by: Sam Ravnborg Cc: Thierry Reding Cc: Sam Ravnborg --- drivers/gpu/drm/panel/panel-simple.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 7b5d212215e0..b3ec965721b0 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -500,6 +500,7 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) struct panel_simple *panel; struct display_timing dt; struct device_node *ddc; + int connector_type; int err; panel = devm_kzalloc(dev, sizeof(*panel), GFP_KERNEL); @@ -566,8 +567,13 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) desc->bpc != 8); } - drm_panel_init(&panel->base, dev, &panel_simple_funcs, - desc->connector_type); + /* Default DRM_MODE_CONNECTOR_DPI if no connector_type is set */ + if (desc->connector_type != 0) + connector_type = desc->connector_type; + else + connector_type = DRM_MODE_CONNECTOR_DPI; + + drm_panel_init(&panel->base, dev, &panel_simple_funcs, connector_type); err = drm_panel_of_backlight(&panel->base); if (err) -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel