From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4F37C433DF for ; Sun, 12 Jul 2020 10:58:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97D5220725 for ; Sun, 12 Jul 2020 10:58:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97D5220725 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 16F726E109; Sun, 12 Jul 2020 10:58:26 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7F8496E109 for ; Sun, 12 Jul 2020 10:58:24 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id DD50B804E5; Sun, 12 Jul 2020 12:58:20 +0200 (CEST) Date: Sun, 12 Jul 2020 12:58:19 +0200 From: Sam Ravnborg To: Laurent Pinchart Subject: Re: [PATCH] drm/panel: panel-simple: validate panel description Message-ID: <20200712105819.GA1079176@ravnborg.org> References: <20200703192417.372164-1-sam@ravnborg.org> <20200703192417.372164-3-sam@ravnborg.org> <20200710221124.GI5964@pendragon.ideasonboard.com> <20200711074807.GA779438@ravnborg.org> <20200711094726.GA940164@ravnborg.org> <20200711225616.GF5954@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200711225616.GF5954@pendragon.ideasonboard.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=aP3eV41m c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=P1BnusSwAAAA:8 a=pGLkceISAAAA:8 a=e5mUnYsNAAAA:8 a=5yPkGzXB_dbRwylh0_8A:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=D0XLA9XvdZm18NrgonBM:22 a=Vxmtnl_E_bksehYqCbjh:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , kbuild test robot , Neil Armstrong , Peter Senna Tschudin , dri-devel@lists.freedesktop.org, Andrzej Hajda , Jonas Karlman , Thierry Reding , Martyn Welch Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Laurent. On Sun, Jul 12, 2020 at 01:56:16AM +0300, Laurent Pinchart wrote: > Hi Sam, > > (CC'ing Daniel) > > Thank you for the patch. > > On Sat, Jul 11, 2020 at 11:47:26AM +0200, Sam Ravnborg wrote: > > Warn is we detect a panel with missing descriptions. > > s/is/if/ > > > This is inpsired by a similar patch by Laurent that introduced checks > > for LVDS panels - this extends the checks to the reminaing type of > > s/reminaing type/remaining types/ > > > connectors. > > > > This is known to fail for some of the existing panels but added > > despite this as we need help from people using the panels to > > add the missing info. > > The checks are not complete but will catch the most common mistakes. > > The checks at the same time serves as documentation for the minimum > > required description for a panel. > > > > Signed-off-by: Sam Ravnborg > > Cc: Laurent Pinchart > > Cc: Thierry Reding > > Cc: Sam Ravnborg > > --- > > > > This is my attempt on the validation described in the previous mail. > > The assignment of default connector_type will then be a follow-up patch > > to this. > > > > Sam > > > > drivers/gpu/drm/panel/panel-simple.c | 32 ++++++++++++++++++++++++++-- > > 1 file changed, 30 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > > index 2aff93accad5..025a7ccdfcb3 100644 > > --- a/drivers/gpu/drm/panel/panel-simple.c > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > @@ -549,8 +549,12 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) > > panel_simple_parse_panel_timing_node(dev, panel, &dt); > > } > > > > - if (desc->connector_type == DRM_MODE_CONNECTOR_LVDS) { > > - /* Catch common mistakes for LVDS panels. */ > > + /* Catch common mistakes for panels. */ > > + switch (desc->connector_type) { > > + case 0: > > + WARN(desc->connector_type == 0, "specify missing connector_type\n"); > > + break; > > + case DRM_MODE_CONNECTOR_LVDS: > > WARN_ON(desc->bus_flags & > > ~(DRM_BUS_FLAG_DE_LOW | > > DRM_BUS_FLAG_DE_HIGH | > > @@ -564,6 +568,30 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) > > WARN_ON((desc->bus_format == MEDIA_BUS_FMT_RGB888_1X7X4_SPWG || > > desc->bus_format == MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA) && > > desc->bpc != 8); > > + break; > > + case DRM_MODE_CONNECTOR_eDP: > > + WARN_ON(desc->bus_format == 0); > > + WARN_ON(desc->bpc != 6 && desc->bpc != 8); > > + break; > > + case DRM_MODE_CONNECTOR_DSI: > > + WARN_ON(desc->bpc != 6 && desc->bpc != 8); > > + break; > > + case DRM_MODE_CONNECTOR_DPI: > > + WARN_ON(desc->bus_flags & > > + ~(DRM_BUS_FLAG_DE_LOW | > > + DRM_BUS_FLAG_DE_HIGH | > > + DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE | > > + DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE | > > + DRM_BUS_FLAG_DATA_MSB_TO_LSB | > > + DRM_BUS_FLAG_DATA_LSB_TO_MSB | > > + DRM_BUS_FLAG_SYNC_SAMPLE_POSEDGE | > > + DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE)); > > + WARN_ON(desc->bus_format == 0); > > + WARN_ON(desc->bpc != 6 && desc->bpc != 8); > > + break; > > + default: > > + WARN(true, "panel has unknown connector_type: %d\n", desc->connector_type); > > + break; > > } > > The checks look sane to me. For LVDS we've added the WARN_ON after > checking all LVDS panels [1], so the warning will only get displayed for > new panel drivers. For other types of panel, this will cause lots of > WARN_ON to trigger. On one hand it gets the issues noticed, which should > help fixing them, but on the other hand it will also scare lots of users > and developers. I'm not sure if we should downgrade that to a dev_warn() > for some time until we get at least the majority of the issues fixed. > Daniel, any opinion ? We should be noisy, but not too noisy. dev_warn() is fine, maybe only dev_info()? Unless I get other feedback I will convert to dev_info() in the next version of the patch. Fixing all panels before we add the checks, is not feasible. Access to datasheet is not easy/possible for many panels. Sam > > [1] Actually not quite, I've just sent "[PATCH] drm: panel: simple: Fix > bpc for LG LB070WV8 panel" to fix one bpc issue. > > > drm_panel_init(&panel->base, dev, &panel_simple_funcs, > > -- > Regards, > > Laurent Pinchart > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel