dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>,
	dri-devel@lists.freedesktop.org
Cc: Madhav.Chauhan@amd.com, michael.j.ruhl@intel.com,
	kbuild-all@lists.01.org, tzimmermann@suse.de
Subject: Re: [PATCH 11/11] drm/ttm: remove TTM_MEMTYPE_FLAG_MAPPABLE
Date: Tue, 21 Jul 2020 17:54:54 +0800	[thread overview]
Message-ID: <202007211753.ymbkSAMf%lkp@intel.com> (raw)
In-Reply-To: <20200721073245.2484-11-christian.koenig@amd.com>

[-- Attachment #1: Type: text/plain, Size: 4153 bytes --]

Hi "Christian,

I love your patch! Yet something to improve:

[auto build test ERROR on drm-tip/drm-tip]
[also build test ERROR on next-20200720]
[cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master drm/drm-next v5.8-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Christian-K-nig/drm-remove-optional-dummy-function-from-drivers-using-TTM/20200721-153530
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/drm_gem_vram_helper.c: In function 'bo_driver_init_mem_type':
>> drivers/gpu/drm/drm_gem_vram_helper.c:1012:16: error: 'TTM_MEMTYPE_FLAG_MAPPABLE' undeclared (first use in this function); did you mean 'TTM_MEMTYPE_FLAG_FIXED'?
    1012 |   man->flags = TTM_MEMTYPE_FLAG_MAPPABLE;
         |                ^~~~~~~~~~~~~~~~~~~~~~~~~
         |                TTM_MEMTYPE_FLAG_FIXED
   drivers/gpu/drm/drm_gem_vram_helper.c:1012:16: note: each undeclared identifier is reported only once for each function it appears in
   drivers/gpu/drm/drm_gem_vram_helper.c: In function 'bo_driver_io_mem_reserve':
   drivers/gpu/drm/drm_gem_vram_helper.c:1065:21: error: 'TTM_MEMTYPE_FLAG_MAPPABLE' undeclared (first use in this function); did you mean 'TTM_MEMTYPE_FLAG_FIXED'?
    1065 |  if (!(man->flags & TTM_MEMTYPE_FLAG_MAPPABLE))
         |                     ^~~~~~~~~~~~~~~~~~~~~~~~~
         |                     TTM_MEMTYPE_FLAG_FIXED

vim +1012 drivers/gpu/drm/drm_gem_vram_helper.c

6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1006  
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1007  static int bo_driver_init_mem_type(struct ttm_bo_device *bdev, uint32_t type,
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1008  				   struct ttm_mem_type_manager *man)
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1009  {
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1010  	switch (type) {
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1011  	case TTM_PL_SYSTEM:
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11 @1012  		man->flags = TTM_MEMTYPE_FLAG_MAPPABLE;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1013  		man->available_caching = TTM_PL_MASK_CACHING;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1014  		man->default_caching = TTM_PL_FLAG_CACHED;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1015  		break;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1016  	case TTM_PL_VRAM:
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1017  		man->func = &ttm_bo_manager_func;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1018  		man->flags = TTM_MEMTYPE_FLAG_FIXED |
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1019  			     TTM_MEMTYPE_FLAG_MAPPABLE;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1020  		man->available_caching = TTM_PL_FLAG_UNCACHED |
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1021  					 TTM_PL_FLAG_WC;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1022  		man->default_caching = TTM_PL_FLAG_WC;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1023  		break;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1024  	default:
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1025  		return -EINVAL;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1026  	}
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1027  	return 0;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1028  }
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1029  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 61112 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2020-07-21  9:55 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21  7:32 [PATCH 01/11] drm: remove optional dummy function from drivers using TTM Christian König
2020-07-21  7:32 ` [PATCH 02/11] drm/ttm: cleanup io_mem interface with nouveau Christian König
2020-07-21  8:50   ` daniel
2020-07-22  7:05   ` Chauhan, Madhav
2020-07-21  7:32 ` [PATCH 03/11] drm/ttm: remove io_reserve_fastpath flag Christian König
2020-07-21  8:52   ` daniel
2020-07-21  7:32 ` [PATCH 04/11] drm/ttm: cleanup coding style and implementation Christian König
2020-07-21  8:56   ` daniel
2020-07-21  7:32 ` [PATCH 05/11] drm/ttm: remove TTM_MEMTYPE_FLAG_CMA Christian König
2020-07-21  9:01   ` daniel
2020-07-21  7:32 ` [PATCH 06/11] drm/radeon: stop using TTM_MEMTYPE_FLAG_MAPPABLE Christian König
2020-07-21  9:24   ` daniel
2020-07-21 14:46     ` Christian König
2020-07-22  5:34       ` Daniel Vetter
2020-07-22 11:13         ` Christian König
2020-07-22 11:42           ` Daniel Vetter
2020-07-22 11:49             ` Christian König
2020-07-22 11:58               ` Daniel Vetter
2020-07-21  7:32 ` [PATCH 07/11] drm/vmwgfx: " Christian König
2020-07-21  9:26   ` daniel
2020-07-21  7:32 ` [PATCH 08/11] drm/amdgpu: " Christian König
2020-07-21  9:28   ` daniel
2020-07-21  9:45     ` Chauhan, Madhav
2020-07-21 14:30     ` Christian König
2020-07-21  7:32 ` [PATCH 09/11] drm/nouveau: " Christian König
2020-07-21  9:28   ` daniel
2020-07-21  7:32 ` [PATCH 10/11] drm/qxl: stop using TTM_MEMTYPE_FLAG_MAPPABLE v2 Christian König
2020-07-21  9:29   ` daniel
2020-07-21  7:32 ` [PATCH 11/11] drm/ttm: remove TTM_MEMTYPE_FLAG_MAPPABLE Christian König
2020-07-21  9:30   ` daniel
2020-07-21  9:54   ` kernel test robot [this message]
2020-07-21  7:55 ` [PATCH 01/11] drm: remove optional dummy function from drivers using TTM Daniel Vetter
2020-07-21  8:02 ` Christian König
2020-07-21  9:15 ` Chauhan, Madhav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202007211753.ymbkSAMf%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=Madhav.Chauhan@amd.com \
    --cc=ckoenig.leichtzumerken@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kbuild-all@lists.01.org \
    --cc=michael.j.ruhl@intel.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox