From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: Dave Airlie <airlied@redhat.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/omap: Use {} to zero initialize the mode
Date: Sat, 25 Jul 2020 00:06:46 +0300 [thread overview]
Message-ID: <20200724210646.GC5921@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200724190718.23567-1-ville.syrjala@linux.intel.com>
Hi Ville,
Thank you for the patch, and sorry for having let this issue slip
through the cracks :-S
On Fri, Jul 24, 2020 at 10:07:18PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The first member of drm_display_mode is no longer a structure, but
> the code is still using {{0}} to zero initialize it. Make that just
> {} so it works regardless of what lies inside.
>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Fixes: 42acb06b01b1 ("drm: pahole struct drm_display_mode")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/omapdrm/omap_connector.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_connector.c b/drivers/gpu/drm/omapdrm/omap_connector.c
> index 528764566b17..de95dc1b861c 100644
> --- a/drivers/gpu/drm/omapdrm/omap_connector.c
> +++ b/drivers/gpu/drm/omapdrm/omap_connector.c
> @@ -89,7 +89,7 @@ static enum drm_mode_status omap_connector_mode_valid(struct drm_connector *conn
> struct drm_display_mode *mode)
> {
> struct omap_connector *omap_connector = to_omap_connector(connector);
> - struct drm_display_mode new_mode = { { 0 } };
> + struct drm_display_mode new_mode = {};
> enum drm_mode_status status;
>
> status = omap_connector_mode_fixup(omap_connector->output, mode,
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-07-24 21:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 19:07 [PATCH] drm/omap: Use {} to zero initialize the mode Ville Syrjala
2020-07-24 19:43 ` Daniel Vetter
2020-07-24 20:04 ` Ville Syrjälä
2020-07-24 20:10 ` Daniel Vetter
2020-07-24 21:06 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724210646.GC5921@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=tomi.valkeinen@ti.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox