From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB1B9C433DF for ; Sun, 26 Jul 2020 21:26:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 766732065F for ; Sun, 26 Jul 2020 21:26:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="dAbDIpVs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 766732065F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F2EAA6E103; Sun, 26 Jul 2020 21:26:18 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 162316E103 for ; Sun, 26 Jul 2020 21:26:17 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4922B304; Sun, 26 Jul 2020 23:26:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1595798775; bh=xCXF96c9a2QmAawxpeCN9WG3PigydXgwcPDo7N5QJSw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dAbDIpVsrjpx4QKZHVKKtwXB8uASZMWbwIHJw4qGI1CX2aVFjl59CiYhzu7t4kvt9 8ZaRtmkyFa23ckdyWcZmzdohfTfYAbUHG2Sz207q9DD6l03R/aGG4oNAKWXtIafcb4 JidiHZtTFP7f03s8OKVOZOF5CKF0x/+wQZVAhBZQ= Date: Mon, 27 Jul 2020 00:26:07 +0300 From: Laurent Pinchart To: Sam Ravnborg Subject: Re: [PATCH v4 02/15] drm/panel: panel-simple: add default connector_type Message-ID: <20200726212607.GF14755@pendragon.ideasonboard.com> References: <20200726203324.3722593-1-sam@ravnborg.org> <20200726203324.3722593-3-sam@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200726203324.3722593-3-sam@ravnborg.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Peter Senna Tschudin , kbuild test robot , Jonas Karlman , Neil Armstrong , dri-devel@lists.freedesktop.org, Martyn Welch , Andrzej Hajda , Thierry Reding , Martin Donnelly Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Sam, Thank you for the patch. On Sun, Jul 26, 2020 at 10:33:11PM +0200, Sam Ravnborg wrote: > All panels shall report a connector type. > panel-simple has a lot of panels with no connector_type, > and for these fall back to DPI as the default. > > v2: > - Rebased on top of validation of panel description > > Signed-off-by: Sam Ravnborg > Cc: Laurent Pinchart > Cc: Thierry Reding > Cc: Sam Ravnborg Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/panel/panel-simple.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index a8d68102931e..56ab073e4e6e 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -500,6 +500,7 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) > struct panel_simple *panel; > struct display_timing dt; > struct device_node *ddc; > + int connector_type; > u32 bus_flags; > int err; > > @@ -550,10 +551,12 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) > panel_simple_parse_panel_timing_node(dev, panel, &dt); > } > > + connector_type = desc->connector_type; > /* Catch common mistakes for panels. */ > - switch (desc->connector_type) { > + switch (connector_type) { > case 0: > dev_warn(dev, "Specify missing connector_type\n"); > + connector_type = DRM_MODE_CONNECTOR_DPI; > break; > case DRM_MODE_CONNECTOR_LVDS: > WARN_ON(desc->bus_flags & > @@ -600,11 +603,11 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) > break; > default: > dev_warn(dev, "Specify a valid connector_type: %d\n", desc->connector_type); > + connector_type = DRM_MODE_CONNECTOR_DPI; > break; > } > > - drm_panel_init(&panel->base, dev, &panel_simple_funcs, > - desc->connector_type); > + drm_panel_init(&panel->base, dev, &panel_simple_funcs, connector_type); > > err = drm_panel_of_backlight(&panel->base); > if (err) -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel