From: Sam Ravnborg <sam@ravnborg.org>
To: dri-devel@lists.freedesktop.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
Martyn Welch <martyn.welch@collabora.co.uk>,
Neil Armstrong <narmstrong@baylibre.com>,
Peter Senna Tschudin <peter.senna@gmail.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Jonas Karlman <jonas@kwiboo.se>,
Thierry Reding <thierry.reding@gmail.com>,
Martin Donnelly <martin.donnelly@ge.com>,
kbuild test robot <lkp@intel.com>
Subject: Re: [PATCH v4 0/15] drm/bridge: support chained bridges + panel updates
Date: Mon, 27 Jul 2020 18:56:22 +0200 [thread overview]
Message-ID: <20200727165622.GA891939@ravnborg.org> (raw)
In-Reply-To: <20200726203324.3722593-1-sam@ravnborg.org>
Hi Laurent/all.
On Sun, Jul 26, 2020 at 10:33:09PM +0200, Sam Ravnborg wrote:
> The objective is that all bridge drivers shall support a chained setup
> connector creation is moved to the display drivers.
> This is just one step on this path.
>
> The general approach for the bridge drivers:
> - Introduce bridge operations
> - Introduce use of panel bridge and make connector creation optional
>
> v4:
> - Dropped patch for ti-sn65dsi86. Await full conversion.
> - Dropped patch for ti-tpd12s015. It was wrong (Laurent)
> - Drop boe,hv070wsa-100 patch, it was applied
> - Combined a few patches to fix connector created twice (Laurent)
> - Fix memory leak in get_edid in several drivers (Laurent)
> - Added patch to validate panel descriptions in panel-simple
> - Set bridge.type in relevant drivers
>
> v3:
> - Rebase on top of drm-misc-next
> - Address kbuild test robot feedback
>
> v2:
> - Updated bus_flags for boe,hv070wsa-100
> - Collected r-b, but did not apply patches yet
> - On the panel side the panel-simple driver gained a default
> connector type for all the dumb panels that do not
> include so in their description.
> With this change panels always provide a connector type,
> and we have the potential to drop most uses of
> devm_drm_panel_bridge_add_typed().
> - Added conversion of a few more bridge drivers
>
> Patches can build but no run-time testing.
> So both test and review feedback appreciated!
>
> Sam
>
> Sam Ravnborg (15):
> drm/panel: panel-simple: validate panel description
> drm/panel: panel-simple: add default connector_type
> drm/bridge: tc358764: drop drm_connector_(un)register
> drm/bridge: tc358764: add drm_panel_bridge support
> drm/bridge: tc358767: add detect bridge operation
> drm/bridge: tc358767: add get_edid bridge operation
> drm/bridge: tc358767: add drm_panel_bridge support
> drm/bridge: parade-ps8622: add drm_panel_bridge support
> drm/bridge: megachips: add helper to create connector
> drm/bridge: megachips: get drm_device from bridge
> drm/bridge: megachips: enable detect bridge operation
> drm/bridge: megachips: add get_edid bridge operation
> drm/bridge: megachips: make connector creation optional
> drm/bridge: nxp-ptn3460: add get_edid bridge operation
> drm/bridge: nxp-ptn3460: add drm_panel_bridge support
Laurent reviewed the full series - thanks!
I went ahead and applied the patches for drivers where all
patches was reviewed.
I will send a v5 soon for tc358767 and nxp-ptn3460 where I have fixed
my brown paper bag bugs
.
I am very happy Laurent spotted these before we applied the patches.
This also gives a good indication of the quality of the review.
Sam
>
> .../drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c | 97 +++++++++-------
> drivers/gpu/drm/bridge/nxp-ptn3460.c | 103 ++++++++---------
> drivers/gpu/drm/bridge/parade-ps8622.c | 100 +++-------------
> drivers/gpu/drm/bridge/tc358764.c | 110 +++---------------
> drivers/gpu/drm/bridge/tc358767.c | 126 +++++++++++----------
> drivers/gpu/drm/panel/panel-simple.c | 48 +++++++-
> 6 files changed, 242 insertions(+), 342 deletions(-)
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-07-27 16:56 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-26 20:33 [PATCH v4 0/15] drm/bridge: support chained bridges + panel updates Sam Ravnborg
2020-07-26 20:33 ` [PATCH v4 01/15] drm/panel: panel-simple: validate panel description Sam Ravnborg
2020-07-26 21:24 ` Laurent Pinchart
2020-07-26 20:33 ` [PATCH v4 02/15] drm/panel: panel-simple: add default connector_type Sam Ravnborg
2020-07-26 21:26 ` Laurent Pinchart
2020-07-26 20:33 ` [PATCH v4 03/15] drm/bridge: tc358764: drop drm_connector_(un)register Sam Ravnborg
2020-09-02 16:48 ` Andrzej Hajda
2020-07-26 20:33 ` [PATCH v4 04/15] drm/bridge: tc358764: add drm_panel_bridge support Sam Ravnborg
2020-07-26 21:37 ` Laurent Pinchart
2020-08-27 11:39 ` [v4,04/15] " Marek Szyprowski
2020-08-30 20:42 ` Sam Ravnborg
2020-09-03 6:20 ` Andrzej Hajda
2020-09-03 9:40 ` [PATCH v4 04/15] " Andrzej Hajda
2020-09-03 9:59 ` Laurent Pinchart
2020-09-03 15:10 ` Andrzej Hajda
2020-07-26 20:33 ` [PATCH v4 05/15] drm/bridge: tc358767: add detect bridge operation Sam Ravnborg
2020-07-26 21:27 ` Laurent Pinchart
2020-07-26 20:33 ` [PATCH v4 06/15] drm/bridge: tc358767: add get_edid " Sam Ravnborg
2020-07-26 21:40 ` Laurent Pinchart
2020-07-26 20:33 ` [PATCH v4 07/15] drm/bridge: tc358767: add drm_panel_bridge support Sam Ravnborg
2020-07-26 21:48 ` Laurent Pinchart
2020-07-27 7:22 ` Sam Ravnborg
2020-07-26 20:33 ` [PATCH v4 08/15] drm/bridge: parade-ps8622: " Sam Ravnborg
2020-07-26 21:54 ` Laurent Pinchart
2020-07-27 15:23 ` Sam Ravnborg
2020-07-26 20:33 ` [PATCH v4 09/15] drm/bridge: megachips: add helper to create connector Sam Ravnborg
2020-07-26 20:33 ` [PATCH v4 10/15] drm/bridge: megachips: get drm_device from bridge Sam Ravnborg
2020-07-26 20:33 ` [PATCH v4 11/15] drm/bridge: megachips: enable detect bridge operation Sam Ravnborg
2020-07-26 20:33 ` [PATCH v4 12/15] drm/bridge: megachips: add get_edid " Sam Ravnborg
2020-07-26 21:57 ` Laurent Pinchart
2020-07-26 20:33 ` [PATCH v4 13/15] drm/bridge: megachips: make connector creation optional Sam Ravnborg
2020-07-26 21:59 ` Laurent Pinchart
2020-07-26 20:33 ` [PATCH v4 14/15] drm/bridge: nxp-ptn3460: add get_edid bridge operation Sam Ravnborg
2020-07-26 22:00 ` Laurent Pinchart
2020-07-26 20:33 ` [PATCH v4 15/15] drm/bridge: nxp-ptn3460: add drm_panel_bridge support Sam Ravnborg
2020-07-26 22:05 ` Laurent Pinchart
2020-07-27 16:56 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727165622.GA891939@ravnborg.org \
--to=sam@ravnborg.org \
--cc=a.hajda@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lkp@intel.com \
--cc=martin.donnelly@ge.com \
--cc=martyn.welch@collabora.co.uk \
--cc=narmstrong@baylibre.com \
--cc=peter.senna@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox