From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 883A6C433E1 for ; Wed, 29 Jul 2020 16:51:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 603332075F for ; Wed, 29 Jul 2020 16:51:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="FAdNtq4E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 603332075F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BA18E6E0DE; Wed, 29 Jul 2020 16:51:03 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 520876E0DE for ; Wed, 29 Jul 2020 16:51:02 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C689D29E; Wed, 29 Jul 2020 18:51:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1596041461; bh=rJjTXG7oHTCq9+/aTzLg9irnYsb8UBgvUgtw7uNJzBA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FAdNtq4EH0NoWuCD169cmQyYZcXtNhAXKorGxiFLylch/dk6QVYdoVKygVCieRTlO Bz0AvNct9L6/DWmKxWGzSeSuvd0096+vmouz8VMdvqNFL5e3D1G5stsh2b+5jtONV/ 6M1wTOzkMw3bmayAEjB1Pk2TUuCV2rG3GzaVzYiQ= Date: Wed, 29 Jul 2020 19:50:52 +0300 From: Laurent Pinchart To: Sam Ravnborg Subject: Re: [PATCH 1/3] rapidio: Replace 'select' DMAENGINES 'with depends on' Message-ID: <20200729165052.GN6183@pendragon.ideasonboard.com> References: <20200729162910.13196-1-laurent.pinchart@ideasonboard.com> <20200729162910.13196-2-laurent.pinchart@ideasonboard.com> <20200729164326.GA1371039@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200729164326.GA1371039@ravnborg.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Hyun Kwon , Randy Dunlap , Liam Girdwood , dri-devel@lists.freedesktop.org, Michal Simek , Alexandre Bounine , Vinod Koul , Mark Brown , dmaengine@vger.kernel.org, Matt Porter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Sam, On Wed, Jul 29, 2020 at 06:43:26PM +0200, Sam Ravnborg wrote: > On Wed, Jul 29, 2020 at 07:29:08PM +0300, Laurent Pinchart wrote: > > Enabling a whole subsystem from a single driver 'select' is frowned > > upon and won't be accepted in new drivers, that need to use 'depends on' > > instead. Existing selection of DMAENGINES will then cause circular > > dependencies. Replace them with a dependency. > > > > Signed-off-by: Laurent Pinchart > > Acked-by: Randy Dunlap > > --- > > drivers/rapidio/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/rapidio/Kconfig b/drivers/rapidio/Kconfig > > index e4c422d806be..b9f8514909bf 100644 > > --- a/drivers/rapidio/Kconfig > > +++ b/drivers/rapidio/Kconfig > > @@ -37,7 +37,7 @@ config RAPIDIO_ENABLE_RX_TX_PORTS > > config RAPIDIO_DMA_ENGINE > > bool "DMA Engine support for RapidIO" > > depends on RAPIDIO > > - select DMADEVICES > > + depends on DMADEVICES > > $subject and changlog talks about DMAENGINES but the patch touches DMADEVICES?? Clearly a typo in the subject line, it should be DMADEVICES. I'll wait a little bit to see if there are more comments, and will send a v2. > > select DMA_ENGINE > > help > > Say Y here if you want to use DMA Engine frameork for RapidIO data -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel